[QuantumToast]

Originally Posted by Headline reading information on OnMapStart and then write to it on OnMapEnd. Maybe something like this will start you off. Create a KeyValues file structured like below OnMapStart use FileToKeyValues to load KeyValues in Cache KeyValues handle globally to allow us to lookup client info OnClientPostAdminCheck search the tree for their steamid, if it exists set some boolean somewhere to true so we know they have some infraction count. EDIT: Give me a few minutes I'll give you some code Here's some inspiration *snip*

Thank you for that, I'll be sure to use that as a good reference when writing my own file I/O

Originally Posted by Peace-Maker You could have a look at this plugin which does most of what you want. I know you do this for learning purposes, but maybe you want to extend that plugin and add the other features you had in mind.

Wow, I'm honestly not sure how I didn't find that plugin. It does accomplish a lot of what I wanted out of Infractions, but like you said, this is a learning experience for me, and I get to customize it to my liking and add/remove features! I may look into what you suggested, but I'll see how everything goes, for now.

I haven't really had much time to compile and test the plugin, but I've got a dilemma that may or may not actually BE a dilemma. So, one of my cvars, sm_infractions_custom_command, can be used to set a custom external command (default is sm_slay). In OnPluginStart(), I have this written:

PHP Code:

AddCommandListener(CustomCallback, GetCustomCommandString(InfractionsCustomCommand)); 


GetCustomCommandString(ConVar custom) is a custom function I've written which returns the value of the cvar sm_infractions_custom_command so OnPluginStart() is less cluttered. What would happen with AddCommandListener() if the server had the cvar set to "", i.e. that the server does not wish to use a custom command?
I was thinking, maybe have a function somewhere that would call RemoveCommandListener() when the cvar is empty (""), and re-call AddCommandListener() when the cvar is set to a different value? Is that just making things overly complicated, or is it a failsafe?

[headline]

Originally Posted by QuantumToast Is that just making things overly complicated, or is it a failsafe?

Idk about it being a fail-safe, but yeah you should definitely handle that situation. I'd do it in exactly the way you described

[QuantumToast]

In the code below,

PHP Code:

InfractionsCooldown = CreateConVar("sm_infractions_cooldown", "7", "Number of days between infraction cooldowns, set to 0 to never cooldown", true, 0.0); 


I am getting a tag mismatch warning when compiling. Is it because if I'm going to specify a minimum, I have to include the flags, because that argument comes first? Or, how would I correct this to specify a minimum of 0 and nothing else?
The API has the syntax for CreateConVar as:

PHP Code:

ConVar CreateConVar(const char[] name, const char[] defaultValue, const char[] description, int flags, bool hasMin, float min, bool hasMax, float max) 


Edit: Disregard, I figured out the problem, and at least that part's working, for now.

[Fyren]

Originally Posted by QuantumToast In the code below, I am getting a tag mismatch warning when compiling.

PHP Code:

InfractionsCooldown = CreateConVar("sm_infractions_cooldown", "7", "Number of days between infraction cooldowns, set to 0 to never cooldown", _, true, 0.0); 


Use _ to indicate you want the default value. This assumes there is one (and there is for CreateConVar, you can look at the actual native definition in the include file to see it).

Regarding SQL and a DB, for something like this you absolutely do want to use a DB. Since you aren't looking to share data over a network, you should use the built-in sqlite support in SM. Piggybacking off clientprefs might be possible, but probably more annoying than it's worth.

For banning, SM provides OnBanClient and OnBanIdentity forwards. For kicking, there's no forward but looking for the server command kickid rather than the SM command might work out better. (There's also banid and banip if for some reason the forwards for banning aren't sufficient.)

[QuantumToast]

Originally Posted by Fyren Regarding SQL and a DB, for something like this you absolutely do want to use a DB. Since you aren't looking to share data over a network, you should use the built-in sqlite support in SM. Piggybacking off clientprefs might be possible, but probably more annoying than it's worth.

Again, I do understand the advantages of SQL over a regular keyvalues file, but I'd literally have to ask someone to hand-hold me through it, since I have absolutely ZERO experience with anything related to SQL, aside from manually editing .db files.

Originally Posted by Fyren For banning, SM provides OnBanClient and OnBanIdentity forwards. For kicking, there's no forward but looking for the server command kickid rather than the SM command might work out better. (There's also banid and banip if for some reason the forwards for banning aren't sufficient.)

Regarding your reference to kickid, would that only work if an admin ran kickid as opposed to sm_kick? That would be easier said than done, but most of the admins are familiar with sm_kick. People are stubborn, blah. I'd happily hook kickid instead, but....

[hmmmmm]

Honestly I think doing SQL is easier than reading/saving to a file, since a lot of the work is done for you

[QuantumToast]

Would either of you be so kind as to point me to a good tutorial for using SQL with Sourcemod? I tried using it before, for the Store plugin, and I was truly unsuccessful. If it changes anything, I'm running my server on its own remote gameserver, so I shouldn't be hosting the database from my local machine.

[QuantumToast]

Well, here's some progress on the core functions before I start messing with keyvalue files and/or SQL databases. This is just a snippet of the whole source, but the program did successfully compile!

PHP Code:

*snip*
    // Stuff
    if(InfractionsCustomCommand != null)
    {
        HookConVarChange(InfractionsCustomCommand, OnCustomCommandChange);
    }
}

public void OnCustomCommandChange(ConVar convar, const char[] oldValue, const char[] newValue)
{
    if(strcmp(newValue, "") == 0) // if the cvar string is empty "", meaning there is no custom command
    {
        RemoveCommandListener(CustomCallback, oldValue);
    }
    else
    {
        RemoveCommandListener(CustomCallback, oldValue);
        AddCommandListener(CustomCallback, newValue);
    }
}

public bool IsCvarStringEmpty(ConVar convar)
{
    char buffer[128];
    convar.GetString(buffer,128);
    if(strcmp(buffer, "") == 0) return true;
    else return false;
} 


Just checking if anyone's noticing any glaring issues...I know that just because a program compiles, doesn't mean it works correctly

[hmmmmm]

Here's an example plugin that I got from here: https://forums.alliedmods.net/showthread.php?t=175245 and updated to new syntax.

[Fyren]

SM itself only runs kickid to actually kick anyone. It also only actually runs banid and banip to ban anyone. All roads lead to Rome, unless it's a road not built by SM.

If the purpose is to learn, then SQL seems to fit the bill if you don't know anything. There's SM docs about the SQL API, but they're not a tutorial on SQL itself. There are a million tutorials about SQL itself you can find online. It might be useful to download an sqlite shell from http://sqlite.org (docs) to play around with running queries by just typing them instead of having to run a SM script or an actual SQL server.