Raised This Month: $32 Target: $400
 8% 

New patches have been pushed into the repository


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
Seta00
The Seta00 user has crashed.
Join Date: Jan 2010
Location: Berlin
Old 12-13-2010 , 15:06   New patches have been pushed into the repository
Reply With Quote #1

A few patches have been rolled into the AMXx repo today by our dear friend BAILOPAN:
  • Fysiks - Fix menu_create() documentation
  • fezh - Add documentation to set_view
  • joaquimandrade - Fix TrieSetArray reading the wrong parameter
  • Seta00 - Fix time drift on repeating tasks

Be sure to check 'em out at the repo, and to test the new dev builds.

Cheers!
Seta00 is offline
fezh
Veteran Member
Join Date: Dec 2008
Location: BANNED
Old 12-13-2010 , 15:13   Re: New patches have been pushed into the repository
Reply With Quote #2

I'm lazy to check out the documentation. Has the "bug" with set_view been fixed using an already-precached model (what should be obvious)?
__________________
"There is no knowledge, that is not power"
fezh is offline
Seta00
The Seta00 user has crashed.
Join Date: Jan 2010
Location: Berlin
Old 12-13-2010 , 15:20   Re: New patches have been pushed into the repository
Reply With Quote #3

Quote:
Originally Posted by fezh View Post
I'm lazy to check out the documentation. Has the "bug" with set_view been fixed using an already-precached model (what should be obvious)?
It was merely a documentation change, now the include file states

Code:
/* rpgrocket.mdl must be precached in order for this function to work */

Right before the function
Seta00 is offline
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 12-13-2010 , 15:21   Re: New patches have been pushed into the repository
Reply With Quote #4

Just the a documentation update telling you must precache the model.

It would be nice if the others bugs were reviewed too...
__________________

Last edited by Arkshine; 12-13-2010 at 15:24.
Arkshine is offline
Seta00
The Seta00 user has crashed.
Join Date: Jan 2010
Location: Berlin
Old 12-13-2010 , 15:22   Re: New patches have been pushed into the repository
Reply With Quote #5

hi arkshine
Seta00 is offline
fysiks
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
Old 12-13-2010 , 18:41   Re: New patches have been pushed into the repository
Reply With Quote #6

Quote:
Originally Posted by Arkshine View Post
It would be nice if the others bugs were reviewed too...
Like what? Maybe you should start fixing the bugs so they can be reviewed .
__________________
fysiks is offline
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 12-13-2010 , 18:49   Re: New patches have been pushed into the repository
Reply With Quote #7

My thought was more : if you would be nice if there were some people (who know how to use hg and such) reviewing some bugs and providing a diff. I'm talking about bugs where there is a fix but without diff.

EDIT: #4656, #4576, #4445, #3752, etc.

Anyway it was not a critic to BAIL but more a straight thought in hoping some guy with solid C++/pawn/game knowledge would take some time to help to fix the current opened issues.
__________________

Last edited by Arkshine; 12-13-2010 at 19:04.
Arkshine is offline
Exolent[jNr]
Veteran Member
Join Date: Feb 2007
Location: Tennessee
Old 12-13-2010 , 19:34   Re: New patches have been pushed into the repository
Reply With Quote #8

I actually qualify for those criteria but I have no idea how to use Mercurial.
That is why I never posted a diff for my fix.
__________________
No private work or selling mods.
Quote:
Originally Posted by xPaw View Post
I love you exolent!
Exolent[jNr] is offline
Seta00
The Seta00 user has crashed.
Join Date: Jan 2010
Location: Berlin
Old 12-13-2010 , 19:37   Re: New patches have been pushed into the repository
Reply With Quote #9

I'll start posting patches for all those bugs as soon as possible (the day after tomorrow)
Seta00 is offline
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 12-13-2010 , 21:54   Re: New patches have been pushed into the repository
Reply With Quote #10

To help I've tried to sort fastly out the issues. It may contain some misplacements.

Needs a diff :

bug 4656, bug 4576, bug 4445, bug 4070, bug 3993, bug 3752, bug 3553, bug 3232, bug 3199, bug 3192, bug 3068, bug 3243

Needs to be verified (easy) :

bug 4746, bug 4591, bug 4073, bug 4096, bug 3884, bug 3806, bug 3795, bug 3781, bug 3764, bug 3758, bug 3681, bug 3664, bug 3594, bug 3558, bug 3470, bug 3416, bug 3394, bug 3248, bug 3239, bug 3234, bug 3231, bug 3224, bug 3219, bug 3205, bug 3203, bug 3140, bug 4330

Needs to be verified (hard, crash/not working case) :

bug 4590, bug 4465, bug 4110, bug 4115, bug 3965, bug 3785, bug 3744, bug 3581, bug 3579, bug 3499, bug 3396, bug 3202, bug 3374

Needs to be discussed/Needs code :

bug 4570, bug 4543, bug 3995, bug 3981, bug 3854, bug 3787, bug 3754, bug 3649, bug 3527, bug 3241, bug 3240, bug 3226, bug 3225, bug 3223, bug 3218, bug 3197, bug 3164, bug 3142, bug 3134, bug 3133, bug 3126, bug 3096, bug 3056, bug 3040, bug 3028, bug 3171, bug 2974, bug 2852

New/Enchanced translation :

bug 4528, bug 3753, bug 3236

Bugs/Requests with diffs and reviewed, needs bail :

bug 4070, bug 4061, bug 3997, bug 3233

Should be closed :

bug 4601, bug 4480, bug 4328, bug 4266, bug 4167, bug 4164, bug 4163, bug 4002, bug 3998, bug 3991, bug 3846, bug 3774, bug 3749, bug 3665, bug 3596, bug 3393, bug 3390, bug 3348, bug 3249, bug 3237, bug 3229, bug 3220, bug 3213, bug 3212, bug 3211, bug 3210, bug 3081, bug 3033, bug 3147,
__________________

Last edited by Arkshine; 12-22-2010 at 13:22.
Arkshine is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 21:12.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode