[yokomo]

Hi, i tried to make my own NMRiH item giver via menu, but when i choose any item it give me nothing.

Source

PHP Code:

#include <sourcemod>

new const String:szItemEntNames[][] =
{
    "fa_1911","fa_glock17","fa_mkii","fa_sw686","fa_m92fs","fa_1022","fa_cz858","fa_sako85","fa_jae700","fa_sks","fa_500a","fa_870",
    "fa_superx3","fa_sv10","fa_winchester1892","fa_mac10","fa_mp5a3","fa_m16a4","bow_deerhunter","me_axe_fire","me_bat_metal","me_chainsaw",
    "me_crowbar","me_etool","me_fubar","me_hatchet","me_kitknife","me_machete","me_pipe_lead","me_shovel","me_sledge","me_wrench","exp_grenade",
    "exp_molotov","exp_tnt","tool_barricade","tool_extinguisher","tool_welder","tool_flare_gun","item_bandages","item_first_aid","item_maglite",
    "item_pills","item_walkietalkie","ammobox_9mm","ammobox_45acp","ammobox_357","ammobox_12gauge","ammobox_22lr","ammobox_308","ammobox_556",
    "ammobox_762mm","ammobox_arrow","ammobox_flare","ammobox_board","ammobox_fuel"
}

public Plugin:myinfo = 
{
    name = "Noob 4 Dead Utils",
    author = "wbyokomo",
    description = "Noob 4 Dead Utils",
    version = "0.0.1",
    url = "www.n4d.info"
}

public OnPluginStart()
{
    RegConsoleCmd("n4dgive", CmdMenuGiveItems)
    RegConsoleCmd("n4dammo", CmdGiveCurrentAmmo)
}

public Action:CmdMenuGiveItems(client, args)
{
    new Handle:menu = CreateMenu(MenuGiveItemsHandler)
    SetMenuTitle(menu, "N4D Item Giver:")
    new j
    for(j=0; j < sizeof szItemEntNames; j++) AddMenuItem(menu, szItemEntNames[j], szItemEntNames[j]);
    
    SetMenuExitButton(menu, false)
    DisplayMenu(menu, client, 30)
    return Plugin_Handled;
}

public Action:CmdGiveCurrentAmmo(client, args)
{
    //this work perfect
    new flags = GetCommandFlags("givecurrentammo")
    SetCommandFlags("givecurrentammo", flags & ~FCVAR_CHEAT)
    FakeClientCommand(client, "givecurrentammo")
    SetCommandFlags("givecurrentammo", flags|FCVAR_CHEAT)
    return Plugin_Handled;
}

public MenuGiveItemsHandler(Handle:menu, MenuAction:action, param1, param2)
{
    if(action == MenuAction_Select)
    {
        new String:info[32]
        new bool:found = GetMenuItem(menu, param2, info, sizeof(info))
        if(found)
        {
            //this give nothing :(
            new flags = GetCommandFlags("give")
            SetCommandFlags("give", flags & ~FCVAR_CHEAT)
            FakeClientCommand(param1, "give %s", szItemEntNames[param2])
            SetCommandFlags("give", flags|FCVAR_CHEAT)
        }
    }
    else if(action == MenuAction_Cancel) CloseHandle(menu);
    else if(action == MenuAction_End) CloseHandle(menu);
} 


What is wrong with my code?

[The1Speck]

It would be better to use the built-in sdktools function GivePlayerItem instead. Granted, if NMRiH supports it which afaik does.

[API]

Yes he is right. Use GivePlayerItem.