[Supremache]

Hello guys,
I was editing zombie classess of basebuilder mod and i was want to change admin access to level access and i did it but i have something wrong, When i checked it the menu didn't show all classes and i said the problem in number of the menu and i changed it from menu[512] to menu[2048] but i still have the same problem so can someone tell me how to fix that or where is the problem Oo

The problem


Orginal menu with admin access

PHP Code:

public show_zclass_menu(id,offset)
{
    if(offset<0) offset = 0

    new keys, curnum, menu[512], szCache1[32], szCache2[32], iCache3
    for(new i=offset;i<g_iZClasses;i++)
    {
        ArrayGetString(g_zclass_name, i, szCache1, charsmax(szCache1))
        ArrayGetString(g_zclass_info, i, szCache2, charsmax(szCache2))
        iCache3 = ArrayGetCell(g_zclass_admin, i)
        
        // Add to menu
        if (i == g_iZombieClass[id])
            format(menu,511,"%s^n\r[\d%d\r].\d %s \r[ \y%s\r ] \r-=\wSELECTED\r=-", menu, curnum+1, szCache1, szCache2, iCache3 == ADMIN_ALL  ? "" :"" )
        else
            format(menu,511,"%s^n\r[\w%d\r].\w %s \r[ \y%s\r ]", menu, curnum+1, szCache1, szCache2, iCache3 == ADMIN_ALL ? "" : "" )
        
        g_iMenuOptions[id][curnum] = i
        keys += (1<<curnum)
    
        curnum++
        
        if(curnum==8)
            break;
    }

    format(menu,511,"\ySelect Your Class:^n\r%s^n", menu)
    if(curnum==8 && offset<12)
    {
        keys += (1<<8)
        format(menu,511,"%s^n\r[\w9\r].\w Next",menu)
    }
    if(offset)
    {
        keys += (1<<9)
        format(menu,511,"%s^n\r[\w0\r].\w Back",menu)
    }

    show_menu(id,keys,menu,-1,"ZClassSelect")
} 


What i did with level access

PHP Code:

public show_zclass_menu(id,offset)
{
    if(offset<0) offset = 0

    new keys, curnum, menu[512], szCache1[32], szCache2[32], iCache3
    for(new i=offset;i<g_iZClasses;i++)
    {
        ArrayGetString(g_zclass_name, i, szCache1, charsmax(szCache1))
        ArrayGetString(g_zclass_info, i, szCache2, charsmax(szCache2))
        iCache3 = ArrayGetCell(g_zclass_lvl, i)
        
        if(get_user_level(id) >= ArrayGetCell(g_zclass_lvl, i))
        {
            if (i == g_iZombieClass[id])
            {
                if(ArrayGetCell(g_zclass_lvl, i) > 0)
                {
                    format(menu, 511,"%s^n\r[\d%d\r].\d %s \r[ \y%s\r ] \d(Level :: %d) \r-=\wSELECTED\r=-", menu, curnum+1, szCache1, szCache2, iCache3)
                }
                else
                {
                    format(menu, 511, "%s^n\r[\d%d\r].\d %s \r[ \y%s\r ] \r-=\wSELECTED\r=-", menu, curnum+1, szCache1, szCache2)
                }
            }
            else
            {
                if(ArrayGetCell(g_zclass_lvl, i) > 0)
                {
                    format(menu, 511,"%s^n\r[\w%d\r].\w %s \r[ \y%s\r ] \r(\wLevel\r ::\w %d\r)", menu, curnum+1, szCache1, szCache2, iCache3)
                }
                else
                {
                    format(menu, 511, "%s^n\r[\w%d\r].\w %s \r[ \y%s\r ]", menu, curnum+1, szCache1, szCache2)
                }
            }
        }
        else
        {
            format(menu, 511, "%s^n\r[\w%d\r].\w %s \r[ \y%s\r ] \r(\wLevel\r ::\w %d\r)", menu, curnum+1, szCache1, szCache2, iCache3)
        }
        // Add to menu
        //if (i == g_iZombieClass[id])
        //    format(menu,511,"%s^n\r[\d%d\r].\d %s \r[ \y%s\r ] \r-=\wSELECTED\r=-", menu, curnum+1, szCache1, szCache2, iCache3 == ADMIN_ALL  ? "" :"" )
        //else
        //    format(menu,511,"%s^n\r[\w%d\r].\w %s \r[ \y%s\r ]", menu, curnum+1, szCache1, szCache2, iCache3 == ADMIN_ALL ? "" : "" )
        
        g_iMenuOptions[id][curnum] = i
        keys += (1<<curnum)
    
        curnum++
        
        if(curnum==8)
            break;
    }

    format(menu,511,"\ySelect Your Class:^n\r%s^n", menu)
    if(curnum==8 && offset<12)
    {
        keys += (1<<8)
        format(menu,511,"%s^n\r[\w9\r].\w Next",menu)
    }
    if(offset)
    {
        keys += (1<<9)
        format(menu,511,"%s^n\r[\w0\r].\w Back",menu)
    }

    show_menu(id,keys,menu,-1,"ZClassSelect")
} 


[OciXCrom]

The maximum amount of character that a menu can display is 512. You cannot go above this limit. Color symbols are counted too and you have a lot of them.

From amxconst.inc:

#define MAX_MENU_LENGTH 512 

And no, changing this value in amxconst.inc won't allow you to exceed it. This is hardcoded in the game itself.

[Supremache]

Originally Posted by OciXCrom The maximum amount of character that a menu can display is 512. You cannot go above this limit. Color symbols are counted too and you have a lot of them. From amxconst.inc: #define MAX_MENU_LENGTH 512 And no, changing this value in amxconst.inc won't allow you to exceed it. This is hardcoded in the game itself.

So i can't fix it ? or i need to change the full menu?

[OciXCrom]

Reduce the number of characters you have in the menu. You can start by removing the ' in the square brackets because that's not how English works.

[Natsheh]

Remove keyword zombie and free from The menu

[Supremache]

@OciXcrom - I did it before in zombie plague mod and worked perfectly without anyproblem , i think the problem in something in that menu

@Natsheh - Can you give me example

[Supremache]

I changed it from 512 to 2048 and keys from 511 to 2047 and i still have the same thing

PHP Code:

public show_zclass_menu(id,offset)
{
    if(offset<0) offset = 0

    new keys, curnum, menu[2048], szCache1[32], szCache2[32], iCache3
    for(new i=offset;i<g_iZClasses;i++)
    {
        ArrayGetString(g_zclass_name, i, szCache1, charsmax(szCache1))
        ArrayGetString(g_zclass_info, i, szCache2, charsmax(szCache2))
        iCache3 = ArrayGetCell(g_zclass_lvl, i)
        
        // Add to menu
        if (i == g_iZombieClass[id])
            format(menu,2047,"%s^n\r[\d%d\r].\d %s \r[ \y%s\r ] \d(Level :: %d) \r-=\wSELECTED\r=-", menu, curnum+1, szCache1, szCache2, iCache3)
        else
            format(menu,2047,"%s^n\r[\w%d\r].\w %s \r[ \y%s\r ] \r(\wLevel\r ::\w %d\r)", menu, curnum+1, szCache1, szCache2, iCache3)
        
        g_iMenuOptions[id][curnum] = i
        keys += (1<<curnum)
    
        curnum++
        
        if(curnum==8)
            break;
    }

    format(menu,2047,"\ySelect Your Class:^n\r%s^n", menu)
    if(curnum==8 && offset<12)
    {
        keys += (1<<8)
        format(menu,2047,"%s^n\r[\w9\r].\w Next",menu)
    }
    if(offset)
    {
        keys += (1<<9)
        format(menu,2047,"%s^n\r[\w0\r].\w Back",menu)
    }

    show_menu(id,keys,menu,-1,"ZClassSelect")
} 


[DruGzOG]

Originally Posted by Supremache @OciXcrom - I don't understand, do you mean I should change the number of words menu, If you mean that so I did it before and I changed the number from 512 to 2048 and i have got the same thing @Natsheh - Can you give me example

As in reduce the amount of letters you have. The engine has a limit to the amount of characters you can use.

[Supremache]

Originally Posted by DruGzOG As in reduce the amount of letters you have. The engine has a limit to the amount of characters you can use.

When i was using admin access it was working without showing this problem and after i added level access i got this problem, i think the problem not in the amount of letters

[Supremache]

There's no one know how to fix it !!!! ?