[Whai]

Originally Posted by Doggg ofc its not 32 chars because that will be stupid. but what is it?

Hum... Actually it IS.


btw, here is a guide for you to understand. (this can also help you)

[Doggg]

Originally Posted by Whai Hum... Actually it IS. btw, here is a guide for you to understand. (this can also help you)

hahahahahaha, i thought there is some logic behind this.
Thanks, I will look at the guide.
wait, so char in the size of 4 woudlnt be enough for mp restart 15 for example? i mean i am not planning to enter a 32 length number for the mp restart command.

[Whai]

Well,

char value[4] is an array of char (char is the abbreviation of characters) with the size of 4 but there is an exception only on arrays of char.

First, index of arrays go from 0 to the size - 1, that means if you create an array with the size of 4 (meaning you'll have 4 places to store item) : it will go from 0 to 3.
However, on arrays of char (in sourcemod or maybe others programming languages) the last index is reserved to place the "\0" --> it means the end of the "word".

By creating an array of char with the length of 4, you will have 3 free places.

In conclusion, yes : if you write "15" you need at least 2 free places.

Note : I wrote all of this to make this for you understand roughly speaking how works array in SM

[Doggg]

Originally Posted by Whai Well, char value[4] is an array of char (char is the abbreviation of characters) with the size of 4 but there is an exception only on arrays of char. First, index of arrays go from 0 to the size - 1, that means if you create an array with the size of 4 (meaning you'll have 4 places to store item) : it will go from 0 to 3. However, on arrays of char (in sourcemod or maybe others programming languages) the last index is reserved to place the "\0" --> it means the end of the "word". By creating an array of char with the length of 4, you will have 3 free places. In conclusion, yes : if you write "15" you need at least 2 free places. Note : I wrote all of this to make this for you understand roughly speaking how works array in SM

Thanks for the time you put into this, I knew most of this, It is very similar to C (at least i think it is) you have any idea why the guy here put 32 in the code? 32 looks bit too much for me. i mean i think the max is going to be 5 (this is means i can put up to 1000 right?, 4 free spaces.

[Whai]

Originally Posted by Doggg you have any idea why the guy here put 32 in the code? 32 looks bit too much for me.

I don't know, maybe he was thinking about float value

Originally Posted by Doggg I knew most of this

Ah yes I forgot. Good then, if there is errors I did : you will not be affected

[I am inevitable]

Don’t use ServerCommand.

[nosoop]

Originally Posted by I am inevitable Don’t use ServerCommand.

Saying "Don't use ServerCommand" is like saying "Don't use SQL". It could use a better explanation.

What you mean to say is "Don't use ServerCommand with unsanitized, untrusted input because someone can easily throw in a ; quit; // and ruin your day".

Of course, if there's a better, safer way to do it, then that'd be preferable.

If you're expecting a number, use StringToInt and use the %d format specifier. IF you're expecting a convar, make sure it exists with FindConVar, and so on.

[I am inevitable]

Originally Posted by nosoop Saying "Don't use ServerCommand" is like saying "Don't use SQL". It could use a better explanation. What you mean to say is "Don't use ServerCommand with unsanitized, untrusted input because someone can easily throw in a ; quit; // and ruin your day". Of course, if there's a better, safer way to do it, then that'd be preferable. If you're expecting a number, use StringToInt and use the %d format specifier. IF you're expecting a convar, make sure it exists with FindConVar, and so on.

Yeah, you're completely right. My bad.

Here's a way of safely setting convar values (strings in this case):

PHP Code:

void something()
{
    // find the convar
    ConVar hConVar = FindConVar("");
    
    SetConvarStringSafe(hConVar, sString);
}

bool SetConvarStringSafe(ConVar hConVar, char[] sString)
{
    // if the convar is invalid, then don't do anything
    if (hConVar == null)
        return false;
    
    else
        hConVar.SetString(sString);
    
    return true;
} 


[Whai]

Originally Posted by I am inevitable ~snip~

In this case, we do not need your code because we already know that ConVar (mp_restartgame) exist

PHP Code:


public Action rr(int iClient, int iArgs) {
    if(iArgs< 1) { 
        ReplyToCommand(client, "[SM] Usage: sm_rr <seconds>"); 
        return Plugin_Handled; 
    } 
    char strValue[8]; // 8 just in case of float value

    GetCmdArg(1, strValue, sizeof(strValue));
    float fValue = StringToFloat(strValue);

    if(!(!fValue)) //if fValue is not equal to 0.0
        ServerCommand("mp_restartgame %0.2f", fValue); // 0.2 meaning 2 digits after the decimal point
    
    else
    {
        ReplyToCommand(iClient, "[SM] Invalid value entered !");
        return Plugin_Handled
    }
    return Plugin_Handled;  
} 


If you are asking why I changed variables' name : because it is more easy to debug for me

Just in case if you are interested

array of char --> "str" prefix
char --> "c" prefix
int or array of int --> "i" prefix
float or array of float --> "fl" or "f" prefix

every var declared on the global scope --> "g_" (before prefix)

[Doggg]

Originally Posted by Whai In this case, we do not need your code because we already know that ConVar (mp_restartgame) exist PHP Code: public Action rr(int iClient, int iArgs) {     if(iArgs< 1) {          ReplyToCommand(client, "[SM] Usage: sm_rr <seconds>");          return Plugin_Handled;      }      char strValue[8]; // 8 just in case of float value     GetCmdArg(1, strValue, sizeof(strValue));     float fValue = StringToFloat(strValue);     if(!(!fValue)) //if fValue is not equal to 0.0         ServerCommand("mp_restartgame %0.2f", fValue); // 0.2 meaning 2 digits after the decimal point          else     {         ReplyToCommand(iClient, "[SM] Invalid value entered !");         return Plugin_Handled     }     return Plugin_Handled;   }  If you are asking why I changed variables' name : because it is more easy to debug for me Just in case if you are interested array of char --> "str" prefix char --> "c" prefix int or array of int --> "i" prefix float or array of float --> "fl" or "f" prefix every var declared on the global scope --> "g_" (before prefix)

now i need you to treat me like a dummy xD
what ConVar is? i have no idea. and why in this code you went on float?