[amirwolf]

Hello
I have this error

L 01/22/2022 - 17:18:02: [ENGINE] Invalid entity 189
L 01/22/2022 - 17:18:02: [AMXX] Displaying debug trace (plugin "basebuilder65.amxx")
L 01/22/2022 - 17:18:02: [AMXX] Run time error 10: native error (native "entity_get_int")
L 01/22/2022 - 17:18:02: [AMXX]    [0] basebuilder65.sma::cmdStopEnt (line 2373)
L 01/22/2022 - 17:18:02: [AMXX]    [1] basebuilder65.sma::fw_CmdStart (line 2247)

[iceeedr]

is_valid_ent(ent)
{
       ....
}

[amirwolf]

I realized the mistake
thank you
I will try it

[Natsheh]

Actually it should be pev_valid because pev_valid have more necessarily checks than is_valid_ent from engine.

[CrazY.]

Not sure where you read that but that is not valid, is_valid_ent works just as expected. We're in 1.10 now, I'm sure if there was a problem with is_valid_ent someone would have already reported.

[Natsheh]

Originally Posted by CrazY. Not sure where you read that but that is not valid, is_valid_ent works just as expected. We're in 1.10 now, I'm sure if there was a problem with is_valid_ent someone would have already reported.

I didn't point out there is a problem in is_valid_ent, it only checks if the entity index is less than the maximum entities count in the other hand pev_valid do some extra useful checks, you can check the source code of both natives and see the difference.

[CrazY.]

is_valid_ent does the same thing that pev_valid does, the only difference is that pev_valid will return 2 when the entity's private data is ready to be used by fakemeta's pdata natives. I guess you didn't read the source either.

static cell AMX_NATIVE_CALL amx_pev_valid(AMX *amx, cell *params)
{
	int idx = static_cast<int>(params[1]);

	edict_t *e = TypeConversion.id_to_edict(idx);

	if (FNullEnt(e))
		return 0;

	if (e->pvPrivateData)
		return 2;

	return 1;
}

int is_ent_valid(int iEnt)
{
	if (iEnt < 1 || iEnt > gpGlobals->maxEntities) 
		return 0;

	if (iEnt <= gpGlobals->maxClients)
	{
		if (!MF_IsPlayerIngame(iEnt))
		{
			return 0;
		}
	} else {
		if (FNullEnt(TypeConversion.id_to_edict(iEnt)))
		{
			return 0;
		}
	}

	return 1;
}

So no, one is not better than the other, use whatever you want to.

[Natsheh]

It seems I've read the source of something similar to is_ent_valid, i remember it was one line code.

[amirwolf]

I have an error again

L 01/27/2022 - 18:59:03: Start of error session.
L 01/27/2022 - 18:59:03: Info (map "bb_cg_aztec_b6") (file "addons/amxmodx/logs/error_20220127.log")
L 01/27/2022 - 18:59:03: [FAKEMETA] Invalid entity
L 01/27/2022 - 18:59:03: [AMXX] Displaying debug trace (plugin "basebuilder65.amxx")
L 01/27/2022 - 18:59:03: [AMXX] Run time error 10: native error (native "set_pev")
L 01/27/2022 - 18:59:03: [AMXX]    [0] basebuilder65.sma::ham_PlayerSpawn_Post (line 1516)
L 01/27/2022 - 18:59:04: [ENGINE] Invalid entity 65
L 01/27/2022 - 18:59:04: [AMXX] Displaying debug trace (plugin "basebuilder65.amxx")
L 01/27/2022 - 18:59:04: [AMXX] Run time error 10: native error (native "entity_get_int")
L 01/27/2022 - 18:59:04: [AMXX]    [0] basebuilder65.sma::cmdStopEnt (line 2373)
L 01/27/2022 - 18:59:04: [AMXX]    [1] basebuilder65.sma::fw_CmdStart (line 2247)
L 01/27/2022 - 18:59:50: [ENGINE] Invalid entity 65
L 01/27/2022 - 18:59:50: [AMXX] Displaying debug trace (plugin "basebuilder65.amxx")
L 01/27/2022 - 18:59:50: [AMXX] Run time error 10: native error (native "entity_get_int")
L 01/27/2022 - 18:59:50: [AMXX]    [0] basebuilder65.sma::cmdStopEnt (line 2373)
L 01/27/2022 - 19:00:01: [ENGINE] Invalid entity 65
L 01/27/2022 - 19:00:01: [AMXX] Displaying debug trace (plugin "basebuilder65.amxx")
L 01/27/2022 - 19:00:01: [AMXX] Run time error 10: native error (native "entity_get_int")
L 01/27/2022 - 19:00:01: [AMXX]    [0] basebuilder65.sma::cmdStopEnt (line 2373)

[DJEarthQuake]

Share the code please.