Loop And Menu

Awesome_man · **Author**

What's wrong with this code i'm trying to loop through all alive terrorist player and add them on menu then adding gOn[tempid] = true; on that particular terrorist selected in menu

PHP Code:


			
public hu()
{
    
    new menu = menu_create("Menu","h_handler");
    new name[32],text[32]
    
    new Players[32]  
    new playerCount, i, szTempid,player  
    get_players(Players, playerCount, "che","TERRORIST" )  
    for (i=0; i<playerCount; i++) 
    { 
        player = Players[i]  
    

        get_user_name(player, name, 31) 
    num_to_str( player, szTempid, 9 )  

        format(text, 31, "%s - %s", name) 
        menu_additem( menu, name, szTempid, 0 );
    }; 

 
    menu_display(hu, menu, 0)     
    return PLUGIN_HANDLED;
}   
   
public h_handler(id,menu,item)
{
if( item == MENU_EXIT )
    {
        menu_destroy( menu );
        return PLUGIN_HANDLED;
    }
    new data[ 6 ], iName[ 64 ];
    new access, callback;
    menu_item_getinfo( menu, item, access, data,5, iName, 63, callback );

    new tempid = str_to_num( data );
    if( !is_user_bot( tempid ) )
        gOn[tempid] = true;
    
    menu_destroy( menu );
    return PLUGIN_HANDLED;
}

Ghosted · 12-29-2018 , 12:32 Re: Loop And Menu

1. You've passed only one argument in string formation.

Code:

 format(text, 31, "%s - %s", name)

2. You have 'c' flag in get_players which means you wont get bots
so using is_user_bot is not required in handler, but you
should use is_user_connected cause before selecting an item
from menu (target) player may disconnect from the game

================
For efficiency do not convert player index to string and vice versa.
Use following style:

=> SET
new ItemInfo[2];
ItemInfo[0] = <PlayerIndex>;
menu_additem(...., ...., ItemInfo, ...)
=> GET
new ItemInfo[2];
menu_item_getinfo(..., ..., ..., ItemInfo, charsmax(ItemInfo), ....);
<PlayerIndex> = ItemInfo[0];

Awesome_man · 12-29-2018 , 23:14 Re: Loop And Menu

Quote:

Originally Posted by Ghosted

1. You've passed only one argument in string formation.

Code:

 format(text, 31, "%s - %s", name)

2. You have 'c' flag in get_players which means you wont get bots
so using is_user_bot is not required in handler, but you
should use is_user_connected cause before selecting an item
from menu (target) player may disconnect from the game

================
For efficiency do not convert player index to string and vice versa.
Use following style:

=> SET
new ItemInfo[2];
ItemInfo[0] = <PlayerIndex>;
menu_additem(...., ...., ItemInfo, ...)
=> GET
new ItemInfo[2];
menu_item_getinfo(..., ..., ..., ItemInfo, charsmax(ItemInfo), ....);
<PlayerIndex> = ItemInfo[0];

can you please show this in main code i'm very beginner in scripting and trying my best but it's somehow not working. Thank you

Ghosted · 12-30-2018 , 03:47 Re: Loop And Menu

Quote:

Originally Posted by Awesome_man

can you please show this in main code i'm very beginner in scripting and trying my best but it's somehow not working. Thank you

Code:

 format(text, 31, "%s - %s", name)

What do you want to show here, i see two '%s'-s in code so you want to show two strings? one is player name and another!?

Awesome_man · 12-30-2018 , 04:00 Re: Loop And Menu

Quote:

Originally Posted by Ghosted

Code:

 format(text, 31, "%s - %s", name)

What do you want to show here, i see two '%s'-s in code so you want to show two strings? one is player name and another!?

I want to apply gOn[tempid] = true; if i select a specific player and if i again select that player it should gOn[tempid] = false;

Ghosted · 12-30-2018 , 05:03 Re: Loop And Menu

Code:

#include <amxmodx>
#include <amxmisc>

new gOn[33];

public ShowMenu(Caller)
{
	new Menu = menu_create("Menu", "Handler_Menu");
	new Players[32], PlayerCount, Target, Name[32], Text[32 + 2], ItemInfo[2];
	get_players(Players, PlayerCount, "che", "TERRORIST")  ;
	
	for (new Index = 0; Index < PlayerCount; Index++)
	{
		Target = Players[Index];
		ItemInfo[0] = Target;
		get_user_name(Target, Name, charsmax(Name));
		formatex(Text, charsmax(Text), "%s%s", gOn[Target] ? "\r" : "\y", Name);
		menu_additem(Menu, Text, ItemInfo);
	}
	
	menu_display(Caller, Menu);
}

public Handler_Menu(PlayerID, MenuID, ItemID)
{
	if (ItemID < 0)
		goto Ignore;
	
	new ItemInfo[2];
	menu_item_getinfo(MenuID, ItemID, _, ItemInfo, charsmax(ItemInfo));
	new Target = ItemInfo[0];
	
	if (!is_user_connected(Target))
		goto Ignore;
	
	gOn[Target] = !gOn[Target];
	
Ignore:
	menu_destroy(MenuID);
}

Not Tested But Compilable (1.8.3+)

RED Name = gOn = true
YELLOW Name = gOn = false

Awesome_man · 12-30-2018 , 07:05 Re: Loop And Menu

Quote:

Originally Posted by Ghosted

Code:

#include <amxmodx>
#include <amxmisc>

new gOn[33];

public ShowMenu(Caller)
{
	new Menu = menu_create("Menu", "Handler_Menu");
	new Players[32], PlayerCount, Target, Name[32], Text[32 + 2], ItemInfo[2];
	get_players(Players, PlayerCount, "che", "TERRORIST")  ;
	
	for (new Index = 0; Index < PlayerCount; Index++)
	{
		Target = Players[Index];
		ItemInfo[0] = Target;
		get_user_name(Target, Name, charsmax(Name));
		formatex(Text, charsmax(Text), "%s%s", gOn[Target] ? "\r" : "\y", Name);
		menu_additem(Menu, Text, ItemInfo);
	}
	
	menu_display(Caller, Menu);
}

public Handler_Menu(PlayerID, MenuID, ItemID)
{
	if (ItemID < 0)
		goto Ignore;
	
	new ItemInfo[2];
	menu_item_getinfo(MenuID, ItemID, _, ItemInfo, charsmax(ItemInfo));
	new Target = ItemInfo[0];
	
	if (!is_user_connected(Target))
		goto Ignore;
	
	gOn[Target] = !gOn[Target];
	
Ignore:
	menu_destroy(MenuID);
}

Not Tested But Compilable (1.8.3+)

RED Name = gOn = true
YELLOW Name = gOn = false

PHP Code:


			
public ShowMenu(Caller)

{

    new Menu = menu_create("Menu", "Handler_Menu");

    new Players[32], PlayerCount, Target, Name[32], Text[32 + 2], ItemInfo[2];

    get_players(Players, PlayerCount, "che", "TERRORIST")  ;

    

    for (new Index = 0; Index < PlayerCount; Index++)

    {

        Target = Players[Index];

        ItemInfo[0] = Target;

        get_user_name(Target, Name, charsmax(Name));

        formatex(Text, charsmax(Text), "%s%s", gOn[Target] ? "\r" : "\y", Name);

        menu_additem(Menu, Text, ItemInfo);

    }

    

    menu_display(Caller, Menu);

}





public Handler_Menu(PlayerID, MenuID, ItemID)

{

    if (ItemID < 0)

        goto Ignore;

    

    new ItemInfo[2];

    menu_item_getinfo(MenuID, ItemID, _, ItemInfo, charsmax(ItemInfo));

    new Target = ItemInfo[0];

    

    if (!is_user_connected(Target))

        goto Ignore;

    

    gOn[Target] = !gOn[Target];

    

Ignore:

    menu_destroy(MenuID);

}

2 compile error