[Blowst]

I got a warning while compile a script, but idk y the compiler did.

test.sp(229) : warning 226: a variable is assigned to itself (symbol "startrdm")

definition of startrdm:

PHP Code:

bool startrdm[3] = false; 


and the line 229:

PHP Code:

startrdm[0] = !startrdm[0]; 


when i edit this like below, the compiler does own work without any warning.

PHP Code:

bool startrdm = false;
startrdm = !startrdm; 


Did I anything wrong?


EDIT1: the version of compiler is 1.7.3-dev+5209

[Spirit_12]

Originally Posted by Blowst PHP Code: startrdm[0] = !startrdm[0];

This can't be right. You are assigning the value of startrdm to startrdm.

Post the full code for the plugin.

[Blowst]

Originally Posted by Spirit_12 This can't be right. You are assigning the value of startrdm to startrdm. Post the full code for the plugin.

It means 'Invert a boolean' via assigning the inverted value of itself.

and the compiler warn this method when the boolean is in an array.

it don't warn when the variable is single boolean.

PHP Code:

#include <sourcemod>
#include <sdktools>

bool startrdm[3] = false;
bool startrd[3] = false;
bool testbool = false;

public void OnPluginStart()
{
    RegConsoleCmd("sm_atest2", AngleTest2);

    testbool = !testbool;
    PrintToServer("testbool = !testbool\ntestbool: %s", testbool ? "True":"False");
}

public Action AngleTest2(int client, int args)
{    
    Menu menu = new Menu(selection2);
    menu.SetTitle("Angles Test Menu2");
    
    if(!startrdm[0])
            menu.AddItem("", "Start [0]");
    else    menu.AddItem("", "End [0]");
    
    if(!startrd[0])
            menu.AddItem("", "[0]++");
    else    menu.AddItem("", "[0]--");
    
    if(!startrdm[1])
            menu.AddItem("", "Start [1]");
    else    menu.AddItem("", "End [1]");
    
    if(!startrd[1])
            menu.AddItem("", "[1]++");
    else    menu.AddItem("", "[1]--");
    
    if(!startrdm[2])
            menu.AddItem("", "Start [2]");
    else    menu.AddItem("", "End [2]");
    
    if(!startrd[2])
            menu.AddItem("", "[2]++");
    else    menu.AddItem("", "[2]--");
    
    menu.Display(client, MENU_TIME_FOREVER);
}

public int selection2(Menu menu, MenuAction action, int client, int item)
{
    if(action == MenuAction_Select)
    {
        if(item == 0)
        {
            startrdm[0] = !startrdm[0];
        }
        else if(item == 1)
        {
            startrd[0] = !startrd[0];
        }
        else if(item == 2)
        {
            startrdm[1] = !startrdm[1];
        }
        else if(item == 3)
        {
            startrd[1] = !startrd[1];
        }
        else if(item == 4)
        {
            startrdm[2] = !startrdm[2];
        }
        else if(item == 5)
        {
            startrd[2] = !startrd[2];
        }
            
        AngleTest2(client, 0);
    }
    else if(action == MenuAction_End)
    {
        delete menu;
    }
} 


[ddhoward]

Originally Posted by Spirit_12 You are assigning the value of startrdm to startrdm.

Incorrect. Please note the exclamation mark in front of the variable name on the right side of the = sign.

[Impact123]

I just tried this with the old 1.5.4 compiler to see if this was introduced with the new syntax update. It wasn't, it issues the same error. Still, this should work and looks like a bug to me.

Tip for op

PHP Code:

bool startrdm[3] = false; 


This is not needed because variables are initialized to zero/false by default. It also only sets the first index.

If you want to set the whole array you have to use something like this.

PHP Code:

bool startrdm[3] = {false, ...}; 


[Blowst]

Originally Posted by Impact123 Tip for op PHP Code: bool startrdm[3] = false;  This is not needed because variables are initialized to zero/false by default. It also only sets the first index. If you want to set the whole array you have to use something like this. PHP Code: bool startrdm[3] = {false, ...};

yes, right. i did it just for tests

but question, it still initialize by default? not keep a garbage value?

'decl' is not used in SM1.7+ syntax :S

[RedSword]

Yes, by default anything declared will have its default value (for instance an array of char will be zero'ed (0='\0'). There are no 1.7 way to quickly declare without initializing.

Red