[little_froy]

L 07/01/2021 - 19:25:07: [SM] [0] IsFakeClient
L 07/01/2021 - 19:25:07: [SM] [1] Line 52, D:\L4D2PROJECTS\A-Plugins Important 20210630\A-Important - 重要插件\avoid_re - OK\avoid_2.1.sp::OnPlayerRunCmd
L 07/01/2021 - 19:25:07: [SM] Exception reported: Client 2 is not connected
L 07/01/2021 - 19:25:07: [SM] Blaming: break_chi1.1.smx
L 07/01/2021 - 19:25:07: [SM] Call stack trace:
L 07/01/2021 - 19:25:07: [SM] [0] IsFakeClient
L 07/01/2021 - 19:25:07: [SM] [1] Line 146, D:\L4D2PROJECTS\A- NEW- Important - 重要插件 20210629\A- NEW- Important - 重要插件\break_chi - OK\break_chi1.1.sp::OnPlayerRunCmd
L 07/01/2021 - 19:25:07: [SM] Exception reported: Client 1 is not connected
L 07/01/2021 - 19:25:07: [SM] Blaming: avoid_2.1.smx

is there any better imrove, or just add IsClientConnected() before IsFakeClient()?....

[Marttt]

Should always check IsClientInGame* first

[Dragokas]

IsClientConnected() check is not enough.
You should check for IsClientInGame() before doing IsFakeClient().
IsClientInGame is already includes IsClientConnected() check.

[little_froy]

Originally Posted by Dragokas IsClientConnected() check is not enough. You should check for IsClientInGame() before doing IsFakeClient(). IsClientInGame is already includes IsClientConnected() check.

but the API https://sm.alliedmods.net/new-api/cl...IsClientInGame not have to be connected

Returns if a certain player has entered the game.

bool IsClientInGame(int client)
Parameters
int client
Player index (index does not have to be connected).

[Silvers]

Meaning they don't have to be connected to check, it will return false and no error. Use IsClientInGame instead of IsClientConnected unless you have to check if someone is connected but not in-game.

[Ilusion9]

PHP Code:


static cell_t sm_IsClientFakeClient(IPluginContext *pCtx, const cell_t *params)
{
    int index = params[1];
    if ((index < 1) || (index > playerhelpers->GetMaxClients()))
    {
        return pCtx->ThrowNativeError("Client index %d is invalid", index);
    }

    IGamePlayer *pPlayer = playerhelpers->GetGamePlayer(index);
    if (!pPlayer->IsConnected())
    {
        return pCtx->ThrowNativeError("Client %d is not connected", index);
    }

    return (pPlayer->IsFakeClient()) ? 1 : 0;
} 


You should check first if client index is valid (if necessary) and if its connected or in game.