[Alucard^]

Would be good a tutorial or an example about that Jon said.

[Exolent[jNr]]

#include < amxmodx >
#include < engine >
#include < fakemeta >

new const info_map_parameters[ ] = "info_map_parameters";

new g_hSpawn;

public plugin_precache( ) {
    new iEntity = create_entity( info_map_parameters );
    DispatchKeyValue( iEntity, "buying", "3" );
    DispatchSpawn( iEntity );
    
    g_hSpawn = register_forward( FM_Spawn, "FwdSpawn" );
}

public FwdSpawn( iEntity ) {
    static szClassname[ 32 ];
    entity_get_string( iEntity, EV_SZ_classname, szClassname, 31 );
    
    if( equal( szClassname, info_map_parameters ) ) {
        remove_entity( iEntity );
        
        return FMRES_SUPERCEDE;
    }
    
    return FMRES_IGNORED;
}

public plugin_init( ) {
    if( g_hSpawn > 0 ) {
        unregister_forward( FM_Spawn, g_hSpawn );
    }
}

[Hawk552]

Originally Posted by Exolent[jNr] PHP Code:     if( TrieKeyExists( g_tBuyCommands, szArg )     && ( 1 << ( _:cs_get_user_team( client ) ) & ( ( 1 << 1 ) | ( 1 << 2 ) ) )

This is bad practice. You should use detagged CS_TEAM_T and CS_TEAM_CT constants, like this:

PHP Code:

    if( TrieKeyExists( g_tBuyCommands, szArg )
    && ( 1 << ( _:cs_get_user_team( client ) ) & ( ( 1 << _:CS_TEAM_T ) | ( 1 << _:CS_TEAM_CT ) ) ) 


[Exolent[jNr]]

Other than readability, what is the purpose?

[Hawk552]

Originally Posted by Exolent[jNr] Other than readability, what is the purpose?

What if the constant changes? Of course, it never will in this case, but what if you're working with some kind of volatile API? As you said, there's also the readability issue.

[stupok]

Exolent, can you say a few words about your code in #12? Did you test it? What does it do? Why 3? etc.

Thanks

[Exolent[jNr]]

It has been tested.
"buying" is the key for what teams can buy.
The value is the bitsum for the teams that are allowed to buy.
0 - Everyone can buy
1 - Terrorists can't buy
2 - Counter-Terrorists can't buy
3 - No one can buy

[Arkshine]

Originally Posted by stupok Exolent, can you say a few words about your code in #12? Did you test it? What does it do? Why 3? etc. Thanks

info_map_parameters is an entity which allows you to change the radius of the bomb target and which team is allowed to buy. You will get message like "Terrorists are not allowed to buy on this map" or something like.

The Exolent[jNr]'s code create an info_map_parameter entity which define which team is allowed to buy, then he deletes the original entity, if it exists. It's more simple to do that instead of checking/altering a value of a specific key.

Here Ham_Spawn should be used, but since RegisterHam() is buggy, you have to use FM_Spawn. Otherwise it will do the same as RegisterHamFromEntity() where it will spawn all the entities of the same internal class. But I'm wondering if this entity shares the same internal class with others entities. It sounds line an unique entity, something worth to check so you could use Ham_Spawn safely here.

About the value for the team ; you can find the description for these keys in the Counter-Strike game definition file (.fgd). I attach here.

[SnoW]

Originally Posted by Arkshine Here Ham_Spawn should be used, but since RegisterHam() is buggy

Explain. I'vent found anything buggy in RegisterHam. Sure it hooks the virtual table and some entities can have same virtual table and different in-game classname, but where's a bug? It's how it works, and works just fine if we know the facts.

[Arkshine]

No, RegisterHam() should hook only by the the classname provided. RegisterHamFromEntity() hooks by internal class. I don't see the purpose for both to hook by internal class. (why both natives so?) If not a bug RegisterHam() (I don't see in the .inc a note like : "This will cause hooks for the entire internal class" why?) should still hook only the classname we provide. It makes more senses to use it in this way. In many situations that's not possible to use Ham_Spawn when it's more efficient to use it. Using FM_Spawn called for all entities + using a native each time as replacement is just idiot. So, yes for me it's a "bug".