[Peter Brev]

This plugin adds some missing sounds that would be present in the regular Half-Life 2 games, but not in HL2DM.

Sounds that are added back in are:

• weapons/crossbow/bolt_load1.wav ( when attaching the bolt to the crossbow during reload )
• weapons/crossbow/bolt_load2.wav ( when attaching the bolt to the crossbow during reload )
• weapons/physcannon/physcannon_claws_close.wav
• weapons/physcannon/physcannon_claws_open.wav
• weapons/physcannon/physcannon_tooheavy.wav
• weapons/physcannon/physcannon_pickup.wav
• weapons/physcannon/physcannon_drop.wav
• weapons/physcannon/hold_loop.wav ( does not seem to be working )
• weapons/slam/throw.wav ( underhand grenade throw while crouched )

Latest version: hl2mpsoundsfix_1_1

Updates
--------
Pushed an update (1.1.). This is a quality of life update and is recommended you update. Less resources will be used by the plugin.

• Code overhaul/optimization.
  • All sounds are now under one sound hook, which uses less resources.
  • Replaced StrContains by strcmp, which uses less resources.
  • Superfluous code has been removed.

[belgvr]

Nice!
I've been looking for this for a long time. Thanks!

One thing i noticed though, is that the other player's sounds play as if they were close to you, instead of their real position.

[Peter Brev]

I am not sure I understood. It is possible to hear other players' sounds if they are close to you, but they are originating from their position. I have not touched anything that has to do with sound position. Sounds are all emitted from the client as the function name suggests.

[Silvers]

- You don't need to check "IsClientConnected" if you're checking "IsClientInGame" since that already checks they're connected.

- I highly recommend consolidating all the sound hook callbacks into 1, right now this is very inefficient since you're checking all the strings when 1 of them could have triggered already.

- You should replace "StrContains" with "strcmp" or "strncmp". Right now you're checking every position of the string for a match, this is inefficient and resourceful especially for something triggered as often as the sound hooks.

- Don't understand why you're blocking commands in "OnPlayerRunCmd" for bots. This might affect other plugins expecting bots to have commands coming through.

- You're returning "Plugin_Changed" from the sound callbacks, but nothing is actually being changed.

- Lastly you don't need "public" for callbacks you named yourself. Just for plugin forwards (such as those from SM and 3rd party plugins).

[Peter Brev]

Thanks for the feedback.

Originally Posted by Silvers - You don't need to check "IsClientConnected" if you're checking "IsClientInGame" since that already checks they're connected.

I will keep this in mind for next time.

Originally Posted by Silvers - I highly recommend consolidating all the sound hook callbacks into 1, right now this is very inefficient since you're checking all the strings when 1 of them could have triggered already.

That is how I initially wrote the plugin, but ran into issues where sounds would double up in-game for no good reason and other weird artifacts that would not happen when separated. I will take another crack at it in the future.

Originally Posted by Silvers - You should replace "StrContains" with "strcmp" or "strncmp". Right now you're checking every position of the string for a match, this is inefficient and resourceful especially for something triggered as often as the sound hooks.

That is a good point. I essentially copy pasted from my footstep sounds plugin and did not think of making this kind of change. I will also keep it in mind.

Originally Posted by Silvers - Don't understand why you're blocking commands in "OnPlayerRunCmd" for bots. This might affect other plugins expecting bots to have commands coming through.

That would be an oversight. That is leftover code from a larger plugin I was working on, fixing a whole bunch of HL2DM issues. Ultimately, that larger plugin was replaced by custom C++ fixes instead, hence the smaller plugins released.

Originally Posted by Silvers - You're returning "Plugin_Changed" from the sound callbacks, but nothing is actually being changed.

I will make the necessary changes.

Originally Posted by Silvers - Lastly you don't need "public" for callbacks you named yourself. Just for plugin forwards (such as those from SM and 3rd party plugins).

Thanks for the tip!

Take care!

[Silvers]

Good stuff, nice to see HL2 getting some love. I should probably release the spawner plugin I made for HL2 games some 12 years ago but that's really bad code, and I haven't played since.

If you need any help or advice PM me.

[belgvr]

Suggestion:
It would be awesome if you could bring back the ricochet and bullet near miss sounds.

[hl2dmgamer]

nice

[Peter Brev]

Pushed an update (1.1.). This is a quality of life update and is recommended you update. Less resources will be used by the plugin.

• Code overhaul/optimization.
  • All sounds are now under one sound hook, which uses less resources.
  • Replaced StrContains by strcmp, which uses less resources.
  • Superfluous code has been removed.

The old version will be left online for a little while in case bugs in the new version are discovered.