[Spirit_12]

I'm getting tag mismatch warning when trying to compile.

PHP Code:

(561) : warning 213: tag mismatch 


This is line 561:

PHP Code:

hAdminMenu = topmenu; 


Here is the code function causing the warning.

PHP Code:


/* TopMenu Handle */
TopMenu hAdminMenu = null;

public void OnAdminMenuReady(Handle topmenu)
{
    if (topmenu == hAdminMenu)
    {
        return;
    }

    hAdminMenu = topmenu;
} 


I understand that Handle and TopMenu tags are the reason for this, but what would be a fix?

[Fyren]

You'll have to view_as<TopMenu>(topmenu).

[LenHard]

PHP Code:

public void OnAdminMenuReady(Handle hMenu)
{
    TopMenu hTopMenu = TopMenu.FromHandle(hMenu);

    if (hTopMenu != hAdminMenu)
    {
        hAdminMenu = hTopMenu;
        
        // Your code...
    }
} 


Try this

[Spirit_12]

Originally Posted by Fyren You'll have to view_as<TopMenu>(topmenu).

You mean like this? It solved the warning, but just for clarification.

PHP Code:

hAdminMenu = view_as<TopMenu>(topmenu); 


[Fyren]

Yes.

The difference between doing view_as and FromHandle that LenHard mentioned is the latter will cause a runtime error if the handle isn't actually a TopMenu.

[Powerlord]

Actually, there is one good question here:

Why has adminmenu.inc not been updated to use more specific handle types for its methods and forwards?

[Fyren]

Changing the signature of the forward would break existing code.

[Powerlord]

Originally Posted by Fyren Changing the signature of the forward would break existing code.

At the risk of sounding hostile, that sounds like something that should have been addressed when transitional syntax was added. Private forwards can bypass this using typesets, but global forwards are now forever stuck using just Handle.

Also, that doesn't address why things like AddTargetsToMenu still takes a Handle rather than a Menu.

[ThatKidWhoGames]

Originally Posted by Powerlord At the risk of sounding hostile, that sounds like something that should have been addressed when transitional syntax was added. Private forwards can bypass this using typesets, but global forwards are now forever stuck using just Handle. Also, that doesn't address why things like AddTargetsToMenu still takes a Handle rather than a Menu.

+1

[Fyren]

Transitional syntax is transitional because it does not attempt to solve all problems. It was meant to leave the majority of existing code as it was while providing some new conveniences. New warnings since 1.7 have generally only for things likely to be removed in a theoretical future version that majorly breaks compatibility, besides the new features.

AddTargetsToMenu would have been added to a methodmap, but it's implemented in the adminmenu plugin away from the rest of topmenu and an adminmenu methodmap doesn't seem particularly useful.