[RedSword]

AllowTroll is never reset to 0. You're taking for granted that the person will (be retarded enough to) always type the command.

Also, race condition is possible; use user ids within timers.

[htcarnage]

Fixed. AllowTroll is set to 0 on client disconnect, and userid's are passed within timers now.

[RedSword]

Originally Posted by htcarnage Fixed. AllowTroll is set to 0 on client disconnect, and userid's are passed within timers now.

GetClientOfUserId will return 0 if player isn't there. Then IsClientInGame will print an error in server console.

[htcarnage]

So essentially I have to check that client > 0 before proceeding with any other code?

[RedSword]

Originally Posted by htcarnage So essentially I have to check that client > 0 before proceeding with any other code?

Not necessary. But before IsClientInGame, yes. (And it is a good a practice)

EDIT : Seems ok; approved.

[hamilton5]

approved? who in in the ...
well, I would be curious to see anyway. It's to bad no;

CreateConVar("",PLUGIN_VERSION,"",FCVAR_PLUGI N|FCVAR_NOTIFY|FCVAR_SPONLY);

[RedSword]

Originally Posted by hamilton5 approved? who in in the ... well, I would be curious to see anyway. It's to bad no; CreateConVar("",PLUGIN_VERSION,"",FCVAR_PLUGI N|FCVAR_NOTIFY|FCVAR_SPONLY);

Putting a version convar is not needed... if he doesn't want to track his plugin, up to him.

And it is a command like many other; I think some admin would like to test the psychology of people they're going to kick/ban.


If you want to be approver go ahead and make a request; but I highly doubt you get it hamilton5, as you never did release any plugins of any sort.

"Approved" mainly means that a plugin doesn't do anything dangerous or that produces errors. It is not a "Wow this plugin is incredibly useful" nor a "honourable" mention...

Red

[friagram]

Its fun to troll trolls, but there are more efficient ways (happy, removing their damage, buffing all players but them, etc).

As far as approved plugins, there are tons of great plugins waiting on the sidelines, many have hundreds of users. Best not to worry about such things... Seems a lot lf the time it's just luck of the draw for what an approver happens to look at

[RedSword]

Originally Posted by friagram Its fun to troll trolls, but there are more efficient ways (happy, removing their damage, buffing all players but them, etc).

So if there is no toying around with the player itself the plugin should not be approved ? ...

Originally Posted by friagram Seems a lot lf the time it's just luck of the draw for what an approver happens to look at

We're not getting paid; we're few, this is purely voluntary and there is a lot of plugins to approve. We're aware of the fact that it takes time FYI. You could maybe help just so you know.

[friagram]

Originally Posted by RedSword So if there is no toying around with the player itself the plugin should not be approved ? ...

I did not say that... I was just commenting

Originally Posted by RedSword We're aware of the fact that it takes time FYI. You could maybe help just so you know.

I know, but I only have 1 referral :/