[Mecha the Slag]

Yeah light_dynamics are 'cheap' entities, meaning they require little resources but can be inaccurate. They shouldn't kill fps at all unless you have a terrible setup.

Also Leonardo: That's amazing work. I kinda wanted to add that to the main plugin but I wanted to finish the light effect first. Been toying around with a fade in / out effect.

[Leonardo]

Originally Posted by Mecha the Slag ... Also Leonardo: That's amazing work. ...

no, that's easy work with amazing result
ps: don't forget about known bugs.

[naris]

Originally Posted by FaTony Well my fps dropped from 200 to 40

200 fps is pointless. Most displays, especially LCDs, are incapable of displaying more then 60fps.

[naris]

Originally Posted by Leonardo Nothing to say.

I noticed an error in the logs that repeats fairly often:

L 12/10/2010 - 00:28:08: [SM] Native "GetEntPropEnt" reported: Property "m_hOwnerEntity" not found (entity 34/env_lightglow)
L 12/10/2010 - 00:28:08: [SM] Displaying call stack trace for plugin "other/TF2_Flare_Light.smx":
L 12/10/2010 - 00:28:08: [SM]   [0]  Line 66, TF2_Flare_Light.sp::Timer_EntitySpawned()

So, I change both the TF2_Flare_Light and TF2_Ignite_Lite plugins to uses references to save and track entities. I also added a check of the entity limits to improve stability when the amount of free entities drops too low.

[Leonardo]

fixed in all three my plugins.

[naris]

Originally Posted by Leonardo how many amazing things we can do now

There really is no need to check if the plugin has created any entities in OnPluginStart() sicne it has not had the opportunity to do so yet, so this code is not needed:

PHP Code:

public OnPluginStart()
{
    for(new iEntity = (MaxClients+1); iEntity < MAX_ENTITIES; iEntity++)
        if(g_iArrow[iEntity] != -1)
        {
            new iLightEntity = g_iArrow[iEntity];
            if(IsLightEntity(iLightEntity))
                RemoveEdict(iLightEntity);
            g_iArrow[iEntity] = -1;
        }
} 


Same thing for OnMapStart(), which has the same code in TF2_Flare_Light.sp, but not in the newer plugins. It's also not really needed to check if the value is -1 before assigning it to -1, as it won't really improve performance, but that is a minor quibble.

[FaTony]

Originally Posted by naris 200 fps is pointless. Most displays, especially LCDs, are incapable of displaying more then 60fps.

And I'm running CRT at 85 Hz.

Also:

Dynamic lighting is calculated at runtime, which makes it expensive to render.

http://developer.valvesoftware.com/wiki/Lighting

[naris]

Originally Posted by FaTony And I'm running CRT at 85 Hz.

200 fps is still pointless, as is anything over 85 fps, for your setup...

[naris]

Originally Posted by Leonardo fixed in all three my plugins.

Actually, you need to to call EntIndexToEntRef() to get the reference to fix the problem. Your updated plugins still have this error:

L 12/10/2010 - 04:03:43: [SM] Native "GetEntPropEnt" reported: Property "m_hOwnerEntity" not found (entity 34/env_lightglow)
L 12/10/2010 - 04:03:43: [SM] Displaying call stack trace for plugin "other/TF2_Flare_Light.smx":
L 12/10/2010 - 04:03:43: [SM]   [0]  Line 66, TF2_Flare_Light.sp::Timer_EntitySpawned()

So This:

PHP Code:

public OnEntityCreated(iEntity, const String:sClassName[])
{
                CreateTimer(0.05, Timer_EntitySpawned, iEntity);
}

public Action:Timer_EntitySpawned(Handle:hTimer, any:iEntity)
{
    iEntity = EntRefToEntIndex(iEntity);
} 


Needs to be like This:

PHP Code:

public OnEntityCreated(iEntity, const String:sClassName[])
{
                CreateTimer(0.05, Timer_EntitySpawned, EntIndexToEntRef(iEntity));
} 


[Matheus28]

Originally Posted by naris 200 fps is still pointless, as is anything over 85 fps, for your setup...

Implying every player in the server has an excellent computer