[raydan]

#define amerknife           1
#define bar                 2
#define weapon_bazooka      3
#define c96                 4
#define colt                5
#define frag_us             6
#define frag_ger            7
#define garand              8
#define riflegren_us        9
#define k98                 10
#define riflegren_ger       11
#define k98_scoped          12
#define m1carbine           13
#define mg42                14
#define mp40                15
#define mp44                16
#define p38                 17
#define pschreck            18
#define spade               19
#define spring              20
#define thompson            21
new Float:gWeaponKnockBack[MAX_WEAPON];
gWeaponKnockBack[mg42] = 1.0; // and more
 
public Action:ev_player_hurt(Handle:event,const String:name[],bool:dontBroadcast)
{
GetEventString(event,"weapon",weapon,65);
PrintToServer("%f",gWeaponKnockBack[weapon]); // how to get it?
}

[lamdacore]

you have to fill an array with the weapon strings, too. Now you can string compare these with the weapon you will get from GetEventString().

decl String:gWeaponStr[MAX_WEAPON][32];
strcopy(gWeaponSt[mg42], 32, "mg42");

if (!strcmp(weapon, gWeaponSt[mg42], 32)
{
  PrintToServer("%f",gWeaponKnockBack[mg42]);
}

[raydan]

Originally Posted by lamdacore you have to fill an array with the weapon strings, too. Now you can string compare these with the weapon you will get from GetEventString(). decl String:gWeaponStr[MAX_WEAPON][32]; strcopy(gWeaponSt[mg42], 32, "mg42"); if (!strcmp(weapon, gWeaponSt[mg42], 32) { PrintToServer("%f",gWeaponKnockBack[mg42]); }

it need to use many "if" to compare

[PM]

Defines are eliminated at compile time.

I'd do something like this:
(this is basically lambdacore's idea with a loop)


Code:
new const gWeaponNames[MAX_WEAPON][] = { "", // 0 "amerknife", // 1 "bar", //2 "tesT" } getweaponid(const weapname[]) { new i; for (i = 0; i < MAX_WEAPON; ++i) { if (strcmp(weapname, gWeaponNames[i]) == 0) return i; } return -1; // not found }


You'd have to watch out for MAX_WEAPON to be one id higher than the highest used weapon id.

[pRED*]

Hmm... I wonder if Bail could make some 'trie' natives available for coding as that would be much more efficient in situations like this..

[PM]

You could use a simple hash algorithm, ie.

#define chars_per_cell (cellbits / 8)

compute_hash(const input[])
{
	new res = 0xFFFFFFFF;

	for (new i = 0; input[i]; ++i)
	{
		res ^= input[i] << ((i % chars_per_cell)*8));
		++i;
	}
	return res;
}

(i hope that this won't produce collisions for your data )

Then you could either pre-compute the hash table or compute them on plugin load:

new const gWeaponNames[MAX_WEAPON][] = { "", // 0
   "amerknife", // 1
   "bar", //2
   "something"
   ...
};

new gWeaponHashes[MAX_WEAPON];

// on plugin load:
for (new i = 0; i < MAX_WEAPON; ++i)
   gWeaponHashes[i] = compute_hash(gWeaponNames[i]);

// To retreive the index:
getweaponid(const weapname[])
{
   new hash = compute_hash(weapname);
   for (new i = 0; i < MAX_WEAPON; ++i)
   {
      if (gWeaponHashes[i] == hash)
         return i;
   }
   return -1;  // not found
}

Or something similar.

[raydan]

i am using keyvalue to do that,,b ut i don't know use keyvalue is fast or not
this is keyvalue file

"zm_weapon"
{
 "30cal" "0.5"  //weapon_30cal
 "amerknife" "1"  //weapon_amerknife
 "bar" "1"  //weapon_bar
 "bazooka" "5"  //weapon_bazooka
}

weapon_kv = CreateKeyValues("zm_weapon");
 FileToKeyValues(weapon_kv, "cfg/weapon.cfg");
 
stock Float:GetWeaponKnockBack(String:weapon[])
{
 return KvGetFloat(weapon_kv,weapon,1.0);
}

[pRED*]

Kv's are quite slow. You'd be better to parse it into an array when you load the kv.

[BAILOPAN]

KeyValues aren't bad for small configuration sets. But I agree that if you can extract configuration data into a faster structure, it will be better.

Supporting tries (fast string-based lookups) in SourceMod scripts wouldn't be too hard. Someone should file a feature request.