[Rirre]

For some reason show_motd() cuts the message at 48 characters in Sven Co-op 5.0+.
So I have been googling around for an alternative and found this AS (AngelScript) script functioning for this game.
I gave it a try to convert it and got stuck at the SubString() part. Don't know how to proceed from there though.
This is the original AS code:

void UTIL_ShowMOTD( edict_t@ client, string motd, int mlen, const string name )
{
    const string hostname = g_EngineFuncs.CVarGetString( "hostname" ); //g_pvHostname.GetString();

    if ( !hostname.IsEmpty() && hostname != name )
    {
        NetworkMessage msgname( MSG_ONE, NetworkMessages::ServerName, g_vecZero, client );
        msgname.WriteString( name );
        msgname.End();
    }

    string chunk;
    int a = 0;

    while ( mlen > a )
    {
        chunk = motd.SubString( a, a + MAX_MOTD_CHUNK > mlen ? mlen - a : MAX_MOTD_CHUNK );
        a += MAX_MOTD_CHUNK;

        NetworkMessage msgmotd( MSG_ONE, NetworkMessages::MOTD, g_vecZero, client );
        msgmotd.WriteByte( chunk.Length() == MAX_MOTD_CHUNK ? uint8( 0 ) : uint8( 1 ) ); // 0 means there is still more message to come
        msgmotd.WriteString( chunk );
        msgmotd.End();  
    }
    
    if ( !hostname.IsEmpty() && hostname != name )
    {
        NetworkMessage msghostname( MSG_ONE, NetworkMessages::ServerName, g_vecZero, client );
        msghostname.WriteString( hostname );
        msghostname.End();
    }
}

How far I have come with the conversion to AMXX:

stock UTIL_ShowMOTD(player, szMessage[], iLen, szHead[])
{
    new szServerName[MAX_NAME_LENGTH];
    get_cvar_string("hostname", szServerName, charsmax(szServerName));

    Util_ServerName(player, szHead);

    new chunk[MAX_MOTD_CHUNK];
    new a = 0;

    while( iLen > a )
    {
        copy(chunk, sizeof(chunk), szMessage);
        // The equivalent of SubString() here
        a += MAX_MOTD_CHUNK;

        message_begin(player ? MSG_ONE : MSG_ALL, get_user_msgid("MOTD"), _, player);
        write_byte(strlen(chunk) == MAX_MOTD_CHUNK ? 0 : 1);
        write_string(chunk);
        message_end();
    }

    Util_ServerName(player, szServerName);
}

[jimaway]

while( iLen > a )
    {
        a += copy(chunk, sizeof(chunk), szMessage[a]);
        message_begin(player ? MSG_ONE : MSG_ALL, get_user_msgid("MOTD"), _, player);
        write_byte(strlen(chunk) == MAX_MOTD_CHUNK ? 0 : 1);
        write_string(chunk);
        message_end();
    }

[Rirre]

Originally Posted by jimaway while( iLen > a )     {         a += copy(chunk, sizeof(chunk), szMessage[a]);         message_begin(player ? MSG_ONE : MSG_ALL, get_user_msgid("MOTD"), _, player);         write_byte(strlen(chunk) == MAX_MOTD_CHUNK ? 0 : 1);         write_string(chunk);         message_end();     }

Thanks, but this caused a infinite loop.

[Rirre]

Found the solution:

while( iLen > a )
{
    copy( chunk, a + MAX_MOTD_CHUNK > iLen ? iLen - a : MAX_MOTD_CHUNK, szMessage[a] );
    a += MAX_MOTD_CHUNK;

    message_begin(player ? MSG_ONE : MSG_ALL, get_user_msgid("MOTD"), _, player);
    write_byte(strlen(chunk) == MAX_MOTD_CHUNK ? 0 : 1);
    write_string(chunk);
    message_end();
}

[Bugsy]

Minor efficiency tweaks

PHP Code:

new iChunkSize;
new msgMOTD = get_user_msgid("MOTD");
    
while( iLen > a )
{
    iChunkSize = copy( chunk, a + MAX_MOTD_CHUNK > iLen ? iLen - a : MAX_MOTD_CHUNK, szMessage[a] );
    a += MAX_MOTD_CHUNK;
        
    message_begin(player ? MSG_ONE : MSG_ALL, msgMOTD, _, player);
    write_byte(iChunkSize == MAX_MOTD_CHUNK ? 0 : 1);
    write_string(chunk);
    message_end();
} 


[Rirre]

Originally Posted by Bugsy Minor efficiency tweaks PHP Code: new iChunkSize; new msgMOTD = get_user_msgid("MOTD");      while( iLen > a ) {     iChunkSize = copy( chunk, a + MAX_MOTD_CHUNK > iLen ? iLen - a : MAX_MOTD_CHUNK, szMessage[a] );     a += MAX_MOTD_CHUNK;              message_begin(player ? MSG_ONE : MSG_ALL, msgMOTD, _, player);     write_byte(iChunkSize == MAX_MOTD_CHUNK ? 0 : 1);     write_string(chunk);     message_end(); }

Thank you. Appreciate it.