[Natsheh]

Hello, dear modders, i would like some help with a rehlds bug when a player has a certain view and PVS/PAS are not heard/seen from the view point rather from the player position,

Can someone write me a code/snippet in C++ of fixed issue, much appreciation since i suck at coding C++/C#

[georgik57]

this should only happen if you use addtofullpack to set the player view origin
i get away with this by setting the real view origin of the camera in FM_UpdateClientData pre while using a single entity in my camera plugin. maybe it could help you.
https://forums.alliedmods.net/attach...8&d=1648490539

[Natsheh]

Originally Posted by georgik57 this should only happen if you use addtofullpack to set the player view origin i get away with this by setting the real view origin of the camera in FM_UpdateClientData pre while using a single entity in my camera plugin. maybe it could help you. https://forums.alliedmods.net/attach...8&d=1648490539

nvm i fixed it, and i submitted a fix to rehlds repo

The fix:

Spoiler

PHP Code:


qboolean SV_ValidClientMulticast(client_t *client, int soundLeaf, int to)
{
    if (Host_IsSinglePlayerGame() || client->proxy)
    {
        return TRUE;
    }

    int destination = to & ~(MSG_FL_ONE);
    if (destination == MSG_FL_BROADCAST)
    {
        return TRUE;
    }

    unsigned char* mask;
    if (destination == MSG_FL_PVS)
    {
        mask = CM_LeafPVS(soundLeaf);
    }
    else
    {
        if (destination == MSG_FL_PAS)
        {
            mask = CM_LeafPAS(soundLeaf);
        }
        else
        {
            Con_Printf("MULTICAST: Error %d!\n", to);
            return FALSE;
        }
    }

    if (!mask)
    {
        return TRUE;
    }

    const edict_t *viewent = client->pViewEntity;
    if (!viewent)
    {
        viewent = client->edict;
    }

    const vec3_t& origin_ref = viewent->v.origin;
    vec_t* vec_t_ptr = const_cast<vec_t*>(reinterpret_cast<const vec_t*>(&origin_ref));
    int bitNumber = SV_PointLeafnum(vec_t_ptr);

    if (mask[(bitNumber - 1) >> 3] & (1 << ((bitNumber - 1) & 7)))
    {
        return TRUE;
    }

    return FALSE;
}