[luki1412]

Originally Posted by arne1288 As in, ... CheckCommandAccess ?

Then why isnt an official sourcemod plugin using it?

[Wilczek]

Originally Posted by luki1412 Check out the attached plugin below, not made by me, but using this native and not working 100% of the time.

new String:CharAdminFlag[32];

public OnPluginStart()
{
    bri_charadminflag = CreateConVar("bri_charadminflag", "a", "Admin flag to use for immunity (only one).  Must be a in char format.");
}

public OnConfigsExecuted()
{
    GetConVarString(bri_charadminflag, CharAdminFlag, sizeof(CharAdminFlag));
}

public OnClientPostAdminCheck(client)
{
    if (IsValidAdmin(client, CharAdminFlag))
        IsPlayerAdmin[client] = true;
    else
        IsPlayerAdmin[client] = false;
}

stock bool:IsValidAdmin(client, const String:flags[])
{
    if (!IsClientConnected(client))
        return false;
    new ibFlags = ReadFlagString(flags);
    if ((GetUserFlagBits(client) & ibFlags) == ibFlags) {
        return true;
    }
    if (GetUserFlagBits(client) & ADMFLAG_ROOT) {
        return true;
    }
    return false;
}

Doesn't it return true only if a client has the only flag you are looking for ('a' in this case) or if he's a root?

---

Originally Posted by ddhoward There are better ways to check a player's permissions, with the most convenient for server owners being CheckCommandAccess.

Checking for a specific command isn't a case for reserved slots, and then a fall off to flags seems a little... going around?

[luki1412]

Originally Posted by Wilczek new String:CharAdminFlag[32]; public OnPluginStart() { bri_charadminflag = CreateConVar("bri_charadminflag", "a", "Admin flag to use for immunity (only one). Must be a in char format."); } public OnConfigsExecuted() { GetConVarString(bri_charadminflag, CharAdminFlag, sizeof(CharAdminFlag)); } public OnClientPostAdminCheck(client) { if (IsValidAdmin(client, CharAdminFlag)) IsPlayerAdmin[client] = true; else IsPlayerAdmin[client] = false; } stock bool:IsValidAdmin(client, const String:flags[]) { if (!IsClientConnected(client)) return false; new ibFlags = ReadFlagString(flags); if ((GetUserFlagBits(client) & ibFlags) == ibFlags) { return true; } if (GetUserFlagBits(client) & ADMFLAG_ROOT) { return true; } return false; } Doesn't it return true only if a client has the only flag you are looking for ('a' in this case) or if he's a root? --- Checking for a specific command isn't a case for reserved slots, and then a fall off to flags seems a little... going around?

Yes its supposed to return true, save it and then at the end of the round make the client immune to damage if the client has the flag, but it somehow fails to return true even if you have the flag.

[ddhoward]

Wilczek asked if the posted code would have IsValidAdmin return true if the client has ONLY the indicated flag. If the flag is "a" and a player has flags "abc", he is concerned that the function would return false. I don't think that that is the issue here, though.

[luki1412]

Originally Posted by ddhoward Wilczek asked if the posted code would have IsValidAdmin return true if the client has ONLY the indicated flag. If the flag is "a" and a player has flags "abc", he is concerned that the function would return false. I don't think that that is the issue here, though.

Oh, I misunderstood him then. Yeah I dont think thats the issue here, because it fails even if Im root.

[ddhoward]

Are you sure that this particular native is the point of failure? Perhaps pop some debug messages in there.

PHP Code:

stock bool:IsValidAdmin(client, const String:flags[])
{
    if (!IsClientConnected(client)) {
        PrintToChatAll("client not connected!");
        return false;
    }
    new ibFlags = ReadFlagString(flags);
    PrintToChatAll("checking for flags \"%s\", user has flag bits equaling %i", flags, GetUserFlagBits(client));
    if ((GetUserFlagBits(client) & ibFlags) == ibFlags) {
        PrintToChatAll("user has the right bits!");
        return true;
    }
    if (GetUserFlagBits(client) & ADMFLAG_ROOT) {
        PrintToChatAll("user is root!");
        return true;
    }
    PrintToChatAll("returning false");
    return false;
} 


[Powerlord]

Originally Posted by luki1412 Then why isnt an official sourcemod plugin using it?

Admin Help, Antiflood, Base Bans, Base Chat, and ReservedSlots all use it.

Plugins that just register admin commands won't because it's quicker to use RegAdminCmd which acts like RegConsoleCmd with a CheckCommandAccess block in it.

[luki1412]

Originally Posted by ddhoward Are you sure that this particular native is the point of failure? Perhaps pop some debug messages in there. PHP Code: stock bool:IsValidAdmin(client, const String:flags[]) {     if (!IsClientConnected(client)) {         PrintToChatAll("client not connected!");         return false;     }     new ibFlags = ReadFlagString(flags);     PrintToChatAll("checking for flags \"%s\", user has flag bits equaling %i", flags, GetUserFlagBits(client));     if ((GetUserFlagBits(client) & ibFlags) == ibFlags) {         PrintToChatAll("user has the right bits!");         return true;     }     if (GetUserFlagBits(client) & ADMFLAG_ROOT) {         PrintToChatAll("user is root!");         return true;     }     PrintToChatAll("returning false");     return false; }

This code is fine, but that doesn't really matter anymore. I have no idea what is causing it but since Im the only one that has this problem Im gonna try to find the solution myself.

[luki1412]

Originally Posted by Powerlord Admin Help, Antiflood, Base Bans, Base Chat, and ReservedSlots all use it. Plugins that just register admin commands won't because it's quicker to use RegAdminCmd which acts like RegConsoleCmd with a CheckCommandAccess block in it.

I wasnt talking about registering commands. Also, ReservedSlots uses GetUserFlagBits.

[Powerlord]

Originally Posted by luki1412 Also, ReservedSlots uses GetUserFlagBits.

Reserved Slots is also a core plugin that literally has its own dedicated admin flag ("a"). Likewise, the adminmenu plugin has its own dedicated admin flag ("b").

Any plugins that aren't part of the core won't have their own dedicated admin flags.