[Master53]

hum

RoundFloat

          Syntax: stock RoundFloat(Float:value) 

Usage:  value            Floating point value to round.Notes: Rounds a floating point number using the "round to nearest" algorithm.                           

Return: The value rounded to the nearest integer.

[Lord Canistra]

>if userdeaths is 0, your script will
Oh my, just noticed division by zero ftw!

iirc RoundToNearest will return rounded integer. I assume Touch needs to shorten number count past comma.
In this case, you can reduce it in this way:

PHP Code:

PrintToChatAll("%.2f", ratio); 


, where 2 is count of numbers past comma. In example given above, it would turn 2.000000 into 2.00 . Adjust this to your liking, also, you can use this formatting method in most print/format functions.

[dirka_dirka]

master53 as usual is way off. you dont want ratio to be an integer. use what lord canistra said to trim the decimals when viewing.

also..

PHP Code:

Float:ratio = ( (userdeaths == 0) ? 0.0 : FloatDiv( float(userkills), float(userdeaths) ) );
PrintToChatAll("ratio = %.1f", ratio);  // ratio = 2.0 


[Samantha]

new userkills = GetClientFrags(client);
new userdeaths = GetClientDeaths(client);
new ratio;
ratio = RoundToCeil(userkills / userdeaths);  

[FaTony]

Originally Posted by Lord Canistra Frags & deaths are integer, not float. Try PHP Code: ratio = (float)(userkills) / (float)(userdeaths)

What the hell? C-style casts in SourcePawn?

Also, all those guys trying to round float to integer, while ratio clearly should be float, suck at programming.

dirka_dirka is the best.

[Lord Canistra]

Is it wrong? Won't the code work?

[FaTony]

I have never seen (float)(...) in Pawn, only in C/C++. Pawn does "casts" using Float:... However, it is not needed here at all. The only correct would be float(...). Haven't tested (float)(...) at all.

[Predailien12]

Originally Posted by Touch Hello I need to calculate the ratio player. But there are problems with the script. If I did not kill anybody or himself is not dead, then the script in console an error. But if, as I had killed himself died a few times, then my ratio = 0.00000. PHP Code: new userkills = GetClientFrags(client); new userdeaths = GetClientDeaths(client); new Float:ratio; ratio = userkills / userdeaths;  Why is my ratio 0.0000? Thx!

Simple. as you know, in math the denominator can't be '0'

so the error shows up. (you should make special script for that case

just like)

PHP Code:

if(userdeahts == 0)
{
        ratio = xx (u can do something u want. I mean just substitute u want)
}
else if(userdeaths > 0)
{
        ratio = float(userkills)/float(userdeath) or FloatDiv(float(userkill)/float(userdealth))
} 


and if u want to divide float with float

It would be more better to use

/** * Divides the dividend by the divisor. * * @param dividend First value. * @param divisor Second value. * @return dividend/divisor. */ native Float:FloatDiv(Float:dividend, Float:divisor);

but if u want to round the float, just use

RoundToNearest(Float:value)

one more thing which is strange is that the ratio.

I think ratio should be under 100%.

I mean...

ratio = userkill / (userdeath+userkill)

[Death [GER]]

1. If you have more kills than Deaths, your Ratio will be over 100%

2.

PHP Code:

stock GetClientKillDeathRatio(Client)
{
    new Deaths = GetClientDeaths(Client);
    if(!Deaths) return 0.0;
        else return float(GetClientFrags(Client))/float(Deaths);
}

new Float:Ratio = GetClientKillDeathRatio(Client); 


Cant test this because I'm at work atm.. But should work

[Monkeys]

Your script won't work, Death.
if (!Death) will run when Death is not 0, meaning it returns 0.0 for everything but 0, and when it's 0, it'll try to divide by it. Not good.

Additionally, you're returning Floats where an Integer is expected. Change your expected return type.



And a good script has been posted ages ago by dirka_dirka.