[baneado]

Saving the entid on a global variable is really a baaaad idea.

The entid change on every round. If the var keeps the old entid value, you can crash the server by removing a different entity just because now, that value it's another entity not related to the parachute.

Think about that and use find_ent_by_owner.

It's unusual the crash, but it can happen.


I saw a lot of plugins codes like that way, so don't give me examples about other plugins, they're bad coded...

[Blizzard_87]

Originally Posted by baneado Saving the entid on a global variable is really a baaaad idea. The entid change on every round. If the var keeps the old entid value, you can crash the server by removing a different entity just because now, that value it's another entity not related to the parachute. Think about that and use find_ent_by_owner. It's unusual the crash, but it can happen. I saw a lot of plugins codes like that way, so don't give me examples about other plugins, they're bad coded...

Thanks for bringing this to my attention. I'll look into it when I get home tonight.

Update v0.0.7 - 26/04/2015 12:12 PM

- Removed g_iPara_Ent global variable, Replaced with find_ent_by_owner.

[wicho]

Sometimes the parachute is not active when i respawn and I dont have errors in logs..

[Blizzard_87]

Originally Posted by wicho Sometimes the parachute is not active when i respawn and I dont have errors in logs..

What do you mean "not active" when you respawn?

[Xalus]

Holy shit, please remove that 'find_ent_by_owner',

The check is done every 0.1 (I dunno), but alot, wich eats ur server alive lol..
There was no problem, resetting on spawn and so, was all fine.

[Blizzard_87]

Originally Posted by Xalus Holy shit, please remove that 'find_ent_by_owner', The check is done every 0.1 (I dunno), but alot, wich eats ur server alive lol.. There was no problem, resetting on spawn and so, was all fine.

Really. I didn't realise is was that bad.

Will reverse the change.

[baneado]

Originally Posted by Xalus Holy shit, please remove that 'find_ent_by_owner', The check is done every 0.1 (I dunno), but alot, wich eats ur server alive lol.. There was no problem, resetting on spawn and so, was all fine.

LOL for you. RemoveParachute function can crash the server at player Spawn, I'm sure.

I didn't see how he had changed the code, but I do it now myself (not tested yet)

[Blizzard_87]

Originally Posted by baneado LOL for you. RemoveParachute function can crash the server at player Spawn, I'm sure. I didn't see how he had changed the code, but I do it now myself (not tested yet)

Ive fixed RemoveParachute by resetting the variable back to 0 for the player.

as my code now resets the variable to 0 on spawning, i can not see how it would crash as players are unable to execute the parachute while on ground or touching a ladder. so there is no way a parachute entity can be created at spawn, and if player jumps then presses E it creates a new one thru giving a new entity number since when spawning it gets reset anyway.

Plus, i cant reproduce this crash you talk about. sorry.

[Xalus]

Originally Posted by baneado LOL for you. RemoveParachute function can crash the server at player Spawn, I'm sure. I didn't see how he had changed the code, but I do it now myself (not tested yet)

A pev_valid (and if wanted a classname check), would be way more efficient!

[baneado]

Originally Posted by Blizzard_87 Ive fixed RemoveParachute by resetting the variable back to 0 for the player. as my code now resets the variable to 0 on spawning, i can not see how it would crash as players are unable to execute the parachute while on ground or touching a ladder. so there is no way a parachute entity can be created at spawn, and if player jumps then presses E it creates a new one thru giving a new entity number since when spawning it gets reset anyway. Plus, i cant reproduce this crash you talk about. sorry.

No, you didn't fix it, you remove entity and then reset the var ._.

I said it's a unusual crash (once a three days-week ?), but anyways it can happen.

Originally Posted by Xalus A pev_valid (and if wanted a classname check), would be way more efficient!

pev_valid, yes, and you might remove an other entity too, but without crash I'm think.

classname, yes, but if the classname it isn't "parachute", the real parachute entity wouldn't be removed.

More efficient? What is the problem to use find_ent_by_owner two times?? I really don't understand to you.

Anyways I combine two codes to use find_ent_by_owner only one time. Not tested.