[DarthMan]

Hello. I'm trying to loop through all weapon slots to check if player has any weapon but if ti has no weapon, the plugin crashes with message Run time error 4: index out of bounds. Any ideas?

bool: HasAnyWeapon(iID)
{
    new bool: bHasWeapons, iWeapon;
    
    if(is_user_alive(iID))
    {
        for(new i = 0; i < MAX_WEAPON_SLOTS + 1; i++)
        {
            iWeapon = get_pdata_cbase(iID, m_rgpPlayerItems[i], XO_PLAYER);
            
            if(!pev_valid(iWeapon))
                continue;
            
            if(!bHasWeapons)
            {
                bHasWeapons = true;
                break;
            }
        }
    }
    
    return bHasWeapons;
}

[Bugsy]

Is the specific slot important? If no, just check if pev_weapons is not zero. You can add things to an exclude bitfield, such as knife or c4 that you do not care about.

[DarthMan]

Originally Posted by Bugsy Is the specific slot important? If no, just check if pev_weapons is not zero. You can add things to an exclude bitfield, such as knife or c4 that you do not care about.

Well, it somehow is because what if the player had no weapons, he picked a weapon but didn't change to it which means that his weapon still equals to 0? On CS it looks like when u pick a weapon it automatically switches to it but that's for example not the case on HL1 let's say if the auto switch game cvar is disabled.

[HamletEagle]

Show MAX_WEAPON_SLOTS's value.

[DarthMan]

Originally Posted by HamletEagle Show MAX_WEAPON_SLOTS's value.

It's 6.
Also, new const m_rgpPlayerItems[MAX_WEAPON_SLOTS] = { 343, 344, ... }; // for Half-Life : Opposing Force

[klippy]

i < MAX_WEAPON_SLOTS + 1

I believe you don't need that + 1.

[DarthMan]

Originally Posted by KliPPy i < MAX_WEAPON_SLOTS + 1 I believe you don't need that + 1.

That was it, many thanks ! I tought that I needed + 1 beucase there are slots from 1 to 7 so that the loop will end at 6. But I guess since slots are actually starting from 0 and slot1 is like 0 the - 1 wasn't needed. Was a bit confused due to how the binds were in the game.

[Bugsy]

pev_weapons does not contain the currently held weapon. It contains a bit-sum of the players inventory of weapons. Here's an example for getting inventory out of pev_weapons, ignoring knife and c4.

PHP Code:

#include <amxmodx>
#include <fakemeta>

const Ignore_Weapons = ( ( 1 << CSW_KNIFE ) | ( 1 << CSW_C4 ) );

public plugin_init() 
{
    register_clcmd( "say a" , "ShowPevWeapons" );
}

public ShowPevWeapons( id )
{
    new szWeapon[ 19 ] , iWeapons = ( pev( id , pev_weapons ) & ~Ignore_Weapons );
    
    for ( new i = CSW_P228 ; i <= CSW_P90 ; i++ )
    {
        if ( iWeapons & ( 1 << i ) )
        {
            get_weaponname( i , szWeapon , charsmax( szWeapon ) );
            client_print( id , print_chat , szWeapon );
        }
    }
} 


[DarthMan]

Originally Posted by Bugsy pev_weapons does not contain the currently held weapon. It contains a bit-sum of the players inventory of weapons. Here's an example for getting inventory out of pev_weapons, ignoring knife and c4. PHP Code: #include <amxmodx> #include <fakemeta> const Ignore_Weapons = ( ( 1 << CSW_KNIFE ) | ( 1 << CSW_C4 ) ); public plugin_init()  {     register_clcmd( "say a" , "ShowPevWeapons" ); } public ShowPevWeapons( id ) {     new szWeapon[ 19 ] , iWeapons = ( pev( id , pev_weapons ) & ~Ignore_Weapons );          for ( new i = CSW_P228 ; i <= CSW_P90 ; i++ )     {         if ( iWeapons & ( 1 << i ) )         {             get_weaponname( i , szWeapon , charsmax( szWeapon ) );             client_print( id , print_chat , szWeapon );         }     } }

Thanks, I think this could be useful for my CS server to ignore stripping the knife :-)