[luciaus18]

no, i tryed, this happen only when fireworks is activated

[zmd94]

Then, I'm sorry. I'm not sure what is the problem.

[luciaus18]

my bad !!

[Perfect Scrash]

Plugin Updated !! Made in day 01/08/2015

* Added ZP support
* Fixed Lang Messages
* Added Cvar amx_fireworks_message_enable

[matrix123]

translate spanish

"Fuegos del artificiales" not exist

"Fuegos Artificiales" fixed

sorry for my bad english

[zmd94]

Nice, Perfect Scrash.

Welcome again to AM. ;)

[Basakot]

Nice plugin, gonna test it ^^

EDIT: It would be nice to add and a firework sound

[HamletEagle]

PHP Code:

enum { TEAM_T = 1, TEAM_CT }
enum { TEAM_ZOMBIE = 1, TEAM_HUMAN }
#endif 


Do not reinvent the wheel, since you are using cstrike module use CS_TEAM_* definitions. Also the zp include already define WIN_*, you could work with them.

PHP Code:

for(new id = 1; id <= get_maxplayers(); id++) 


get_maxplayers should be cached, but at the end you should not loop like this. Use get_players, it give you only valid players and it's faster, though the speed difference is trivial.
You are using wrongly LANG_PLAYER, this should be used when you pass 0 as index. If you are actually using a player index, then use the player index there too.

Do not acces cvar values inside loops, cache them before. Caching means to save the value of a native, it worth when a native will be called more than one time.

PHP Code:

    if(get_pcvar_num(cvar_type) <= 0) set_task(AUTO_RELASE_INTERVAL, "auto_relase", id+TASK_AUTORELASE) 


Do not create 32 tasks(or how many players are), create only one task and parse players inside it.
You don't need to loop after all in zp_round_ended, just send the message with index 0(then keep LANG_PLAYER).

Same reasoning can be applied in t_win and ct_win, do not loop at all, send the message with index 0 and create only one task.

In autorelease:

PHP Code:

if(cs_get_user_team(id) == CS_TEAM_T && g_fireworks_team == TEAM_T || cs_get_user_team(id) == CS_TEAM_CT && g_fireworks_team == TEAM_CT) 


This can be shortened too cs_get_user_team(id) == g_fireworks_team.


fw_PlayerPreThink is not needed, to detect IN_USE sound you can hook pfnEmitSound and check against common/wpn_denyselect.wav sound.

Drop the public keyword in front of make_fireworks and fireworks_effect. public is for things that may be called from outside of the plugin(forwards, tasks, etc).

Checking

PHP Code:

if(!get_pcvar_num(cvar_enable))
        return; 


in make fireworks is reduntant, it's checked before you call the function.

In fireworks_effect static is not needed.

AMXX 1.8.3 already have a function for printing colored messages, so you could check amxx version and decide what to use. Also, your client_printcolor is poor:

• Do not hardcode strings size, use charsmax().
• is_user_connected is reduntant.
• get_user_msgid("SayText") should be cached.
• Do not reindex an array.

The most obvious mistakes which you could start.

[Perfect Scrash]

Plugin Updated 04/09/2015

* Removed Hard Codded
* Removed define ZP_SUPPORT because not needed for works in zombie plague
* Optimed code
* Now is not needed cstrike's module for plugin works
* Removed Unecessary loops
* get_maxplayers is now cached
* etc

[HamletEagle]

1.Instead of a define, AUTO_RELASE_INTERVAL should be a cvar. Maybe people want bigger or lower delay.
2.When printing the message check again if version is < 183. If so use client_printcolor, otherwise use http://www.amxmodx.org/api/amxmodx/client_print_color. So you will have full support for 1.8.3
3.Be consistent, in some places you put { under public x, in some at the same line.
4.Checking !get_pcvar_num(cvar_enable) in auto_relase it is not needed, you will reach there only if cvar_enable is 1.
5.I told you to do not loop like this for(new id = 1; id <= g_maxplayers; id++). Do instead:

PHP Code:

new Players[32], Num, id
get_players(Players, Num, "a")
for(new i; i < Num; i++)
{
     id = Players[i]
} 


Also, you could use flag "e" in get_players and get players only from the team that sould see the fireworks.
Like:

PHP Code:

switch(g_fireworks_team)
{
    case TEAM_T:
    {
        get_players(Players, Num, "ae", "TERRORIST")
    }
    case TEAM_CT:
    {
        get_players(Players, Num, "ae", "CT")
    }
} 


6.Remove PreThink and hook EmitSound to detect when IN_USE is used(as I told you before).

PHP Code:

register_forward(FM_EmitSound, "pfnEmitSound")
public pfnEmitSound(id, Channel, const Sound[]) 
{
    if(equal(Sound, "common/wpn_denyselect.wav") && (pev(id, pev_button) & IN_USE))
    {
        //IN_USE was pressed
    }
} 


7.In make_fireworks, remove the alive, enable and team checks, get_players already do this(see 5).
8.client_printcolor stock should be inside a check for amxx version num, not a big deal, if not used it won't be compiled, but for consistency you should do this.
9.Use charsmax() in vformat.
10.#if AMXX_VERSION_NUM < 183 should not be inside the stock, put it outside the stock, see 8.