[Terminator1337]

Hi there,

I'm having a little bit of trouble with timers. What I want to do is give a player a credit every 15 minutes, starting from when they join the server. What would be the best way to do this?

Thanks

[Darkness_]

PHP Code:

public OnClientPutInServer(client)
{
    CreateTimer((15.0 * 60.0), GiveCredit, client, TIMER_REPEAT);
}

public Action:GiveCredit(Handle:timer, any:client)
{
    //give them credits here
} 


[Powerlord]

More like:

PHP Code:

public OnClientPutInServer(client)
{
    CreateTimer((15.0 * 60.0), GiveCredit, GetClientUserId(client), TIMER_REPEAT);
}

public Action:GiveCredit(Handle:timer, any:userid)
{
    new client = GetClientOfUserId(userid);
    if (client == 0)
        return Plugin_Stop;

    //give them credits here
    return Plugin_Continue;
} 


[Starbish]

Originally Posted by Powerlord More like: PHP Code: public OnClientPutInServer(client) {     CreateTimer((15.0 * 60.0), GiveCredit, GetClientUserId(client), TIMER_REPEAT); } public Action:GiveCredit(Handle:timer, any:userid) {     new client = GetClientOfUserId(userid);     if (client == 0)         return Plugin_Stop;     //give them credits here     return Plugin_Continue; }

is there any difference between sending GetClientUserId() and get real index of client by using twice?

isn't it better to use GetClientOfUserId() or just putting 'client' var on OnClientPutInServer() ?

[ddhoward]

Originally Posted by Starbish is there any difference between sending GetClientUserId() and get real index of client by using twice? isn't it better to use GetClientOfUserId() or just putting 'client' var on OnClientPutInServer() ?

If the player disconnects, you need to ensure that the player who connects and takes his slot doesn't receive his "credit." Client indexes are reused, user ID's are not.

You shouldn't EVER pass a client index through a timer. It's just not a good idea. Always run it through GetClientUserId() first, pass that user ID through the timer, and then run the ID through GetClientOfUserId() in the timer callback.

[The1Speck]

Originally Posted by ddhoward You shouldn't EVER pass a client index through a timer. It's just not a good idea. Always run it through GetClientUserId() first, pass that user ID through the timer, and then run the ID through GetClientOfUserId() in the timer callback.

Time to change all my plugins..

[m_bNightstalker]

I would just create a repeating timer which does that for all player, and just check a var against time (where you saved the last time you gave credits to that client). then just reset that time on connect/disconnect.