[RateX]

^This explains why on fy_ maps, when you throw HE nade with weaponphys plugin(this plugin make nade blow stuffs away, including visible armoury_entity), the entities just refuse to respawn at where they originally were.
Thank you for spending time answering my question.
Keep up making great tuts.

[Aydeev]

Originally Posted by meTaLiCroSS PHP Code: new armouryEnt = -1 while((armouryEnt = find_ent_by_class(armouryEnt, "armoury_entity")) {     set_pdata_int(armouryEnt, m_iCount, 0, XO_CArmoury);     set_pev(armouryEnt, pev_effects, pev(armouryEnt, pev_effects) | EF_NODRAW); }

Thank you!

[PRoSToTeM@]

Originally Posted by HamletEagle An armoury_entity can hold more than one weapon.

weaponbox too.

Originally Posted by HamletEagle The stock above will return -1 on failure.

Maybe better to throw an error? Who will check returned value? (almost always no one checks them)

[HamletEagle]

Originally Posted by PRoSToTeM@ weaponbox too.

Kinda unrelated, this tutorial is about armoury_entity, why should I mention that weaponbox can have multiple weapons? It's mentioned in the proper place: https://forums.alliedmods.net/showthread.php?t=261464

Originally Posted by PRoSToTeM@ Maybe better to throw an error? Who will check returned value? (almost always no one checks them)

It's the coder job to properly check for return values. He gets burned once, then gets burned twice and finally he learns to look for the returned value.

[PRoSToTeM@]

Originally Posted by HamletEagle It's the coder job to properly check for return values. He gets burned once, then gets burned twice and finally he learns to look for the returned value.

Even pro coders from this forum forget to remove player task on client_disconnect, but it is a bit unrelated.
But IMO itemType check should throw an error, it's the coder job to use valid arguments (coder can validate args, but can't precontrol entity creation failure). Or return codes should be different, e.g entity creation failed is -1 and invalid itemType is -2, so you can differentiate them.

Originally Posted by HamletEagle Kinda unrelated, this tutorial is about armoury_entity, why should I mention that weaponbox can have multiple weapons? It's mentioned in the proper place: https://forums.alliedmods.net/showthread.php?t=261464

This is written in the same paragraph with the comparison vs. weaponbox, so it sounds like armoury_entity can have multiple weapons, but weaponbox can't.

[edon1337]

What exactly is the reason that some weapons such as Famas, Galil, Pistols etc.. can't be created as armoury_entity?

[HamletEagle]

Originally Posted by PRoSToTeM@ This is written in the same paragraph with the comparison vs. weaponbox, so it sounds like armoury_entity can have multiple weapons, but weaponbox can't.

It's not a comparison, the paragraph just states that dropped weapons are not armoury_entity, but weaponbox.
I could edit to make it more clear, but the original intent was not a comparison by any means.

Originally Posted by PRoSToTeM@ Even pro coders from this forum forget to remove player task on client_disconnect, but it is a bit unrelated. But IMO itemType check should throw an error, it's the coder job to use valid arguments (coder can validate args, but can't precontrol entity creation failure). Or return codes should be different, e.g entity creation failed is -1 and invalid itemType is -2, so you can differentiate them.

I feel like we are debating over nothing, the stock is not critical enough to bother. Also it's something I put together really fast to show how it can be done, people are free to create their own implementation.
The coder can't precontrol the creation of the entity, but he can check the returned value and only proceed if it succeeded. Not like you can do much if entity fails to create.
Moreover, anyone could add an error log into that stock if they need it.
If it bothers you that much, go and add an error log and I will edit my post.

Originally Posted by edon1337 What exactly is the reason that some weapons such as Famas, Galil, Pistols etc.. can't be created as armoury_entity?

Because cs is coded like that. https://github.com/s1lentq/ReGameDLL...pons.cpp#L2165