[micapat]

Well, the question is simple:

What're your method(s) to detect ALL the deaths of a player?

When I say all, it means:
> Killed by another player.
> Suicide (Using "kill" for example).
> Killed by the bomb.
> ...

-----
OnTakeDamage / HookEvent("player_death") doesn't seem to detect everything. However a combination of both of them should do the trick.

I'm currently hooking "CCSPlayer::Event_Killed" (Linux offset: 71) with Dhooks, which seems to detect everything (Disadvantage: the offset can change because of a Valve update - but it shouldn't be all day ).

I would like to know if you have other reliable method(s) with or without Dhooks, to see what's available .

[Neuro Toxin]

Whats wrong with a generic event hook?

https://wiki.alliedmods.net/Generic_...s#player_death

[micapat]

For CS:GO - https://wiki.alliedmods.net/Counter-...s#player_death

I tested it, it doesn't detect the players killed by a bomb (The callback isn't called).

PHP Code:

public void OnPluginStart()
{
    HookEvent("player_death", Event_PlayerDeath, EventHookMode_Post);
}

public void Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast)
{
    PrintToChatAll("Event_PlayerDeath (%d)", GetClientOfUserId(event.GetInt("userid")));
} 


[Starbish]

what about get a c4 entity id and treat it on OnTakeDamage

[Bacardi]

[css] player death C4 explosion
https://forums.alliedmods.net/showthread.php?t=179830

Old topic... and code look funny.

SDKHook is better way to do it as @Starbish mentioned

[micapat]

Indeed, SDKHook_OnTakeDamage is good to detect deaths by players / bomb. Its only issue is to detect a suicide ("kill", "explode", switch_team, ...).

[Bacardi]

Originally Posted by micapat Indeed, SDKHook_OnTakeDamage is good to detect deaths by players / bomb. Its only issue is to detect a suicide ("kill", "explode", switch_team, ...).

...you need check entity index, is attacker out of player indexs (entity > MaxClients)
Then you can look entity with GetEntityClassname is it planted_c4

[micapat]

lol yes I know, no issue here like I said in #6 to detect player deaths by another entity (player, bomb...) using SDKHook_TakeDamage. The issue is that it doesn't detect everything, aka death by the commands "kill", "explode", switch team (--> Suicide)...

[Bacardi]

Indeed.
You maybe can handle OnTakeDamagePost, then check is player alive.
If player is still alive, use RequestFrame to check again.

*...I'm going to quick look this later, will it work

[Bacardi]

*indeed not recognize suicide command....


Check this

Spoiler

PHP Code:

#include <sdkhooks>

public void OnPluginStart()
{
    for(int i = 1; i <= MaxClients; i++)
    {
        if(IsClientInGame(i)) OnClientPutInServer(i);
    }
}

public void OnClientPutInServer(int client)
{
    if(!IsClientSourceTV(client) && !IsClientReplay(client))
        SDKHookEx(client, SDKHook_OnTakeDamagePost, OnTakeDamagePost);
}

public void OnTakeDamagePost(int victim, int attacker, int inflictor, float damage, int damagetype)
{
    // Don't pass alive players
    if(IsPlayerAlive(victim)) return;






    if(attacker == 0)
    {
        // World
    }
    else if(victim == attacker)
    {
        // Suicide
    }
    else if(1 <= attacker <= MaxClients)
    {
        // Another player

        if(attacker != inflictor)
        {
            // Player projectile
        }
    }
    else if(attacker > MaxClients)
    {
        // Entity

        char buffer[30];
        if(GetEntityClassname(attacker, buffer, sizeof(buffer)) && StrEqual(buffer, "planted_c4", false))
        {
            PrintToServer("-bomb_exploded victim %N,  attacker %s, IsPlayerAlive %s", victim, buffer, IsPlayerAlive(victim) ? "true":"false");
        }



        if(attacker != inflictor)
        {
            // Entity projectile
        }
    }
}