[red_bull2oo6]

hi again xD i came this time with one question

is it bad for my plugin to use "this stock" like 3 times in a function ?

PHP Code:

MakeNameSafe( id )
{
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "#", "%23" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "?", "%3F" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, ":", "%3A" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, ";", "%3B" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "/", "%2F" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, ",", "%2C" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "$", "%24" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "@", "%40" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "+", "%2B" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "=", "%3D" );
    replace_all( g_szName[ id ], sizeof( g_szName[ ] ) -1, "®", "®" );
} 


what any method can i use.

[fysiks]

If you need to use your custom function 3 times inside the same function then you are likely doing something wrong unless you are doing it on three different players. You should show your whole code so we can give you the best advice.

[red_bull2oo6]

thanks, that helped.
and yes i use it on 3 different players.

[fysiks]

Originally Posted by red_bull2oo6 thanks, that helped. and yes i use it on 3 different players.

Well, now that I think of it, you are still doing something wrong based on the fact that the names are are being stored in global variable and you should only need to do it once for each player.

Can you show your code? Attach your plugin as an attachment.

[red_bull2oo6]

well i modified it and now it looks like this:

PHP Code:

/* Plugin generated by AMXX-Studio */

#include < amxmodx >
#include < amxmisc >

#define PLUGIN "GT Played Time"
#define VERSION "1.1.5"

new const g_szGameTracker[ ] = "http://www.gametracker.com/player";

new g_szServerIp[ 32 ];
new g_szCustomUrl[ 128 ];

public plugin_init( )
{
    //--|Credits to Laurr for his idea. ( https://forums.alliedmods.net/showthread.php?t=220727 ).
    register_plugin( PLUGIN, VERSION, "Askhanar" );
    
    register_clcmd( "say", "HookClCmdSayOrSayTeam" );
    register_clcmd( "say_team", "HookClCmdSayOrSayTeam" );
    
    register_clcmd( "gt_playedtime", "ClCmdPlayedTime" );
    //register_clcmd( "say /playedtime", "ClCmdSayPlayedTime" );
    
    get_user_ip( 0, g_szServerIp, sizeof ( g_szServerIp ) -1, 0 ); //--| Ii luam ip la sv cu tot cu port!
    // Add your code here...
}

public HookClCmdSayOrSayTeam( id )
{
    static szArgs[ 192 ], szCommand[ 192 ];
    read_args( szArgs, sizeof ( szArgs ) -1 );
    
    if( !szArgs[ 0 ] )
        return PLUGIN_CONTINUE;
    
    remove_quotes( szArgs );
    
    if( equal( szArgs,  "/playedtime", strlen(  "playetime" ) ) )
    {
        replace( szArgs, sizeof ( szArgs ) -1, "/", ""  );
        formatex( szCommand, sizeof ( szCommand ) -1, "gt_%s", szArgs );
        client_cmd( id, szCommand );
        return PLUGIN_HANDLED;
    }
    
    return PLUGIN_CONTINUE;
}

public ClCmdPlayedTime( id )  
{
    
    new szFirstArg[ 32 ];
        read_argv( 1, szFirstArg, sizeof ( szFirstArg ) -1 );

    if( equali( szFirstArg, "" ) ) 
        DisplayPlayedTime( id, id );
    
    else
    {
        
    
        new iPlayer = cmd_target( id, szFirstArg, 8 );
        if(!iPlayer || iPlayer == id )
            return PLUGIN_CONTINUE;
    
        DisplayPlayedTime( id, iPlayer );
    }
    
    return PLUGIN_CONTINUE;
}

public DisplayPlayedTime( id, iPlayer )
{
    new szName[ 32 ];
    get_user_name( iPlayer, szName, sizeof ( szName ) -1 );
    MakeNameSafe( szName, sizeof( szName ) -1 );
    
    formatex( g_szCustomUrl, sizeof ( g_szCustomUrl ) -1, "%s/%s/%s/",
        g_szGameTracker, szName, g_szServerIp );
        
    show_motd( id, g_szCustomUrl );
    
}

MakeNameSafe( szName[ ], iLen )
{
    replace_all( szName, iLen, "#", "%23" );
    replace_all( szName, iLen, "?", "%3F" );
    replace_all( szName, iLen, ":", "%3A" );
    replace_all( szName, iLen, ";", "%3B" );
    replace_all( szName, iLen, "/", "%2F" );
    replace_all( szName, iLen, ",", "%2C" );
    replace_all( szName, iLen, "$", "%24" );
    replace_all( szName, iLen, "@", "%40" );
    replace_all( szName, iLen, "+", "%2B" );
    replace_all( szName, iLen, "=", "%3D" );
    replace_all( szName, iLen, "®", "®" );
    
} 


[fysiks]

It will probably be much more efficient to use this.

Also, I didn't think a non-ascii character was allowed in URLs. Are you sure that actually works?

[red_bull2oo6]

yes i`m sure i tested it.

thanks again but i think i`ll stay to replace_all
i think its solved by now.

LE: @that encode method, i'll give it a try to see with my own eyes.

[fysiks]

Originally Posted by red_bull2oo6 yes i`m sure i tested it. thanks again but i think i`ll stay to replace_all i think its solved by now. LE: @that encode method, i'll give it a try to see with my own eyes.

There are no non-ascii characters in that URL. I was referring to you replacing the registered trade mark symbol by two non-ascii characters.

Also, your question implied you were asking about efficiency and hence why I suggested the encode URL function.