Raised This Month: $51 Target: $400
 12% 

[SNIP] Add a tag for your plugin.


Post New Thread Reply   
 
Thread Tools Display Modes
psychonic

BAFFLED
Join Date: May 2008
Old 09-07-2010 , 17:35   Re: [SNIP] Add a tag for your plugin.
Reply With Quote #11

Quote:
Originally Posted by pimpinjuice View Post
Sorry didn't mean it like that, I just meant that with the current include people should be aware that they should probably re-add the tag any time sv_tags is changed. Your code is great as you already know.
I've updated my attachment. Would you mind looking it over as I may have turned it into a convoluted mess, but with the intention of having it keep track of multiple tags fine, resilient to manual sv_tags changes. Still untested until later.
psychonic is offline
API
Veteran Member
Join Date: May 2006
Old 09-07-2010 , 18:13   Re: [SNIP] Add a tag for your plugin.
Reply With Quote #12

Absolutely, I'll take a look and update this post in a bit.
__________________
API is offline
Send a message via AIM to API
psychonic

BAFFLED
Join Date: May 2008
Old 09-08-2010 , 09:48   Re: [SNIP] Add a tag for your plugin.
Reply With Quote #13

Updated post one more time to fix an invalid handle error that could occur when trying to remove a custom tag before adding one (which shouldn't happen if used properly, but better safe than rte).

Also of note, it would be nice for plugins to remove any added custom tag in OnPluginEnd.

Edit, rather than double post:
I decided to remove my attachment after realizing that half of the games that support tags (l4d1/2, swarm) still have a limit of 63+/0 total characters (including tags the game itself puts on). If more than a few tags get added, they will start getting cut off. While this supposedly isn't an issue for matchmaking like it was in the past, it's still less than ideal to have to fight for very limited tag space. (the 127+\0 in ep2v was a bit more reasonable).

TL;DR
tag system sucks

Last edited by psychonic; 09-08-2010 at 11:44.
psychonic is offline
API
Veteran Member
Join Date: May 2006
Old 09-08-2010 , 16:12   Re: [SNIP] Add a tag for your plugin.
Reply With Quote #14

Hmm, anyone that plans on using this, wait until I get a chance to test it with multiple plugins. See if I can provoke an infinite loop.
__________________
API is offline
Send a message via AIM to API
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 23:19.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode