[Amine Belokda]

Nice Your Plugin

[happy_2012]

How about this code/update?

PHP Code:

/* ===========================================================================
    
    -------------------
    -*- Reset Score -*-
    -------------------
    
    (c) 2015 - Chilimax
    Website: http://8bits-gaming.com
    
=========================================================================== */

#include < amxmodx >
#include < fakemeta >

#define PLUGIN_NAME        "Reset Score"
#define PLUGIN_VERSION    "1.0"
#define PLUGIN_AUTHOR    "Chilimax"

const OFFSET_TEAMS = 114;
const OFFSET_DEATH = 444;
const OFFSET_LINUX = 5;

new const g_szClientCommands[][] =
{
    "say /rs", "say_team /rs",
    "say /resetscore", "say_team /resetscore",
    "say /restartscore", "say_team /restartscore"
}

public plugin_init()
{
    register_plugin(PLUGIN_NAME, PLUGIN_VERSION, PLUGIN_AUTHOR);
    
    register_cvar("reset_score_version", PLUGIN_VERSION, FCVAR_SERVER | FCVAR_SPONLY);
    set_cvar_string("reset_score_version", PLUGIN_VERSION);
    
    new Index, iMaxLoops = sizeof(g_szClientCommands);
    for(Index = 0; Index < iMaxLoops; Index++)
    {
        if( g_szClientCommands[Index][0] )
            register_clcmd(g_szClientCommands[Index], "ClientCommand_ResetScore");
    }
}

public ClientCommand_ResetScore(Index)
{
    if( !fm_get_user_frags(Index) && !fm_get_user_deaths(Index) )
    {
        client_print(Index, print_chat, "Your score is already reset");
        return PLUGIN_HANDLED;
    }
    
    fm_set_user_frags(Index, 0);
    fm_set_user_deaths(Index, 0);
    
    UpdateClientScore(Index, 0, 0);
    
    static szName[32];
    get_user_name(Index, szName, charsmax(szName));
    
    client_print(0, print_chat, "%s has just reset his/her score");
    
    return PLUGIN_HANDLED;
}

UpdateClientScore(Index, iFrags, iDeaths)
{
    message_begin(MSG_ALL, get_user_msgid("ScoreInfo"));
    write_byte(Index);
    write_short(iFrags);
    write_short(iDeaths);
    write_short(0);
    write_short(fm_get_user_team(Index));
    message_end();    
}

stock fm_get_user_frags(Index)
{
    return pev(Index, pev_frags);
}

stock fm_get_user_deaths(Index)
{
    return get_pdata_int(Index, OFFSET_DEATH, OFFSET_LINUX);
}

stock fm_get_user_team(Index)
{
    return get_pdata_int(Index, OFFSET_TEAMS, OFFSET_LINUX);
}

stock fm_set_user_frags(Index, iFrags)
{
    set_pev(Index, pev_frags, iFrags);
}

stock fm_set_user_deaths(Index, iDeaths)
{
    set_pdata_int(Index, OFFSET_DEATH, iDeaths, OFFSET_LINUX);
} 


[Arkshine]

That would be worth to be trashed right away, horrible in many ways. You have been told already to not not use any fm_ stocks which are slower than original function in modules.

[happy_2012]

Originally Posted by Arkshine That would be worth to be trashed right away, horrible in many ways. You have been told already to not not use any fm_ stocks which are slower than original function in modules.

Have a look at zp4.3 it has a lot of fakemeta_util stocks, and it is approved? Apparently it has its own forum?

[Arkshine]

It doesn't matter much what others plugins do, if you don't understand what you're doing/saying, you got a problem. Looks like you have the Fakemeta syndrome which happened to hit everyone not that far ago. This might help you to understand better: https://forums.alliedmods.net/showthread.php?t=88792.

[happy_2012]

I got it now
Thank you mate!

How about this one now?

PHP Code:

/* ===========================================================================
    
    -------------------
    -*- Reset Score -*-
    -------------------
    
    (c) 2015 - Chilimax
    Website: http://8bits-gaming.com
    
=========================================================================== */

#include < amxmodx >
#include < cstrike >
#include < fun >

#define PLUGIN_NAME        "Reset Score"
#define PLUGIN_VERSION    "1.0"
#define PLUGIN_AUTHOR    "Chilimax"

new const g_szClientCommands[][] =
{
    "say /rs", "say_team /rs",
    "say /resetscore", "say_team /resetscore",
    "say /restartscore", "say_team /restartscore"
}

public plugin_init()
{
    register_plugin(PLUGIN_NAME, PLUGIN_VERSION, PLUGIN_AUTHOR);
    
    register_cvar("reset_score_version", PLUGIN_VERSION, FCVAR_SERVER | FCVAR_SPONLY);
    set_cvar_string("reset_score_version", PLUGIN_VERSION);
    
    new Index, iMaxLoops = sizeof(g_szClientCommands);
    for(Index = 0; Index < iMaxLoops; Index++)
    {
        if( g_szClientCommands[Index][0] )
            register_clcmd(g_szClientCommands[Index], "ClientCommand_ResetScore");
    }
}

public ClientCommand_ResetScore(Index)
{
    if( !get_user_frags(Index) && !cs_get_user_deaths(Index) )
    {
        client_print(Index, print_chat, "Your score is already reset");
        return PLUGIN_HANDLED;
    }
    
    set_user_frags(Index, 0);
    cs_set_user_deaths(Index, 0);
    
    UpdateClientScore(Index, 0, 0);
    
    static szName[32];
    get_user_name(Index, szName, charsmax(szName));
    
    client_print(0, print_chat, "%s has just reset his/her score");
    
    return PLUGIN_HANDLED;
}

UpdateClientScore(Index, iFrags, iDeaths)
{
    message_begin(MSG_ALL, get_user_msgid("ScoreInfo"));
    write_byte(Index);
    write_short(iFrags);
    write_short(iDeaths);
    write_short(0);
    write_short(get_user_team(Index));
    message_end();    
} 


[HamletEagle]

There is still room for improvement, like caching get_user_msgid("ScoreInfo"), because it won't change. static is misused in the command, new is more appropiate.

Btw, when using offsets you should use their real name. This is better for readability and helps the others to understand your code. When using real names we can search in HLSDK/CSSDK(if the offset is cs related) and see how it is used, thus understanding better what it does. For example const OFFSET_TEAMS should be named m_iTeam, OFFSET_DEATH should be m_iDeaths.

[happy_2012]

Originally Posted by HamletEagle There is still room for improvement, like caching get_user_msgid("ScoreInfo"), because it won't change. static is misused in the command, new is more appropiate. Btw, when using offsets you should use their real name. This is better for readability and helps the others to understand your code. When using real names we can search in HLSDK/CSSDK(if the offset is cs related) and see how it is used, thus understanding better what it does. For example const OFFSET_TEAMS should be named m_iTeam, OFFSET_DEATH should be m_iDeaths.

I saw a post of yours saying static is better for getting names, perhaps I misunderstood it, can you tell me what is the difference between static and new? Perhaps steam chat would be better than flooding off this thread?

Updated:

PHP Code:

/* ===========================================================================
    
    -------------------
    -*- Reset Score -*-
    -------------------
    
    (c) 2015 - Chilimax
    Website: http://8bits-gaming.com
    
=========================================================================== */

#include < amxmodx >
#include < cstrike >
#include < fun >

#define PLUGIN_NAME        "Reset Score"
#define PLUGIN_VERSION    "1.0"
#define PLUGIN_AUTHOR    "Chilimax"

new const g_szClientCommands[][] =
{
    "say /rs", "say_team /rs",
    "say /resetscore", "say_team /resetscore",
    "say /restartscore", "say_team /restartscore"
}

new g_MsgScoreInfo;

public plugin_init()
{
    register_plugin(PLUGIN_NAME, PLUGIN_VERSION, PLUGIN_AUTHOR);
    
    register_cvar("reset_score_version", PLUGIN_VERSION, FCVAR_SERVER | FCVAR_SPONLY);
    set_cvar_string("reset_score_version", PLUGIN_VERSION);
    
    new Index, iMaxLoops = sizeof(g_szClientCommands);
    for(Index = 0; Index < iMaxLoops; Index++)
            register_clcmd(g_szClientCommands[Index], "ClientCommand_ResetScore");
    
    g_MsgScoreInfo = get_user_msgid("ScoreInfo");
}

public ClientCommand_ResetScore(Index)
{
    if( !get_user_frags(Index) && !cs_get_user_deaths(Index) )
    {
        client_print(Index, print_chat, "Your score is already reset");
        return PLUGIN_HANDLED;
    }
    
    set_user_frags(Index, 0);
    cs_set_user_deaths(Index, 0);
    
    UpdateClientScore(Index, 0, 0);
    
    new szName[32];
    get_user_name(Index, szName, charsmax(szName));
    
    client_print(0, print_chat, "%s has just reset his/her score");
    
    return PLUGIN_HANDLED;
}

UpdateClientScore(Index, iFrags, iDeaths)
{
    message_begin(MSG_ALL, g_MsgScoreInfo);
    write_byte(Index);
    write_short(iFrags);
    write_short(iDeaths);
    write_short(0);
    write_short(get_user_team(Index));
    message_end();    
} 


Steam profile: http://steamcommunity.com/id/zombies_win/

[HamletEagle]

I don't remember posting such thing, could you link to it ? I can PM you my steamid if you want, but there is not point to keep such discussions only for us, posting in the forum help other members too. Doesn't matter for what you are using the variables, it only matter to choose the right keyword in the right place(so saying that static is better for retrieving names is irelevant).
There is a tutorial about static variables by Hawk, but I would not recommed it because it does not explain when to use it and why.

Short version: static should be used in places that will be called a lot of times(and this is only the case of per frame forwards, like PreThink, CmdStart, AddToFullPack, etc) or on big arrays, to initialize them only one time, so to save some memory(notice the word big). Using it in places like connect, commands, init, spawn or sth like that is not needed. Initializing variables is fine, it only start to matter in the situations described above.

[happy_2012]

Originally Posted by HamletEagle I don't remember posting such thing, could you link to it ? I can PM you my steamid if you want, but there is not point to keep such discussions only for us, posting in the forum help other members too. Doesn't matter for what you are using the variables, it only matter to choose the right keyword in the right place(so saying that static is better for retrieving names is irelevant). There is a tutorial about static variables by Hawk, but I would not recommed it because it does not explain when to use it and why. Short version: static should be used in places that will be called a lot of times(and this is only the case of per frame forwards, like PreThink, CmdStart, AddToFullPack, etc) or on big arrays, to initialize them only one time, so to save some memory(notice the word big). Using it in places like connect, commands, init, spawn or sth like that is not needed. Initializing variables is fine, it only start to matter in the situations described above.

Yea alright, I got it!