[Phant]

Correct Silencers

Description:
This plugin add M4A1 and USP models (p_, w_) without silencer, and display it (ofcourse, when weapon without silencer). Like in Counter-Strike: Source.

Warning:
This plugin does not support Tactical Shield (B88). Use only if Tactical Shield disabled on your server.

Needed Include:
Counter-Strike pvPrivateData offsets (direct download link here).

Screenshots:


Thanks to:
KORD_12.7

Changelog:

• 1.0 — Release.
• 1.1 — ConnorMcLeod optimization tips.

[bibu]

Just you should know, this exists already, but your method is more reliable IMO.

http://forums.alliedmods.net/showthread.php?p=183118

[Phant]

Originally Posted by bibu Just you should know, this exists already, but your method is more reliable IMO. http://forums.alliedmods.net/showthread.php?p=183118

Oh my god . I got carried away with this plugin, forgetting about search .

Thanks for link. I will study existing codes and try make my version better...

[Kia]

Nice plugin anyway.

[ConnorMcLeod]

Better to check model string in SetModel forward, so it won't override model plugins.
You should allocate model strings at plugin initialisation and use set_pev_string instead of set_pev for pev_weaponmodel2

[Phant]

Originally Posted by ConnorMcLeod Better to check model string in SetModel forward, so it won't override model plugins.

Just like in your code?:

PHP Code:

public SetModel_Pre(ent, model[])
{
    if( pev_valid( ent ) )
    {
        if( equal(model, "models/w_usp.mdl") )
        {
            new usp = get_pdata_cbase(ent, m_rgpPlayerItems_wpnbx_slot2, XO_WEAPONBOX);
            if( usp > 0 && ~get_weapon_state( usp ) & WEAPONSTATE_USP_SILENCED )
            {
                SET_MODEL(ent, W_USP_NOSIL);
                return FMRES_SUPERCEDE;
            }
        }
        else if( equal(model, W_M4A1_SIL) )
        {
            new m4a1= get_pdata_cbase(ent, m_rgpPlayerItems_wpnbx_slot1, XO_WEAPONBOX);
            if( m4a1 > 0 && ~get_weapon_state( m4a1 ) & WEAPONSTATE_M4A1_SILENCED )
            {
                SET_MODEL(ent, W_M4A1_NOSIL);
                return FMRES_SUPERCEDE;
            }
        }
    }
    return FMRES_IGNORED;
} 


Originally Posted by ConnorMcLeod You should allocate model strings at plugin initialisation and use set_pev_string instead of set_pev for pev_weaponmodel2

Can you please say how I can set model via set_pev_string exactly?
I try:

PHP Code:

//set_pev(pPlayer, pev_weaponmodel2, P_USP)
set_pev_string(iWeapon, pev_model, mUSP) 


mUSP is global variable of precached model:

PHP Code:

new mUSP

public plugin_precache()
{
    mUSP = precache_model(P_USP) 


But it's not work.

[ConnorMcLeod]

For this plugin, i would compare passed model with pev_model, if doesn't match it means it has been changed by a model plugin at PRE hook, but sometimes trying to make plugins compatible is hard or stupid, dunno.

PHP Code:

public plugin_precache()
{
    precache_model(P_USP)
    mUSP = engfunc(EngFunc_AllocString, P_USP)
}

{
    //set_pev(pPlayer, pev_weaponmodel2, P_USP)
    set_pev_string(iWeapon, pev_weaponmodel2, mUSP)
    // or set_pev(iWeapon, pev_weaponmodel, mUSP)
    // which is basically the same,but not all pev_*** strings have this equivalent
} 


When you use set_pev and pev_weaponmodel2, it allocate the string each time at a new place in game dll memory, and this memory is never reset, even after map change, so allocate it 1 time in precache is far better

[Phant]

Updated (1.1). Hope, all are okay.

[HamletEagle]

Some fast thoughts:
1.Do not hardcode string-array size, use charsmax() to retrieve it.
2.Use real offset names, for readability. Instead of 35 and 36, use m_rgpPlayerItems_CWeaponBox[6] = { 34 , 35 , ... } and index by the weapon slot(1 for primary weapons and 2 for secondary), for 41 m_pPlayer etc.
3.You have a macro for m_fWeaponState, use it.
4.Please also fix the armoury_entities, get the armoury index with m_iItem or cs_get_armoury_index(with is the same thing) and check if it contains a M4A1(the index is 6).
5.Add support for shield.

[HamletEagle]

More than 15 days have passed and I don't see any changes from the author. Since section needs to be cleaned I'll unapprove this for now, but don't worry, your plugin can be reviewed at any time. PM a plugin approver after you made the changes.