Raised This Month: $12 Target: $400
 3% 

[L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix


Post New Thread Reply   
 
Thread Tools Display Modes
MasterMind420
BANNED
Join Date: Nov 2010
Old 06-26-2017 , 15:06   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #11

Quote:
Originally Posted by Visual77 View Post
How should I make it more clear. You don't check for console (client 0) on line 41. client == 0 is also an invalid client index. And all I'm saying is it's better to use just one syntax, especially the new one when you're also enforcing it (#pragma newdecls required).
The client check is meaningless and won't cause an issue. I will correct the client check regardless, for forms sake. But your input made me wonder why u said I was using old syntax with new. My plugin is new syntax, the thirdperson_detect plugin is old syntax, i will correct that as well...It didn't even occur to me because Lux and I both worked on it...He uses old syntax, which i would prefer it to be uniform. But I have to say the likelyhood of it clearing up edisons crash is slim to none. Thanks for the input...
MasterMind420 is offline
Visual77
Veteran Member
Join Date: Jan 2009
Old 06-26-2017 , 15:18   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #12

Quote:
Originally Posted by MasterMind420 View Post
The client check is meaningless and won't cause an issue. I will correct the client check regardless, for forms sake. But your input made me wonder why u said I was using old syntax with new. My plugin is new syntax, the thirdperson_detect plugin is old syntax, i will correct that as well...It didn't even occur to me because Lux and I both worked on it...He uses old syntax, which i would prefer it to be uniform. But I have to say the likelyhood of it clearing up edisons crash is slim to none. Thanks for the input...
It's not useless because it could have given you the following errors:

[SM] Native "IsClientInGame" reported: Client index 0 is invalid
[SM] Native "IsPlayerAlive" reported: Client index 0 is invalid
[SM] Native "GetClientTeam" reported: Client index 0 is invalid

Regards.

Last edited by Visual77; 06-26-2017 at 15:19.
Visual77 is offline
MasterMind420
BANNED
Join Date: Nov 2010
Old 06-26-2017 , 15:22   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #13

Quote:
Originally Posted by Visual77 View Post
It's not useless because it could have given you the following errors:

[SM] Native "IsClientInGame" reported: Client index 0 is invalid
[SM] Native "IsPlayerAlive" reported: Client index 0 is invalid
[SM] Native "GetClientTeam" reported: Client index 0 is invalid

Regards.
that would be true if index 0 could actually trigger weapon_fire event but it can't and a client triggering it would not have index 0(world), it is possible that it come back as -1 if the client prematurely disconnects. so as its coded that won't happen, but under other specific situations you are correct.
MasterMind420 is offline
Visual77
Veteran Member
Join Date: Jan 2009
Old 06-26-2017 , 15:27   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #14

Quote:
Originally Posted by MasterMind420 View Post
that would be true if index 0 could actually trigger weapon_fire event but it can't and a client triggering it would not have index 0(world), it is possible that it come back as -1 if the client prematurely disconnects. so as its coded that won't happen, but under other specific situations you are correct.
Ok, then you seem to know what you're doing. My apoligies
Visual77 is offline
MasterMind420
BANNED
Join Date: Nov 2010
Old 06-26-2017 , 15:35   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #15

Quote:
Originally Posted by Visual77 View Post
Ok, then you seem to know what you're doing. My apoligies
no worries man I always appreciate input. And yes regardless out of practice the client check should be corrected, that way if I use it in a situation where it would matter problems don't arise. Have you actually tested this on a windows server by chance?
MasterMind420 is offline
MasterMind420
BANNED
Join Date: Nov 2010
Old 06-26-2017 , 19:25   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #16

Quote:
Originally Posted by Edison1318 View Post
I've redownloaded it. But it still crashes.
Try this version...I suspect what may be wrong but I have no way to test it myself. If it crashes again there's one more change I can make.
Attached Files
File Type: sp Get Plugin or Get Source (l4d_shotgun_sound_fix.sp - 595 views - 7.7 KB)
MasterMind420 is offline
Edison1318
Senior Member
Join Date: Nov 2015
Location: Peaceful place of the in
Old 06-26-2017 , 22:06   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #17

Quote:
Originally Posted by MasterMind420 View Post
ok I need more info than that. I run everything on linux so i'm guessing your using windows. If so and there's anyone else out there that can confirm while using windows this crashes please say so, otherwise all I can assume is that there's a problem with your server/sourcemod installation. No error logs at all?
Yes it's true i'm using Windows. However, it does not appear the error log after my game crashes. So i perhaps i don't know the issue about that.
__________________
EdisonGar
Edison1318 is offline
Send a message via Skype™ to Edison1318
Lux
Veteran Member
Join Date: Jan 2015
Location: Cat
Old 06-26-2017 , 22:19   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #18

Could be a windows fuckup with Zoey and now on windows EmitGameSoundToClient() is broken for windows too
__________________
Connect
My Plugins: KlickME
[My GitHub]

Commission me for L4D
Lux is offline
Edison1318
Senior Member
Join Date: Nov 2015
Location: Peaceful place of the in
Old 06-26-2017 , 22:36   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #19

Yea true and thanks for that plugin anyway.
__________________
EdisonGar
Edison1318 is offline
Send a message via Skype™ to Edison1318
MasterMind420
BANNED
Join Date: Nov 2010
Old 06-27-2017 , 00:05   Re: [L4D/L4D2] Thirdpersonshoulder Shotgun Sound Fix
Reply With Quote #20

Quote:
Originally Posted by Edison1318 View Post
Yea true and thanks for that plugin anyway.
i'll have it fixed by tomorrow night, I just have to switch from using EmitGameSoundToClient...
MasterMind420 is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 14:23.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode