[ReCreator]

Originally Posted by HarryPotter Check if entity is valid first in BmsGlobalShit.sp

Spoiler

#include <sourcemod>
#include <left4dhooks>
#include <left4dhooks_anim>

public void OnPluginStart()
{
	HookEvent("player_death",               Event_PlayerDeathPre, EventHookMode_Pre);
}

public Action Event_PlayerDeathPre(Event event, const char[] sEvName, bool bDontBroadcast)
{
	int victim = GetClientOfUserId(GetEventInt(event, "userid"));

	if (bIsValidClient(victim) && GetClientTeam(victim) == 3)
	{
		L4D_Dissolve(victim);
	}
}

static bool bIsValidClient(int client)
{
	return IsClient(client) && IsClientInGame(client);
}

static bool IsClient(int client)
{
	return client > 0 && client <= MaxClients;
}

This code, with fine checks, throw the same error

[Silvers]

Looks like the dissolver entity is not being created. Will add a check for that.

[Silvers]

1.146 (21-Apr-2024)
    - Fixed a memory leak. Thanks to "HarryPotter" for reporting.
    - Fixed native "L4D_WriteMemoryString" buffer length. Thanks to "HarryPotter" for reporting.
    - Changed natives "L4D_Dissolve" and "L4D_TankRockPrj" to return -1 if the entity failed to be created. Thanks to "ReCreator" for reporting.

    - Updated: Plugin.
    - Updated: "/scripting/include/left4dhooks.inc" include file.
    - Updated: "/scripting/l4dd/l4dd_natives.sp" project file.

[Mystik Spiral]

Hi @Silvers!

This is very low priority but please consider in some future release marking L4D_IsMissionFinalMap AND L4D_IsFirstMapInScenario as TRUE for one-map campaigns like Tank Challenge and Tanks Playground.

Thanks!

[Silvers]

Originally Posted by Mystik Spiral Hi @Silvers! This is very low priority but please consider in some future release marking L4D_IsMissionFinalMap AND L4D_IsFirstMapInScenario as TRUE for one-map campaigns like Tank Challenge and Tanks Playground. Thanks!

Left4DHooks is calling the games natives, if they return false for those maps, that's how the game considers it.. adding something specific for those maps (e.g. detecting the map name and returning true) just seems hackish. I don't know, will think about it.

[Mystik Spiral]

Totally understand and no worries! Until then, I have the hack in my code, similar to:

static char sMapName[64];
GetCurrentMap(sMapName, sizeof(sMapName));
if (L4D_IsMissionFinalMap() || strncmp(sMapName, "l4d2_tank", 9) == 0)
{
    DoStuff;
}

[HarryPotter]

Originally Posted by Mystik Spiral Totally understand and no worries! Until then, I have the hack in my code, similar to: static char sMapName[64]; GetCurrentMap(sMapName, sizeof(sMapName)); if (L4D_IsMissionFinalMap() || strncmp(sMapName, "l4d2_tank", 9) == 0) { DoStuff; }

Try

PHP Code:

L4D_IsMissionFinalMap(true) 


PHP Code:

/**
 * @brief Tells if the Mission (map) is the final map of the campaign
 *
 * @param anyMap    True to return true if any map is a finale, not just the last map of a campaign (useful for campaigns that have multiple finale maps)
 *
 * @return            true if the map is the last map of the campaign (finale)
 */
native bool L4D_IsMissionFinalMap(bool anyMap = false);