[fysiks]

Originally Posted by drekes Updated to 1.7:

I would change:

PHP Code:

                if(Data[0] == ';' || (Data[0] == '/' && Data[1] == '/'))
                    continue; 


to

PHP Code:

                trim(Data)
                if(!Data[0] || Data[0] == ';' || (Data[0] == '/' && Data[1] == '/'))
                    continue; 


To prevent mistakes if file is edited by hand (aka allowing blank lines without concequences).

I also see a potential bug. It is because of using containi(). If you are overwriting for de_dust but de_dust2 comes before it then de_dust2 will be overwritten with de_dust and there will then be two de_dust's and no de_dust2's.

[drekes]

Thanks fysiks, i'll look into it.

Edit: done

[nikhilgupta345]

Looks good

Maybe make a cvar for the max amount of requests allowed? Maybe.

[drekes]

Originally Posted by nikhilgupta345 Looks good Maybe make a cvar for the max amount of requests allowed? Maybe.

There's a define for that:

#define MAX_REQUESTS 3

[ConnorMcLeod]

Code is ok.

Suggestions

• Don't use colorchat nor print_chat, but print_console when player nominate a map by command and not by chat.
• Make a cvar for max requests instead of define
• Decrease arrays size that handle map names, max mapnames length is 32, you may add some extra cells to potential quotes since you read files and such.

I also see another problem, same player can nominate the same map again and again, i mean there is a limitation per map, but once the map has changed, player can nominate again, or after a retry.
I see no good solution for this, except create on file per map and store votes and steamids, but meh...

APPROVED

[Anonymous]

Shit crashes my server rofl.

[drekes]

Do you got any error logs or any other kind of info that could help ?

[HLM]

setting "amx_mapreq_adsdelay" only affects on mapchange, perhaps you should remove the flag from the set_task and at the end of the advert task, set the task with a float of the cvar?

newline @ LINE157: set_task(get_pcvar_float(cvar_delay),"Task_Ad vert")

modify @ LINE88: set_task(get_pcvar_float(cvar_delay), "Task_Advert");

theres other ways of doing this, and im sure there are more efficient ways, this is only a suggestion