[404UserNotFound]

Originally Posted by Mitchell Yeah, enums are no longer supported in the new syntax, however this should just be converted to a Trie/Array the trie can be used to lookup the index which holds all the information within the enum (which can be converted into arrays) I actually went ahead and tried to convert the dev branch to the new syntax: https://bitbucket.org/MitchDizzle/su...90358f/?at=1-7

Oh beauty, eh. I've been meddling with the code for your plugin for a day and a half now trying to figure out how best to do the conversion from an enum to something for new syntax.

I'll check out the dev branch.

EDIT: Lookin' good. And you used the new methodmap setup for the arraylist and stringmap stuff, very nice. I like that. I do see there is still some code that needs to be converted over to new syntax, so I've begun taking care of that myself.

And boom, finally done. Fully updated the plugin along with the updater.inc file to new syntax. Keep in mind that I haven't actually tested the plugin ingame to make sure it has retained 100% functionality through the conversion. So what I did was I made two versions. "commandfilters_withcomments.sp" contains all the old syntax lines that I converted, commented out above the new syntax versions that I did. "commandfilters_without.sp" contains none of the old syntax code comments.

(and I did this entire conversion all by myself without getting help from Pelipoika or redwerewolf even figured out that tricky-ass "view_as<TFCond>(fltCond[k])" bit on my own)

EDIT: Crap in a hat, somehow, the 3 lines in the plugin that use "hClients" are bugging out because it's the handle part of the FilterClasses function and technically not an array. I've encountered this before, and I don't know how to fix it. So while I did convert as much old syntax over to new syntax as I could, the plugin is not compilable due to this bit of code below:

Compile error lists for both plugins inside

PHP Code:

// ====[ Filter Event ]========================================================
public bool FilterClasses(const char[] strPattern, Handle hClients) {

        // Snipped out the majority of the code from this function so the focus is on where it needs to be
        
        if(PlayerMatchesCriteria) {
            if(rndPlayers) {
                hPlayers.Push(i);
            } else {
                // error 105: cannot find method or property Handle.Push
                hClients.Push(i);
            }
        }
    }
    
    if(rndPlayers) {
        int rndCell;
        int rndPlayer = -1;
        int plySize = hPlayers.Length;
        while(rndPlayers > 0 && plySize > 0) {
            rndCell = GetRandomInt(0, plySize-1);
            rndPlayer = hPlayers.Get(rndCell);
            // error 105: cannot find method or property Handle.Push
            hClients.Push(rndPlayer);
            hPlayers.Erase(rndCell);
            plySize = hPlayers.Length;
            rndPlayers--;
        }
    }
    
    // error 105: cannot find method or property Handle.Length
    return (hClients.Length > 0);
} 


[Mitchell]

hClients will need to be handled the old way instead of the enum way because it's type of "Handle" and not "ArrayList"

[Mitchell]

Originally Posted by abrandnewday ~snip~

Thanks! I've went ahead and added onto your changes and fucked everything up!
I havent tested it but I enhanced the random filter to be easier to understand, it's literally 5 lines of code now
I've also separated the big blocks of codes into their own methods in order to simplify the client loop, if the filter is set to a single client then it wont do the loop and escape faster.
The random feature will randomly search for clients in the ArrayList and remove them until the ArrayList.Length is less than or equal to the number of random clients that is being searched for , this probably isn't the best way to find 1 single random player out of 32 players but it's the easiest way, perhaps i can add an if clause and cut some of the steps if the amount of players being picked < (MaxClients / 2) then it will use the opposite method and add to a new ArrayList instead of subtract from the current.
I haven't tested this at all, so some features (like the inverted) might be wrong since I tried to use Bitwise operators.
Source:
https://bitbucket.org/MitchDizzle/su...erTargeting.sp

[404UserNotFound]

Originally Posted by Mitchell Thanks! I've went ahead and added onto your changes and fucked everything up!

Is...is this good or bad? I honestly can't tell what you're trying to convey

EDIT: Oh thank god, you got rid of those weird "Is_Class()" and "Is_PlayerClass()" (or something) defined checks that you had originally and actually switched to a better system.

[Mitchell]

Originally Posted by abrandnewday Is...is this good or bad? I honestly can't tell what you're trying to convey EDIT: Oh thank god, you got rid of those weird "Is_Class()" and "Is_PlayerClass()" (or something) defined checks that you had originally and actually switched to a better system.

Yeah i wanted to get rid of GetEngineVersion() also so i switched to a static variable and just looked up the netprops.

[404UserNotFound]

Originally Posted by Mitchell Yeah i wanted to get rid of GetEngineVersion() also so i switched to a static variable and just looked up the netprops.

Hey, ain't nothing wrong with GetEngineVersion. It's a heck of a lot better than GetGameFolderName.

But for this particular purpose, yeah, the way you did it is much better than GetEngineVersion.

[PC Gamer]

This returns '[sm] no matching client was found' for anything I tried.

version 1.4.11 doesn't compile, and version 1.3.61 doesn't work.

Is there any working plugin that allows me to target @bluebots, @redbots, @bluehumans, @redhumans ?

[Mitchell]

I guess I never switched it over to the GitHub links.
Edit: I've updated merged the 1.7 changes and removed updater etc.
https://github.com/MitchDizzle/Super-Targeting

[PC Gamer]

Thanks Mitchell!

It works now.

[kot4404]

Is it possible to add few checks to 1 filter?

"@!zbots" { "text" "all but Z Flagged Admins" "bots" "1" "flag" "z" }

I guess so from this

"@scout" { "text" "all Scouts" "team" "0" "class" "1" }

but mine doesn't work, it should slay nonadmin players only but slays the bots also ( game is l4d2 )