[kww]

I have this piece of code

PHP Code:

static anim

if(anim = g_models[index][draw2])
{
    switch(random_num(1, DRAW2_CHANCE))
    {
        case DRAW2_CHANCE: play_anim(id, anim)
        default: play_anim(id, 3)
    }
} 


I like how it looks. It even compiles but compile.exe throws me a warn 211: possibly unintended assignment.
Do I have to change it (to code below) or not?

PHP Code:

static anim; anim = g_models[index][draw2]

if(anim)
{
    switch(random_num(1, DRAW2_CHANCE))
    {
        case DRAW2_CHANCE: play_anim(id, anim)
        default: play_anim(id, 3)
    }
} 


[HamletEagle]

Use () around the expression.

[kww]

Originally Posted by HamletEagle Use () around the expression.

which one? Don't understand

[fysiks]

The if statement expects a conditional expression which generally is an expression to compare two or more values. A common conditional expression is to compare equality of two values using the "==" comparison symbol. So, when you try to assign a value to a variable instead of doing a typical conditional expression, it thinks that you might have mistakenly forgot to add the second equal sign.

So, to suppress the warning, you need to put your variable assignment in parentheses so that it tells the compiler that you are intentionally doing a variable assignment instead of having a typo in your conditional expression.

Example:

PHP Code:

static anim

if( (anim = g_models[index][draw2]) )
{
    switch(random_num(1, DRAW2_CHANCE))
    {
        case DRAW2_CHANCE: play_anim(id, anim)
        default: play_anim(id, 3)
    }
} 


[kww]

Originally Posted by fysiks The if statement expects a conditional expression which generally is an expression to compare two or more values. A common conditional expression is to compare equality of two values using the "==" comparison symbol. So, when you try to assign a value to a variable instead of doing a typical conditional expression, it thinks that you might have mistakenly forgot to add the second equal sign. So, to suppress the warning, you need to put your variable assignment in parentheses so that it tells the compiler that you are intentionally doing a variable assignment instead of having a typo in your conditional expression. Example: PHP Code: static anim if( (anim = g_models[index][draw2]) ) {     switch(random_num(1, DRAW2_CHANCE))     {         case DRAW2_CHANCE: play_anim(id, anim)         default: play_anim(id, 3)     } }

That makes sense. Thanks