[johnny01]

If I were to use the code below to save clients information, would it save incorrectly when new clients connect and previous clients leave?

PHP Code:

public OnMapStart()
{
    CreateTimer(20.0, Savior, _, TIMER_REPEAT);
}

public Action:Savior(Handle:timer)
{
    for (new client = 1; client <= MaxClients; client++)
    {
        if (IsClientInGame(client) && !IsFakeClient(client))
        {
            DatabaseSave(client);
        }
    }
} 


[GsiX]

Judge from your code, it will. Keep in mind that the save only firing every 20 seconds which is, if client leave before the interval, he leave without trace.

If I were you, I do that on client connected and disconnected.

[Doodil]

It actually depends on the DatabaseSave() function. If the function retrieves the steam-id from the client-id and you clean up properly on disconnect/connect you should not have any problems. You do however not save the progress that happened since the last save this way.

But I agree with GsiX, you should load data on connect and save on disconnect, this way you won't unnecessarily spam your database every 20 seconds

[floube]

Maybe use OnClientAuthorized (where you have the SteamID already)?