[BlackComb]

This Menu was working in older version of SM; I don't know what changes.. Can someone help me Thanks

PHP Code:

public Action:CMDPLAYERSTATUS(client,args)
{
    decl String:line[100];
    
    new Handle:menu = CreateMenu(MenuHandler_SHOWPLAYERSTATUS);
    Format(line, sizeof(line), "Select Player to view status on:"); //DonateAPTOPlayer[client]);
    SetMenuTitle(menu, line);
    SetMenuExitBackButton(menu, true);
    
    AddTargetsToMenu2(menu, client, COMMAND_FILTER_NO_BOTS|COMMAND_FILTER_NO_IMMUNITY);

    
    DisplayMenu(menu, client, MENU_TIME_FOREVER);
}

public MenuHandler_SHOWPLAYERSTATUS(Handle:menu, MenuAction:action, param1, param2)
{
    if (action == MenuAction_End)
    {
        CloseHandle(menu);
    }
    if (action == MenuAction_Select)
    {
        //decl String:info[MAX_LINE_WIDTH];
        decl String:info[MAX_LINE_WIDTH], String:name[MAX_LINE_WIDTH];
        new userid, target;

        GetMenuItem(menu, param2, info, sizeof(info), _, name, sizeof(name));
        userid = StringToInt(info);
        
        
        target = GetClientOfUserId(userid);
        //new String:name[32];
        new String:myself[MAX_LINE_WIDTH];
        GetClientName(target, name, sizeof(name));
        GetClientName(param1, myself, sizeof(myself));
        GetClientName(param1, myself, sizeof(myself));


        PrintToChat(param1, "[SM] %t", "Player no longer available");


        new Handle:Displaymenu = CreatePanel();
        new String:pct[MAX_LINE_WIDTH];
        Format(pct, sizeof(pct), "%");
        new String:text[MAX_LINE_WIDTH];
        
        decl String:UserName[MAX_LINE_WIDTH];
        GetClientName(target, UserName, sizeof(UserName));
        
        Format(text, sizeof(text), "%s Status", UserName);
        SetPanelTitle(Displaymenu, text);

        Format(text, sizeof(text), "_____________________");
        DrawPanelText(Displaymenu, text);
        
        Format(text, sizeof(text), "Level: %d |  Cash: %d", PlayerLevel[target], PlayerCash[target]);
        DrawPanelText(Displaymenu, text);
        

        SendPanelToClient(Displaymenu, param1, DoNothing_Init, MENU_TIME_FOREVER);
        CloseHandle(Displaymenu);
        PrintToChatAll("%s is viewing %s status", myself, name);
        //}
    }
} 


[Grey83]

try instead of

PHP Code:

if (action == MenuAction_Select) 


this

PHP Code:

else if (action == MenuAction_Select) 


PHP Code:

        GetClientName(param1, myself, sizeof(myself));
        GetClientName(param1, myself, sizeof(myself)); 


I don't understand why this need 2 times

[BlackComb]

Yea, I just saw the double.. I delete one... Any other suggestion why it not working?

[General Lentils]

Maybe use the New Syntax at first...

new => int

new String:stringname[size] => char stringname[size]


public Action:ActionToDo(client, args) => public Action ActionToDo(int client, int args)

public OnPluginStart() => public void OnPluginStart()

public Handler(Handle:menu, MenuAction:action, param1, param2) => public int Handler(Handle menu, MenuAction action, int param1, int param2)
etc...

If you search "Sourcemod Menu API", you will find more about Menus.....

And so on... If you search on google, You will find more of what you are looking for..
Also, there is no need to use that many spaces..

Now onto the code itself, i suggest you don't really know what you are doing (correct me if i'm wrong)
and that this is a copy-paste from another person's code... So i suggest either using that person's plugin, or keep trying it yourself.. Since you will have to learn on your own... This won't come by just copying- and pasting over codes...

A few useful links that also contain what i said:

https://wiki.alliedmods.net/Menu_API_(SourceMod)

https://forums.alliedmods.net/showthread.php?t=244092


Conclusion: i think you need to rewrite this code... (Correct me if i'm wrong..)

[BlackComb]

I develop this myself.. But since SM change.. I'm trying to learn the new API...

This was working fine on SM 1.4

Now I'm using this code from this site:
https://wiki.alliedmods.net/Menus_St...Action_Display

PHP Code:

public Action CMDPLAYERSTATUS(int client, int args)
{
    
    
    char user_id[12];
    char name[MAX_NAME_LENGTH];
    char display[MAX_NAME_LENGTH+12];
    
    int num_clients;
    
    Menu menu = new Menu(MenuHandler_SHOWPLAYERSTATUS);
    menu.SetTitle("Select Player to view status on:");
        
    for (int i = 1; i <= MaxClients; i++)
    {
        
        IntToString(GetClientUserId(i), user_id, sizeof(user_id));
        GetClientName(i, name, sizeof(name));
        Format(display, sizeof(display), "%s (%s)", name, user_id);
        menu.AddItem(user_id, display);
        //PrintToChat(client, display);
        num_clients++;
    }
    menu.ExitButton = true;
    menu.Display(client, 20);
 
    return Plugin_Handled;
} 


[BlackComb]

After hours of trying.. I have finally got it working now..

Thank you

Please change this Thread to Solved