[Hammerfallerz]

As a topic says, can anyone fix this plugin?
http://forums.alliedmods.net/showthread.php?t=4478

Before that it on our server months ago, I've edited plugin and made it slap 5k times.

Yesterday on our zombie plague one dude started to block zombies to get to the humans and I've used holyslap on him. He said everything he thinks about me, what leaded for his temp. ban.
And I've noticed that he left, another player started to get holyslaped. Why? :O

Can anyone find a reason for it and fix it?

[fysiks]

I would try and help you but I won't touch a .rar file .

[Hammerfallerz]

PHP Code:

/* AMXMODX script.
* (c) Copyright 2004, TaL
* This file is provided as is (no warranties).
*
* AMX Holy Slap Plugin
*
* Slaps user 100 times 1HP at a time, then plays
* the attached sound as they fall out of the air
*
*
* usage: amx_holyslap authid, nick, or #userid
*
* Thanks to BarMan origonal Code
*
*/

#include <amxmodx>
#include <amxmisc>
#include <fun>

public admin_slap(id,level,cid){
   if (!cmd_access(id,level,cid,2))
   return PLUGIN_HANDLED

   new name[32]
   new arg[32]
   read_argv(1,arg,31)
   new player = cmd_target(id,arg,5)
   if (!player)
   return PLUGIN_HANDLED

   new ids[2]
   ids[0] = player
   get_user_name(player,name,32)
   disarm_player(id,player)
   set_task(0.1, "slap_player", 0, ids, 1, "a", 100)
   set_task(11.5, "last_words", 0, ids, 1, "a", 0)
   return PLUGIN_HANDLED
}

public disarm_player(id,victim){
   new name[32], origin[3]
   get_user_origin(victim,origin)
   origin[2] -= 2000
   set_user_origin(victim,origin)
   new iweapons[32], wpname[32], inum
   get_user_weapons(victim,iweapons,inum)
   for(new a=0;a<inum;++a){
      get_weaponname(iweapons[a],wpname,31)
      engclient_cmd(victim,"drop",wpname)
   }
   engclient_cmd(victim,"weapon_knife")
   origin[2] += 2005
   set_user_origin(victim,origin)
   get_user_name(victim,name,31)
   return PLUGIN_CONTINUE
}

public last_words(ids[]) {
   client_cmd(0,"spk misc/knockedout")
   return PLUGIN_HANDLED
}

public slap_player(ids[]) {
   new id = ids[0]
   new power1 = 1,nopower= 0
   if (get_user_health(id) > 1){
      user_slap(id,power1)
   } else {
      user_slap(id,nopower)
   }
   return PLUGIN_CONTINUE
}

public plugin_init(){
   register_plugin("AMXMODX Holy Slap","0.1.0","Ms-Proxy")
   register_concmd("amx_holyslap","admin_slap",ADMIN_SLAY,"<authid, nick or #userid>")
   return PLUGIN_CONTINUE
} 


This is original sourcecode. In a modded one I've deleted only this dumb sound.

Like:

PHP Code:

//    set_task(11.5, "last_words", 0, ids, 1, "a", 0) 


PHP Code:

/* public last_words(ids[]) {
   client_cmd(0,"spk misc/knockedout")
   return PLUGIN_HANDLED
} */ 


[fysiks]

Wow, are you sure that was the original source code? It's horrible (IMO), surprised that it was approved like that.

PHP Code:

#include <amxmodx>
#include <amxmisc>
#include <fun>

public plugin_init()
{
    register_plugin("AMXMODX Holy Slap","0.1.0","Ms-Proxy")
    register_concmd("amx_holyslap","admin_slap",ADMIN_SLAY,"<authid, nick or #userid>")
}  

public client_connect(id)
{
    remove_task(id)
}

public admin_slap(id,level,cid)
{
    if (!cmd_access(id,level,cid,2))
        return PLUGIN_HANDLED

    new arg[32]
    read_argv(1,arg,31)
    new player = cmd_target(id,arg,5)
    
    if(player)
    {
        disarm_player(id,player)
        set_task(0.1, "slap_player", id, _, _, "a", 100)
    }
    return PLUGIN_HANDLED
}

public disarm_player(id,victim)
{
    new origin[3]
    get_user_origin(victim,origin)
    origin[2] -= 2000
    set_user_origin(victim,origin)
    new iweapons[32], wpname[32], inum
    get_user_weapons(victim,iweapons,inum)
    
    for(new a=0;a<inum;++a)
    {
        get_weaponname(iweapons[a],wpname,31)
        engclient_cmd(victim,"drop",wpname)
    }
    
    engclient_cmd(victim,"weapon_knife")
    origin[2] += 2005
    set_user_origin(victim,origin)
}

public slap_player(id)
{
    if(get_user_health(id) > 1)
    {
        user_slap(id, 1)
    }
    else
    {
        user_slap(id, 0)
    }
} 


Updated, again . Had to get rid of some warnings.

[Hammerfallerz]

Um yea, one small notice: original file comes as an *.amx, but months ago I compiled it with AMXX Studio 1.8.1, so it has *.amxx right now, however, backwards compability (or whatever it's spelled) is enabled on our server, because we use one very old, but stable amx plugin.

Update: w00t, you're faster then me :O
I'll try, thanks again!

[Hammerfallerz]

And yeah, one small question: original plugin continues to slap punished user if he reconnects. Will modded one work like that also?

I can see:

PHP Code:

public client_connect(id) 
{ 
    remove_task(id) 
} 


This is fix, I understand, but how to make it to continue punishment to the user if he reconnects?

About crappy code: well, plugin's dated 2004 year

[fysiks]

Updated my code.

Originally Posted by Hammerfallerz And yeah, one small question: original plugin continues to slap punished user if he reconnects. Will modded one work like that also?

Actually, that is what you wanted fix lol .

[fysiks]

Updated again to get rid of warnings.

[Hammerfallerz]

No, you didnt understood.

Player "A" blocked and get holyslaped. He started to insult admins for it, so he received a ban. He got disconnected and some random B player started to get holyslaped as soon as A player left.
But when connected C client, B client stopped to get holyslaped and holyslap skipped to client C.

I only want if player "A" gets holyslapped and he reconnects -> continue punishment.
If "A" player leaves and does not connects, but connects some C player, plugin wont touch him, he didnt do anything to punish him.

Is this fixed? Will that happen?

[fysiks]

Originally Posted by Hammerfallerz He got disconnected and some random B player started to get holyslaped as soon as A player left.

I don't see how this is possible with this code.

Originally Posted by Hammerfallerz But when connected C client, B client stopped to get holyslaped and holyslap skipped to client C.

This is what I fixed. This is also what makes you think that the punishment was resumed when kicked player rejoined. (It's just a fluke)

So, making it so that the kicked player resumes his punishment (correctly) is much much more involved.

So, basically, I understand what you want. But what you want never existed before, it just happened to work that way once.