[vanz]

Can you provide access to the function return address? I needed to check if function were being called from a specific location. That would be a cool feature

[Psyk0tik]

I am getting crashes related to DHooks after upgrading to 2.2.0-detours13. I'm not sure if it's DHooks itself causing it or a plugin I have installed.

I'm not sure exactly what information I need to provide.

https://crash.limetech.org/n2yav6jbbmt7

EXCEPTION_ACCESS_VIOLATION_READ accessing 0xfffffffc

Thread 0 (crashed):
   0: dhooks.ext.dll!CHook::HookHandler(HookType_t) [ hook.cpp:159 + 0x9 ]
      eip: 0x64c8e916  esp: 0x001dc954  ebp: 0x001dc960  ebx: 0x17838700
      esi: 0x00000004  edi: 0x00000000  eax: 0x00000000  ecx: 0x00000000
      edx: 0x013ef250  efl: 0x00210246  

      64c8e90a  53           push ebx
      64c8e90b  75 35        jnz 0x64c8e942
      64c8e90d  8b 5d 08     mov ebx, [ebp+0x8]
      64c8e910  8b 4b 44     mov ecx, [ebx+0x44]
      64c8e913  8b 43 40     mov eax, [ebx+0x40]
  >   64c8e916  8b 54 88 fc  mov edx, [eax+ecx*4-0x4]
      64c8e91a  8d 41 ff     lea eax, [ecx-0x1]
      64c8e91d  89 43 44     mov [ebx+0x44], eax
      64c8e920  83 fa 02     cmp edx, 0x2
      64c8e923  75 0d        jnz 0x64c8e932
      64c8e925  8b 4b 18     mov ecx, [ebx+0x18]

      001dc954  00 00 00 00 5e c7 64 11  44 d3 9e 11 b4 ca 1d 00  ....^.d.D.......
      001dc964  0b 67 45 16                                       .gE.            

      Found via instruction pointer in context

[Peace-Maker]

Originally Posted by Crasher_3637 I am getting crashes related to DHooks after upgrading to 2.2.0-detours13. I'm not sure if it's DHooks itself causing it or a plugin I have installed. I'm not sure exactly what information I need to provide. https://crash.limetech.org/n2yav6jbbmt7

That looks like a regression from the recursive call fixes in detours11. I've pushed a fix for it, but would like to hold off on releasing another version just yet, since there seems to be quite a volume of reports and requests lately and I don't want to spam releases. You could roll back to detours10 in the mean time if you don't hit any of the cases fixed in later versions.

Originally Posted by vanz Can you provide access to the function return address? I needed to check if function were being called from a specific location. That would be a cool feature

Sounds like a nice way to prevent the need to detour the caller just to set a flag for the actual callee. I'll see how that can be added for vtable hooks and detours. I'd like to avoid adding another Handle type to push to the hook handler callbacks in plugins. The callback function signature is complicated as is already. Maybe some global stack of active hooks and their return addresses could be a way and just a DHookGetReturnAddress() native without any context arguments to get the top of that stack? Sounds messy though.

[Mi.Cura]

hi,
When using this plugin the server does not start, there was an update to:
dhooks-2.2.0-detours13-sm110

https://forums.alliedmods.net/showth...86#post2588686

After removing the plugin it returned to work.

P.s: I'm use SourceMod v1.11.0.6567

[Silvers]

Same here the latest v13 is causing crash on server start too. Windows SM 1.10. If you need more info I can try to figure out which plugin is causing and maybe what part of gamedata but guess some changes in last few updates broke existing plugins/gamedata. Currently using v9 (don't have any newer ones). If you need testing newer version, feel free to PM me a Windows binary (can't compile myself)

[Psyk0tik]

Peace-Maker already addressed the issue above (or previous page idk). He said to just revert to detours10 since a change in detours11 is causing the startup crash.

[Mi.Cura]

It would be very helpful to be able to make the previous version available in the initial post.
Because some servers are rented in companies that do not allow transfer of dll's via FTP, and the installation is done by a control panel.

So, the links that are now available for installation, no longer have the previous version.

Now only the latest version is available, which is not working properly causing crashes.

[nosoop]

Originally Posted by Mi.Cura It would be very helpful to be able to make the previous version available in the initial post. Because some servers are rented in companies that do not allow transfer of dll's via FTP, and the installation is done by a control panel.

Judgement of those companies aside, version 8 through 13 of dhooks+detours are available on the releases page.
Better hope whoever wrote that control panel can update accordingly.

[Mi.Cura]

Originally Posted by nosoop Judgement of those companies aside, version 8 through 13 of dhooks+detours are available on the releases page. Better hope whoever wrote that control panel can update accordingly.

Thanks for the idea.

[Peace-Maker]

I've released a new version detours14 with the mentioned crash fixed and more.

• Fix regression crash with post-only detours from recursive call fix in detours11 (Thanks Crasher_3637)
• Include sdktools.inc in include file for DHookSetFromConf native (Thanks ClaudiuHKS #4)
• Fix crash when trying to call hook removal callback on unloaded plugin (Thanks FortyTwoFortyTwo Drifter321#3)