Raised This Month: $32 Target: $400
 8% 

DeRoiD's Mapchooser v2.33


Post New Thread Reply   
 
Thread Tools Display Modes
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 04-13-2015 , 09:36   Re: DMC (Map chooser)
Reply With Quote #11

As I already told you 3 times, stop hardcoding paths. Maybe you will understand better from here: https://forums.alliedmods.net/showthread.php?t=40946
PHP Code:
#define MapFile "addons/amxmodx/configs/dmc/mapdatas.dmc"
#define PrevMapFile "addons/amxmodx/configs/dmc/prevmap.dmc" 
Pawn compiler sucks at optimization. If you use the same string multiple times it will appear more than one time in the string table.
PHP Code:
#define Prefix "!g[DMC]" 
This should be made a constant, not a define. Defines are removed during compilation process and are replaced by their value.
Formatex is faster than format, it's not hard to keep in mind that.

PHP Code:
new Error[64];
        
formatex(Errorcharsmax(Error), "%s file error! [%d maps] (min %d)"MapCycle_Linesget_pcvar_num(Cvar_MaxMaps));
        
set_fail_state(Error); 
In amxmodx 1.8.3 set_fail_state can format a string, maybe you would consider checking amxx version and using the appropiate way.
Charsmax should be used on strings, not sizeof - 1 for readability purpose. Also, sizeof is not a function as most of peoples think. It is sizeof string and not sizeof(string). Well, it won't affect anything, but just for the sake of doing things correctly.

Just something that I saw in the first 200 lines of your code.
__________________

Last edited by HamletEagle; 04-13-2015 at 09:37.
HamletEagle is offline
Spirit_12
Veteran Member
Join Date: Dec 2012
Location: Toronto, CA
Old 04-13-2015 , 10:33   Re: DMC (Map chooser)
Reply With Quote #12

Don't get me wrong, but it brings nothing new to the table. You need to add support for round based map change and voting system to make it unique.

All the described features are already present in Galileo, which is the go to map manager for almost all counter strike servers. Give people a reason to use this instead of Galileo.
Spirit_12 is offline
DeRoiD
Senior Member
Join Date: Feb 2015
Old 04-13-2015 , 15:45   Re: DMC v1.49a (Mapchooser)
Reply With Quote #13

Hamlet I removed hc panths.
I update the plugin.
+re-vote
__________________
DeRoiD is offline
DeRoiD
Senior Member
Join Date: Feb 2015
Old 04-14-2015 , 08:18   Re: DMC v1.49a (Mapchooser)
Reply With Quote #14

ACM1PT pls update spanish tra.
__________________
DeRoiD is offline
ACM1PT
Member
Join Date: Feb 2014
Location: Argentina
Old 04-14-2015 , 19:16   Re: DMC v1.49a (Mapchooser)
Reply With Quote #15

Quote:
Originally Posted by DeRoiD View Post
ACM1PT pls update spanish tra.
Lang file ?

EDIT:

Spanish translation re-update.

Please, do not change this option. (the one in the picture)
Attached Thumbnails
Click image for larger version

Name:	Sin título.png
Views:	586
Size:	88.9 KB
ID:	144200  
Attached Files
File Type: zip data.zip (2.5 KB, 231 views)

Last edited by ACM1PT; 04-14-2015 at 19:48.
ACM1PT is offline
DeRoiD
Senior Member
Join Date: Feb 2015
Old 04-15-2015 , 00:43   Re: DMC v1.49a (Mapchooser)
Reply With Quote #16

I removed ach.
I plugin not compatible amx 1.8.3..
I will fix.
__________________
DeRoiD is offline
Kia
AlliedModders Donor
Join Date: Apr 2010
Location: In a world of madness
Old 04-15-2015 , 01:40   Re: DMC v1.49a (Mapchooser)
Reply With Quote #17

Please remove the banner in your signature, promoting non-steam Servers is not allowed.
__________________
Kia is offline
Freezo Begin
BANNED
Join Date: Mar 2014
Location: Morocco
Old 04-15-2015 , 09:27   Re: DMC v1.49a (Mapchooser)
Reply With Quote #18

Seems a good plugin ( i didn't see the script , just the screenshots )
if i have time i will Update my post for the frensh Lang .
Freezo Begin is offline
DeRoiD
Senior Member
Join Date: Feb 2015
Old 04-15-2015 , 18:32   Re: DMC v1.49a (Mapchooser)
Reply With Quote #19

Thanks!
Freezo Begin
----------------
I fixed some error/bugs!
__________________
DeRoiD is offline
DeRoiD
Senior Member
Join Date: Feb 2015
Old 04-16-2015 , 15:59   Re: DMC v1.53a (Mapchooser)
Reply With Quote #20

Does somebody have mood to translate?

https://forums.alliedmods.net/showthread.php?t=261505
__________________

Last edited by DeRoiD; 04-17-2015 at 02:29.
DeRoiD is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:10.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode