[alliedfront]

Originally Posted by Dragokas @alliedfront, looks fine. Much thanks! I just did optimizations. Please, check in production. 1st post is updated. Not tested.

@Dragokas, with pleasure! I tested 3.1 on my test server and found some bugs + did a small clarification in the text about a cfg variable. Also did a small grammatical correction in the translation file. Attached are the two fixed files + diffs to 3.1. I will now also activate it on my live server.

[Dragokas]

@alliedfront, no need for diff, since I'm using WinMerge or Beyond Compare to do that.

Also, I don't agree with you in 2 things:
1) I'm not native English speaker, but I don't think adding "is" is appropriate here:

"{green}%N {orange}is started vote for kick: {cyan}%s\n"

verb is not "-ing" and also subject (%N) directly execute the action ("start"), so "is" isn't required here AFAIK.

2) Why do you think

bool IsVoteAllowed(int client, int target)
{
	if( target <= 0 )
		return false;

this check isn't appropriate to do at the very begin of the routine?

[alliedfront]

Originally Posted by Dragokas @alliedfront, no need for diff, since I'm using WinMerge or Beyond Compare to do that. Also, I don't agree with you in 2 things: 1) I'm not native English speaker, but I don't think adding "is" is appropriate here: "{green}%N {orange}is started vote for kick: {cyan}%s\n" verb is not "-ing" and also subject (%N) directly execute the action ("start"), so "is" isn't required here AFAIK. 2) Why do you think bool IsVoteAllowed(int client, int target) { if( target <= 0 ) return false; this check isn't appropriate to do at the very begin of the routine?

1) The diff was: fixed version to old 3.1 version, so "is" was removed in new version. Please check new version. Next time no diffs. : )
2) The check is not appropriate because target == -1 is also the index of a kicked player. You cannot un-kick him with your check because the function returns false.

[Dragokas]

@alliedfront, ahh, sorry, I almost sleeping. Will do an update tomorrow.

[alliedfront]

Originally Posted by Dragokas @alliedfront, ahh, sorry, I almost sleeping. Will do an update tomorrow.

Np, @Dragokas. I appreciate your quick response and that you check changes and carry out optimizations. I will game a little. : )

[Dragokas]

Ok, looks good. I left it as is.

Plugin is updated.

3.2 (30-Jan-2024) by alliedfront - Fixed regression: unkick didn't work because of incorrect access check. - Fixed access check to allow everybody to kick players if the flag string is empty. - Fixed spelling. - Translation file is updated. 3.3 (31-Jan-2024) - Added kick reason "Team killer". - Translation file is updated.

[glhf3000]

Add reason to hint pls.

PHP Code:

CreateTimer(g_fCvarAnnounceDelay, Timer_VoteDelayed, menu);
if ( g_bIsVersus ) 
    if( bHasPhrase )
        CPrintHintTextToTeam( "%t\n%t", "vote_started_announce", g_sName, "ReasonHint", sReasonEng);
    else 
        CPrintHintTextToTeam( "%t", "vote_started_announce", g_sName);
else
    CPrintHintTextToAll("%t", "vote_started_announce", g_sName); 


"ReasonHint"
{
	"#format"	"{1:t}"
	"en"		"Reason: {1}"
	"ru"		"Причина: {1}"
}

LogToFileEx(g_sLog, "[TRIED] to UN?kick against: %s", name);

PHP Code:

void StartVoteAccessCheck_UnKick(int client, char[] sSteam)
{
    if( IsVoteInProgress() || g_bVoteInProgress ) {
        CPrintToChat(client, "%t", "other_vote");
        LogVoteAction(client, "[DENY] Reason: another vote is in progress.");
        return;
    }

    if( !IsVoteAllowed(client, -1) )
    {
        char name[MAX_NAME_LENGTH];
        hMapPlayerName.GetString(sSteam, name, sizeof(name));
        CPrintToChatAll("%t", "no_access_specific_unkick", client, name); // "%s tried to use votekick against %s, but has no access."
        LogVoteAction(client, "[NO ACCESS]");
        LogToFileEx(g_sLog, "[TRIED] to kick against: %s", name);
        return;
    }

    StartVoteUnKick(client, sSteam);
} 


P.S. took a long time to understand why sm_pass bind didnt do anything, mb sm_votepass->sm_pass?

PHP Code:

RegConsoleCmd("sm_votepass",     Command_Votepass,     "Allow admin to bypass current vote."); 


[Dragokas]

@[ru]In1ernal Error, check is it work.

[alliedfront]

@Dragokas, I just found a small bug: with the first !vk remaining expired entries were found and deleted correctly, but since in such a case the for loop did not skip an iteration, the menu was still displayed with the expired time and a random name. At the next !vk there were finally only valid entries.

To fix this in version 3.3 of l4d_votekick.sp, a "continue;" should be added on line 533, so that the menu always is filled only with valid entries for un-kick:

PHP Code:

        for( int i = 0; i < hSnap.Length; i++ )
        {
            hSnap.GetKey(i, sSteam, sizeof(sSteam));
            hMapSteam.GetString(sSteam, sTime, sizeof(sTime));
            iTime = StringToInt(sTime);
            if( (g_iCvarKickTime - (GetTime() - iTime)) < 0 ) {    // leftover expired entries (negative time) of kicked players are deleted, for reasons of clarity
                                                                // (had 3 pages of expired entries after 2 days, which were displayed on each !vk to the client)
                hMapSteam.Remove(sSteam);
                hMapPlayerName.Remove(sSteam);
                hMapPlayerTeam.Remove(sSteam);
                continue;
            }
            hMapPlayerName.GetString(sSteam, name, sizeof(name));
            hMapPlayerTeam.GetValue(sSteam, iPlayerTeam);
            
            // add target to menu for unkick. active for both: co-op and versus (versus: only issuer team can unkick target)
            // Versus: don't allow opposite team to unkick a player who was kicked by issuer team (could be friend of the opposite team who acts destructive or just a mad anonymous tk)
            if( !(g_bIsVersus && iIssuerTeam != iPlayerTeam) ) {    
                Format(menuItem, sizeof(menuItem), "%s %s %T", g_sCharKicked, name, "time_left", client, (g_iCvarKickTime - (GetTime() - iTime)) / 60);  
                menu.AddItem(sSteam, menuItem);
            }
        } 


[Dragokas]

Right, make sense.
Waiting for answer from [ru]In1ernal Error.