Raised This Month: $99 Target: $400
 24% 

[TF2] Deathrun Redux 2019


Post New Thread Reply   
 
Thread Tools Display Modes
MAGNAT2645
Senior Member
Join Date: Nov 2015
Location: AlliedMods.net
Old 08-10-2019 , 18:45   Re: [TF2] Deathrun Redux 2019
Reply With Quote #11

Mr_panica, can you test plugin from post #7 (it has translation support (and russian phrases file), syntax update, and some code cleanup/improvement) and tell me if you have same error as at #8?
__________________
MAGNAT2645 is offline
Hoto Cocoa
Member
Join Date: Jun 2018
Location: Somewhere
Old 08-10-2019 , 23:32   Re: [TF2] Deathrun Redux 2019
Reply With Quote #12

Quote:
Originally Posted by MAGNAT2645 View Post
This is another error, i'll check that out.

EDIT: Weird, i don't have this error. I don't know why this error appears because there's client index check.
Code:
	int iClient = GetClientOfUserId( data );
	if ( iClient && !IsPlayerAlive( iClient ) )
I can do something like this:
Code:
	int iClient = GetClientOfUserId( data );
	if ( iClient && IsClientInGame( iClient ) && !IsPlayerAlive( iClient ) )
but i don't think that this is necessary. In fact, if ( iClient ) replaces IsClientInGame.
It appears when a player is still downloading maps but being chosen as a death. Although it should have a check but looks like something goes wrong.
Hoto Cocoa is offline
Mr_panica
Member
Join Date: Jan 2017
Location: Russia, Saint-Petersburg
Old 08-13-2019 , 15:29   Re: [TF2] Deathrun Redux 2019
Reply With Quote #13

Quote:
Originally Posted by MAGNAT2645 View Post
Mr_panica, can you test plugin from post #7 (it has translation support (and russian phrases file), syntax update, and some code cleanup/improvement) and tell me if you have same error as at #8?
Hello,
Thanks for the translation, did not notice your version.

There is still this error.

Code:
L 08/13/2019 - 22:15:43: [SM] Exception reported: Client index 125 is invalid
L 08/13/2019 - 22:15:43: [SM] Blaming: deathrun_redux.smx
L 08/13/2019 - 22:15:43: [SM] Call stack trace:
L 08/13/2019 - 22:15:43: [SM]   [0] GetClientHealth
L 08/13/2019 - 22:15:43: [SM]   [1] Line 1499, DeathRun Redux 2019::OnPlayerDeath
L 08/13/2019 - 22:15:49: [SM] Exception reported: Client index 125 is invalid
L 08/13/2019 - 22:15:49: [SM] Blaming: deathrun_redux.smx
L 08/13/2019 - 22:15:49: [SM] Call stack trace:
L 08/13/2019 - 22:15:49: [SM]   [0] GetClientHealth
L 08/13/2019 - 22:15:49: [SM]   [1] Line 1499, DeathRun Redux 2019::OnPlayerDeath
L 08/13/2019 - 22:15:49: [SM]   [3] ForcePlayerSuicide
L 08/13/2019 - 22:15:49: [SM]   [4] Line 37, /home/builds/sourcemod/linux-1.9/build/plugins/playercommands/slay.sp::PerformSlay
L 08/13/2019 - 22:15:49: [SM]   [5] Line 147, /home/builds/sourcemod/linux-1.9/build/plugins/playercommands/slay.sp::Command_Slay
__________________
Sorry for my English.
Mr_panica is offline
Mitchell
~lick~
Join Date: Mar 2010
Old 08-13-2019 , 17:14   Re: [TF2] Deathrun Redux 2019
Reply With Quote #14

"Redux 2019" but is the unsupported syntax..
Not to mention all the pointless StringMaps (Tries) it creates and never uses..
Some of the StringMaps are literally used to map numbers to sound paths via converting the number to string and using it as the key! Using a map in the place of an ArrayList seems a bit questionable.
Also noticed you store a bunch of things globally only to use it those variables once when the map starts.
Should I even say anything about the "OnGameFrame()" foward?

Things that have to iterate over all the players every game frame should be made with optimization for speed as much as possible. (Most of what is done in the frame forward could be done else where or with TF2 Attributes.)
__________________

Last edited by Mitchell; 08-13-2019 at 17:17.
Mitchell is online now
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 22:10.


Powered by vBulletin®
Copyright ©2000 - 2019, vBulletin Solutions, Inc.
Theme made by Freecode