[Solved] it keep just print 1, whatever which weapon i'm handling

zonbarbar · **Author**

i don't know how is this going, any another better way to make this happen?

code:
public Action CheckPlayerWeapon(Handle timer)
{

for(int client = 1; client <= MaxClients; client++)
{

if(IsSurvivor(client) && IsPlayerAlive(client) && !IsFakeClient(client))
{

int weapon = GetPlayerWeaponSlot(client, 0);
if (weapon == -1)
{
return Plugin_Continue;
}

char weaponClass[32];
GetEdictClassname(weapon, weaponClass, sizeof(weaponClass));

if(StrEqual(weaponClass, "weapon_smg_mp5")||(weaponClass, "weapon_rifle")||(weaponClass, "weapon_sniper_military"))
{
PrintToChat(client, "1");
}
else if(StrEqual(weaponClass, "weapon_rifle_desert")||(weaponClass, "weapon_sniper_awp")||(weaponClass, "weapon_shotgun_spas"))
{
PrintToChat(client, "2");
}
else if(StrEqual(weaponClass, "weapon_smg")||(weaponClass, "weapon_rifle_ak47")||(weaponClass, "weapon_shotgun_chrome"))
{
PrintToChat(client, "3");
}
else if(StrEqual(weaponClass, "weapon_autoshotgun")||(weaponClass, "weapon_sniper_scout")||(weaponClass, "weapon_rifle_sg552"))
{
PrintToChat(client, "4");
}
else if(StrEqual(weaponClass, "weapon_hunting_rifle")||(weaponClass, "weapon_smg_silenced")||(weaponClass, "weapon_pumpshotgun"))
{
PrintToChat(client, "5");
}
else
{
PrintToChat(client, "6");
}
return Plugin_Continue;
}
return Plugin_Continue;
}
return 0;
}

zonbarbar · 07-25-2023 , 11:51 Re: it keep just print 1, whatever which weapon i'm handling

and bots look like will not be check, this is timer code: CreateTimer(1.0, CheckPlayerWeapon, client, TIMER_REPEAT);

Red Flame · *Last edited by Red Flame; 07-25-2023 at 13:02.*

You need to check weapons like this:

Code:

if (StrEqual(weaponClass, "weapon_smg_mp5") || StrEqual(weaponClass, "weapon_rifle") || StrEqual(weaponClass, "weapon_sniper_military"))

etc...
I underlined a missing stuff.

But in every string we have "weapon_" so we don't need to check this every time, we may do it like this:

Code:

if (strcmp(weaponClass[7], "smg_mp5") == 0 || strcmp(weaponClass[7], "rifle") == 0 || strcmp(weaponClass[7], "sniper_military") == 0)

You don't need to put client index in this timer

Code:

CreateTimer(1.0, CheckPlayerWeapon, _, TIMER_REPEAT);

zonbarbar · 07-25-2023 , 13:45 Re: it keep just print 1, whatever which weapon i'm handling

Quote:

Originally Posted by Red Flame

You need to check weapons like this:

Code:

if (StrEqual(weaponClass, "weapon_smg_mp5") || StrEqual(weaponClass, "weapon_rifle") || StrEqual(weaponClass, "weapon_sniper_military"))

etc...
I underlined a missing stuff.

But in every string we have "weapon_" so we don't need to check this every time, we may do it like this:

Code:

if (strcmp(weaponClass[7], "smg_mp5") == 0 || strcmp(weaponClass[7], "rifle") == 0 || strcmp(weaponClass[7], "sniper_military") == 0)

You don't need to put client index in this timer

Code:

CreateTimer(1.0, CheckPlayerWeapon, _, TIMER_REPEAT);

alright, i see

Grey83 · *Last edited by Grey83; 07-27-2023 at 03:43.*

PHP Code:


			
public Action CheckPlayerWeapon(Handle timer)
{
    char wpn[24];
    for(int i = 1, weapon; i <= MaxClients; i++)
        if(IsSurvivor(i) && !IsFakeClient(i) && IsPlayerAlive(i) && (weapon = GetPlayerWeaponSlot(i, 0)) != -1)
        {
            GetEdictClassname(weapon, wpn, sizeof(wpn));
            if(!strcmp(wpn[7], "smg_mp5") || !strcmp(wpn[7], "rifle") || !strcmp(wpn[7], "sniper_military"))
                PrintToChat(i, "1");
            else if(!strcmp(wpn[7], "rifle_desert") || !strcmp(wpn[7], "sniper_awp") || !strcmp(wpn[7], "shotgun_spas"))
                PrintToChat(i, "2");
            else if(!strcmp(wpn[7], "smg") || !strcmp(wpn[7], "rifle_ak47") || !strcmp(wpn[7], "shotgun_chrome"))
                PrintToChat(i, "3");
            else if(!strcmp(wpn[7], "autoshotgun") || !strcmp(wpn[7], "sniper_scout") || !strcmp(wpn[7], "rifle_sg552"))
                PrintToChat(i, "4");
            else if(!strcmp(wpn[7], "hunting_rifle") || !strcmp(wpn[7], "smg_silenced") || !strcmp(wpn[7], "pumpshotgun"))
                PrintToChat(i, "5");
            else PrintToChat(i, "6");
        }

    return Plugin_Continue;
}

This code will send number by timer to survivors.

But maybe it's better to show the number only when the player has picked up a weapon?

PHP Code:


			
public void OnClientPutInServer(int client)
{
    if(!IsFakeClient(client)) SDKHook(client, SDKHook_WeaponEquipPost, Hook_WeaponEvent);
}

public void Hook_WeaponEvent(int client, int weapon)
{
    RequestFrame(RequestFrame_Callback, GetClientUserId(client));
}

public void RequestFrame_Callback(any client)
{
    static int weapon;
    if(!(client = GetClientOfUserId(client)) || !IsPlayerAlive(client) || (weapon = GetPlayerWeaponSlot(client, 0)) == -1)
        return;

    GetEdictClassname(weapon, wpn, sizeof(wpn));
    if(!strcmp(wpn[7], "smg_mp5") || !strcmp(wpn[7], "rifle") || !strcmp(wpn[7], "sniper_military"))
        PrintToChat(client, "1");
    else if(!strcmp(wpn[7], "rifle_desert") || !strcmp(wpn[7], "sniper_awp") || !strcmp(wpn[7], "shotgun_spas"))
        PrintToChat(client, "2");
    else if(!strcmp(wpn[7], "smg") || !strcmp(wpn[7], "rifle_ak47") || !strcmp(wpn[7], "shotgun_chrome"))
        PrintToChat(client, "3");
    else if(!strcmp(wpn[7], "autoshotgun") || !strcmp(wpn[7], "sniper_scout") || !strcmp(wpn[7], "rifle_sg552"))
        PrintToChat(client, "4");
    else if(!strcmp(wpn[7], "hunting_rifle") || !strcmp(wpn[7], "smg_silenced") || !strcmp(wpn[7], "pumpshotgun"))
        PrintToChat(client, "5");
    else PrintToChat(client, "6");
}