[ConnorMcLeod]

You misunderstood the buffer and cvar thing, you don't need to retrieve the 2 cvar values each times.

PHP Code:

    new t_won_msg[MAX_CHARACTERS + 1], ct_won_msg[MAX_CHARACTERS + 1]
    get_pcvar_string(msgcvar_t, t_won_msg, MAX_CHARACTERS)
    get_pcvar_string(msgcvar_ct, ct_won_msg, MAX_CHARACTERS) 


Just create 1 array, and set it with the needed cvar, according to WinningTeam.
Then you can let as it was previously, different colours depending on winning team.

[Jhob94]

I tried create 2 arrays, each one for one cvar but then the message that was displayed was from default game

[Nextra]

There is no need for two arrays.

PHP Code:

new won_msg[MAX_CHARACTERS + 1]
get_pcvar_string(WinningTeam == 1 ? msgcvar_t : msgcvar_ct, won_msg, MAX_CHARACTERS) 


[DIS]

What about Round Draw message?
I know maybe there is no usage of it but it should have this feature at least to get approved (If the other same plugin don't have the Round Draw message).

[Jhob94]

Updated.
Instead of do that, i made it read cvars in plugin_init, so it will only check cvar once. Better no?

[Nextra]

Now they can't be changed during gameplay anymore. Plus, even if you would want to do it like this, it would have to be done in plugin_cfg and not in plugin_init.

The only sensible alternative you have would be converting the cvars to console commands that update the buffers when they are used.

But this is only called once per round and has no performance impact whatsoever. No point in making these optimizations. Just read them out like before but remove the unnecessary code.

[Jhob94]

Updated, is it now ok?
Btw it doesnt affects the "performance impact" so it was really needed?

[Nextra]

There is a difference.

You can make a negligible performance improvement that takes a disproportionate amount of work and/or unnecessarily sacrifices usability which misses the point and scope of your plugin totally.

And you can remove a completely unnecessary buffer that has no business being there in the first place. You need to branch based on WinningTeam anyway so why use two buffers when you always use just one of them.

This was a trivial change that makes the code cleaner and simpler, DRY is the magic keyword. The added benefit of a minute performance gain is not the main issue here, code design is.

Also, there may be a point where rather obvious stuff like this can make the difference (like if a similar function was called very frequently or in a rapid succession).

[KabirDuy]

Good! But not necessary.

[Jhob94]

Updated.
Now it supports round draw message.