[ltgenkd]

How do I make the annotations stationary? I've been changing the view distance but can't seem to get them to stay stationary.
Using sql version.

Thanks

[Holek]

Geit, I found two little bugs in the SQL version (didn't check the non-sql version).
First is a typo in plugin info:

public Plugin:myinfo = 
{
	name = "Annoatations SQL",

Second is db table that this plugin creates. You enforce engine and auto-increment value upon creation of the table.

CREATE TABLE IF NOT EXISTS `annotations` (`id` int(16) unsigned NOT NULL AUTO_INCREMENT, `creator` varchar(64) COLLATE utf8_unicode_ci DEFAULT NULL, `creator_steam_id` varchar(25) COLLATE utf8_unicode_ci DEFAULT NULL, `text` varchar(256) COLLATE utf8_unicode_ci DEFAULT NULL, `file` varchar(64) COLLATE utf8_unicode_ci DEFAULT NULL, `time` timestamp NULL DEFAULT CURRENT_TIMESTAMP, `deleted` int(1) DEFAULT '0', `position_x` int(5) DEFAULT NULL, `position_y` int(5) DEFAULT NULL, `position_z` int(5) DEFAULT NULL, PRIMARY KEY (`id`), KEY `creator_community_id` (`creator_steam_id`), KEY `file` (`file`));

As you can see I've added new index `file` for the map name; that way the annotations' query will be processed faster during Event_RestartRound. Might want to change to that query.

Otherwise it's a great mod, thanks a bunch!

Oh, also, I attach .sp file with these changes.

[Kilandor]

Omg why didn't you tell me this finaly got working. I gave up hope on it ever working. I've been waiting since training came out and I tried everything possible to get it to work

[Kilandor]

Originally Posted by msleeper Someone is reporting getting lag from this plugin. The blip is light blue "events", whenever the plugin fires to refresh the annotations. Not sure if there is anything you can do about this.

With 5 annotations on the ground refreshing every 0.1 and a "rate" of 10k I recive lag/choke. With rate of 25k there is no lag/choke
In short firing the events to often, or in this case all of them updating at once, is causing a large chunk of data to be sent. More than the client can handle causing lag/stutter.
And default TF2 rate is 10k. You could force a minimum, but I wouldn't recommend this.

Update Again: Removed last update text as I was mistakenly creating a 1second timer in a 0.1 timer, that lead to a crapload of timers being made sending lots of events

Even at 1s tough to many can cause lag for lower users, however changing the distance to a much lower value can largely help

[FoxMulder]

Look's like the event is not closing itself because the handles aren't being freed. I tried spawning a bunch of annotations then waited for them to disappear and did a sm_dump_handles and it still showed them in memory. This would eventually make Sourcemod unload this plugin to free some handles :/

0x08360673    annotations.smx         GameEvent               -1        
0x07db0674    annotations.smx         GameEvent               -1        
0x07dc0675    annotations.smx         GameEvent               -1        
0x08160676    annotations.smx         GameEvent               -1        
0x07e10677    annotations.smx         GameEvent               -1        
0x07e20678    annotations.smx         GameEvent               -1        
0x07e40679    annotations.smx         GameEvent               -1        
0x07e5067a    annotations.smx         GameEvent               -1        
0x07e6067b    annotations.smx         GameEvent               -1        
0x07e9067c    annotations.smx         GameEvent               -1        
0x081e067d    annotations.smx         GameEvent               -1        
0x07f1067e    annotations.smx         GameEvent               -1        
0x07f2067f    annotations.smx         GameEvent               -1        
0x07f90680    annotations.smx         GameEvent               -1        
0x07fa0681    annotations.smx         GameEvent               -1        
0x082e0682    annotations.smx         GameEvent               -1        
0x08050683    annotations.smx         GameEvent               -1        
0x08060684    annotations.smx         GameEvent               -1        
0x08120686    annotations.smx         GameEvent               -1

[BrianGriffin]

Would it be possible to attach an annotation to a player? For example have a annotation saying "ADMIN" following a player around?

[FoxMulder]

"show_annotation"
    {
        "worldPosX" "float"
        "worldPosY" "float"
        "worldPosZ" "float"
        "id" "long"
        "text"        "string"    // name (unlocalized)
        "lifetime"    "float"
        "visibilityBitfield"    "long" // bitfield of the players that can see this
    }

The annotations can't be parented through this plugin. You can make a really fast timer so it appears to be parented but like I posted before it'll end up crashing.

[Geit]

Originally Posted by FoxMulder "show_annotation" { "worldPosX" "float" "worldPosY" "float" "worldPosZ" "float" "id" "long" "text" "string" // name (unlocalized) "lifetime" "float" "visibilityBitfield" "long" // bitfield of the players that can see this } The annotations can't be parented through this plugin. You can make a really fast timer so it appears to be parented but like I posted before it'll end up crashing.

Fixed the handle leak (Fixed it in a private plugin, forgot to update it here >.>), version 1.41 is up

[Kilandor]

public SpawnAnnotation(id)
{
    new bitstring = BuildBitString(g_AnnotationPosition[id]);
    if (bitstring > 1 || g_AnnotationCanBeSeen[id])
    {
        if (bitstring > 1)
        {
            g_AnnotationCanBeSeen[id] = true;
        }
        else
        {
            g_AnnotationCanBeSeen[id] = false;
        }
        
        new Handle:event = CreateEvent("show_annotation");
        if (event != INVALID_HANDLE)
        {
            SetEventFloat(event, "worldPosX", g_AnnotationPosition[id][0]);
            SetEventFloat(event, "worldPosY", g_AnnotationPosition[id][1]);
            SetEventFloat(event, "worldPosZ", g_AnnotationPosition[id][2]);
            SetEventFloat(event, "lifetime", 10.0);
            SetEventInt(event, "id", id);
            SetEventString(event, "text", g_AnnotationText[id]);
            SetEventInt(event, "visibilityBitfield", bitstring);
            FireEvent(event);
        }
    }
}

This is slightly flawed, this prevents the leak but is improper

if (bitstring > 1 || g_AnnotationCanBeSeen[id])

g_AnnotationCanBeSeen[id] is only set INSIDE of this Call, meaning Lets say if bitstring is 1 it will go in and set this to true, the problem is, lets say bitstring isn't 1, but the previous call it was. This causes it to go into that section anyways the reason it doesn't leak, is because FireEvent ALWAYS gets called unlike before bitstring had to be 1 to fire event. So its still a bit wasteful


So this would be a better solution

public SpawnAnnotation(id)
{
    new bitstring = BuildBitString(g_AnnotationPosition[id]);
    if (bitstring > 1)
    {
        new Handle:event = CreateEvent("show_annotation");
        if (event != INVALID_HANDLE)
        {
            SetEventFloat(event, "worldPosX", g_AnnotationPosition[id][0]);
            SetEventFloat(event, "worldPosY", g_AnnotationPosition[id][1]);
            SetEventFloat(event, "worldPosZ", g_AnnotationPosition[id][2]);
            SetEventFloat(event, "lifetime", 5.0);
            SetEventInt(event, "id", id);
            SetEventString(event, "text", g_AnnotationText[id]);
            SetEventInt(event, "visibilityBitfield", bitstring);
            FireEvent(event);
        }
    }
}

Alternatively but still wasteful as it still creates an event, this could be done

public SpawnAnnotation(id)
{
    new Handle:event = CreateEvent("show_annotation");
    if (event != INVALID_HANDLE)
    {
        new bitstring = BuildBitString(g_AnnotationPosition[id]);
        if (bitstring > 1)
        {
            SetEventFloat(event, "worldPosX", g_AnnotationPosition[id][0]);
            SetEventFloat(event, "worldPosY", g_AnnotationPosition[id][1]);
            SetEventFloat(event, "worldPosZ", g_AnnotationPosition[id][2]);
            SetEventFloat(event, "lifetime", 5.0);
            SetEventInt(event, "id", id);
            SetEventString(event, "text", g_AnnotationText[id]);
            SetEventInt(event, "visibilityBitfield", bitstring);
            FireEvent(event);
        }
         else
            CancelCreatedEvent(event);
    }
}

[Geit]

Originally Posted by Kilandor This is slightly flawed, this prevents the leak but is improper if (bitstring > 1 || g_AnnotationCanBeSeen[id]) g_AnnotationCanBeSeen[id] is only set INSIDE of this Call, meaning Lets say if bitstring is 1 it will go in and set this to true, the problem is, lets say bitstring isn't 1, but the previous call it was. This causes it to go into that section anyways the reason it doesn't leak, is because FireEvent ALWAYS gets called unlike before bitstring had to be 1 to fire event. So its still a bit wasteful

This is intended - If a player moves into an area with an annotation visible and has the event sent to them, then moves out of it (and there are no other players in the area), the event will refire and hide the annotation rather than it taking up to 10 seconds to fade out normally.

Also: I Have another series of improvements that I could merge into the SQL version of this plugin, may do it over the weekend or whenever I get some time to do it.