[Antithasys]

Originally Posted by lokizito But what issue you found with the version cvar?

This just seems odd to me. Why double set the version number?

PHP Code:

    new Handle:version = CreateConVar("rankme_version",PLUGIN_VERSION,"RankMe Version",FCVAR_PLUGIN|FCVAR_REPLICATED|FCVAR_NOTIFY|FCVAR_DONTRECORD);
    SetConVarString(version,PLUGIN_VERSION,true,true); 


Originally Posted by lokizito And what them problem with they way i handle cvar changes...

You don't just change the cvar that was modified, instead, you reload all of them. This is bad practice in general, and really only passable if you have a small number of cvars, which you do not. You should only modify the variable of the cvar that was changed.

Originally Posted by lokizito ...and how should be the chat hooks?

You hook chat to run commands. I am going to have to add this to the rules, but basically, instead of hooking chat to see if they said something, you should turn that into a command and let SourceMod create the chat trigger for you. That way IsChatTrigger() will not fail, as your command would be properly registered. The whole way you do commands and chat triggers is "not clean".

Hope that helps.

[lokizito]

Originally Posted by Antithasys This just seems odd to me. Why double set the version number? PHP Code:     new Handle:version = CreateConVar("rankme_version",PLUGIN_VERSION,"RankMe Version",FCVAR_PLUGIN|FCVAR_REPLICATED|FCVAR_NOTIFY|FCVAR_DONTRECORD);     SetConVarString(version,PLUGIN_VERSION,true,true);

I may be wrong but i did that to make sure the version cvar would be changed if updated the plugin, or the flags will make that?

Originally Posted by Antithasys You don't just change the cvar that was modified, instead, you reload all of them. This is bad practice in general, and really only passable if you have a small number of cvars, which you do not. You should only modify the variable of the cvar that was changed.

Yeah, going to chang it.

Originally Posted by Antithasys You hook chat to run commands. I am going to have to add this to the rules, but basically, instead of hooking chat to see if they said something, you should turn that into a command and let SourceMod create the chat trigger for you. That way IsChatTrigger() will not fail, as your command would be properly registered. The whole way you do commands and chat triggers is "not clean".

The problem is that i am already creating the command. What i want is that, besides the command's triggers (! and /) to make possible use it without any trigger. (e.g: rank, top, top10)
How should that be done? Searched for ChatTrigger in the Documentation and only found the IsChatTrigger() .

Originally Posted by Antithasys Hope that helps.

Helps a lot.

[Antithasys]

Originally Posted by lokizito I may be wrong but i did that to make sure the version cvar would be changed if updated the plugin, or the flags will make that?

PLUGIN_VERSION is your define... change that and its changed.

Originally Posted by lokizito The problem is that i am already creating the command. What i want is that, besides the command's triggers (! and /) to make possible use it without any trigger. (e.g: rank, top, top10) How should that be done? Searched for ChatTrigger in the Documentation and only found the IsChatTrigger() .

Creating a command with the sm_ prefix automatically creates the chat triggers ! and /. So sm_test works with !test, and /test. Relying on 1 word chat messages to run commands is bad practice. Don't code for lazy users.

[lokizito]

Originally Posted by Antithasys PLUGIN_VERSION is your define... change that and its changed.

Not that. I'm saying that, for example, i'm running an old version, and then i update it and just reload the plugin. If i don't set it, won't the cvar be with the old value? Or PLUGIN_VERSION will take care of that?

Originally Posted by Antithasys Creating a command with the sm_ prefix automatically creates the chat triggers ! and /. So sm_test works with !test, and /test. Relying on 1 word chat messages to run commands is bad practice. Don't code for lazy users.

The thing is that the majority of players are lazy users. And also, Mani, gameMe and HLStatsX uses the chat message, so i added that for confort to players if they come from those rank systems.

For the CVars, do i need to create one callback for each or can simply use if's with the Handle:convar?

[Antithasys]

Originally Posted by lokizito Not that. I'm saying that, for example, i'm running an old version, and then i update it and just reload the plugin. If i don't set it, won't the cvar be with the old value? Or PLUGIN_VERSION will take care of that?

The version listed in sm plugins list will show the correct number. The version in the cvar will not unless you unload and load... not reload. That is by design, but I see your point. I am not requiring a change, just thought it was odd and a little dirty.

Originally Posted by lokizito The thing is that the majority of players are lazy users. And also, Mani, gameMe and HLStatsX uses the chat message, so i added that for confort to players if they come from those rank systems.

I understand your point, but neither I, nor the current staff, would approve a plugin that does this. If you insist on this type of functionality, the most that would be acceptable is hooking the usermessage or incorporating the forwards from the chat processor I recently released. This method doesn't interfere with the say and sayteam commands.

As a side note, handling chat like this is exactly why the old Simple Chat Colors was unapproved and discontinued.

Originally Posted by lokizito For the CVars, do i need to create one callback for each or can simply use if's with the Handle:convar?

Both methods are ok. I would do if, else if, statements to keep it all under 1 function.

[lokizito]

Originally Posted by Antithasys The version listed in sm plugins list will show the correct number. The version in the cvar will not unless you unload and load... not reload. That is by design, but I see your point. I am not requiring a change, just thought it was odd and a little dirty.

Now I understand.

Originally Posted by Antithasys I understand your point, but neither I, nor the current staff, would approve a plugin that does this. If you insist on this type of functionality, the most that would be acceptable is hooking the usermessage or incorporating the forwards from the chat processor I recently released. This method doesn't interfere with the say and sayteam commands. As a side note, handling chat like this is exactly why the old Simple Chat Colors was unapproved and discontinued.

Can you post me the link to the chat processor you released?

Originally Posted by Antithasys Both methods are ok. I would do if, else if, statements to keep it all under 1 function.

I'm doing the if, else if.

[lokizito]

New version posted. (Fix, Features and Changes)
See first post for changelog.

[GrO]

Originally Posted by lokizito New version posted. (Fix, Features and Changes) See first post for changelog.

Something is wrong with version 2.5.0:

- typing rank spams the chat with multiple displays of ranking
- players can't use the chat at all, everything is blocked now

Can You temporarily post version 2.4.5 here, cause I've deleted the old version and people are spamming me, cause I had to disable RankMe plugin?

EDIT:
I've got the previous version from sourceforge.

BTW, what's rankme.sq3-journal file?

[lokizito]

Thank GrO. Will look at it. I've removed the download and will put it back when i fix it.

[GrO]

No problem.

Originally Posted by GrO BTW, what's rankme.sq3-journal file?