[xNos]

Yo man nice code like your plugins code style!

[shavit]

Originally Posted by xNos Yo man nice code like your plugins code style!

Thanks!

[KyleS]

Cool plugin! You make some dangerous assumptions though in OnPluginStart though You should call GetConVarBool instead of assuming the convars have their default values. If I were to set sm_information_enabled to false, and reload the plugin, the plugin would assume it's true. Since you're using HookConVarChange, you can just invoke the callback with your handle ConVarChanged(gH_Enabled). I'm not really sure about sharing the callback, but it shouldn't be too bad as you only have three. If you get more convars, you may want to consider separate callbacks.

You should probably use ReplyToCommand (faithfully) in your cmd callback. This way you don't get the data printed to chat if clients don't want that (and instead want it in their console). You can also combine most of the PrintToChat operations into one single native call.

You should definitely check the return of GetClientAuthString, however, since you're using new instead of decl, this is safe at the moment (you probably already know this ;)).

Regardless, cool idea of allowing the client to see data on themselves!

[shavit]

Originally Posted by KyleS Cool plugin! You make some dangerous assumptions though in OnPluginStart though You should call GetConVarBool instead of assuming the convars have their default values. If I were to set sm_information_enabled to false, and reload the plugin, the plugin would assume it's true. Since you're using HookConVarChange, you can just invoke the callback with your handle ConVarChanged(gH_Enabled). I'm not really sure about sharing the callback, but it shouldn't be too bad as you only have three. If you get more convars, you may want to consider separate callbacks. You should probably use ReplyToCommand (faithfully) in your cmd callback. This way you don't get the data printed to chat if clients don't want that (and instead want it in their console). You can also combine most of the PrintToChat operations into one single native call. You should definitely check the return of GetClientAuthString, however, since you're using new instead of decl, this is safe at the moment (you probably already know this ;)). Regardless, cool idea of allowing the client to see data on themselves!

I have fixed/optimized everything you have mentioned.
Tho I've been already using ReplyToCommand.

[ColdWar]

Thanks, I was looking for one either, nice coding tho..

[RedSword]

Hi,

Overall it looks good. Approved.

One thing you might not be aware of :

you need both FCVAR_NOTIFY and FCVAR_SPONLY to get a "version" convar (detected properly by some scripts) AFAIK.

Otherwise, interesting plugin !

[derbmann]

Hello,

Why you delete "Client Index:" and "Admin:" from the Code?

best regards,

derbmann

[shavit]

3.6 (29 December 2013) -
* Now country shows also target's country, not yours.

[SooStoked]

awesome, you are still updating this! thanks again!

[Robin955]

if i make admins sm_info "deny"

doesn't that also deny the !info command?

i mean you put 2 commands in one, !info test
and !info

type !info and i check my own stats, type !info test and i check test's stats

does B flag have the command to use this? i suppose its C and above

and a couple pro plugins lists their shortcut onto !settings menu.

type !settings and you should have a Info - Show Client Information and you click it and it automatically launches the !myinfo command. (dont know how hard it would be to add it to the !settings menu)

"Overrides"
{
"sm_info" "deny"
}

cant be denied?