[crazyeffect]

Ik vind unbannen een English woord ^^

[Exolent[jNr]]

1. You should really use Tries to check bans instead of always reading file.

2. load_mapbans() will remove all permanent bans after map change.
In fact, since you are always looking in the file for bans, there is no need for that function.
It actually breaks your plugin.

3. Don't make every function "public".
You only need to make public functions for hooks/forwards/handlers.

Approval pending on changes.

[grimvh2]

Ok I will fix this after the new cmd adders.

I was relooking this plugin yesterday or something and I also tought there was something wrong with it lol :p

Edit :

I fixed point 2. and 3.
But now I have learned about Trie (because of my New Command Adder plugin) I dont see the use of using Trie instead of an array.

So for now current version 1.6 Released without Trie ( When I know why it would be usefull here I will add it )

[xPaw]

Trie is perfect place here.
When map starts/admin bans player, it adds banned players steamid into the trie, then in loadban you simply do this:

do_loadban( const id ) {
    new szAuthid[32];
    get_user_authid(id, szAuthid, sizeof(szAuthid)-1);
    
    if( TrieKeyExists( Bans, szAuthid ) )
        server_cmd("kick ^"#%i^"", get_user_userid(id));
}

The point is, you dont need to loop trough the file when anyone connects.

Btw. store mapname in globalvariable, it would be even better to generate path in plugin_init and save it to global var.

[grimvh2]

Yes I tought about the most stuff to,
About Trie I dont know every detail about what trie can do so thats why I wasn't sure but I will add it now.

Edit :

New version BETA releaded
Note : Not tested version yet, I will try to test it as soon as possible.

[xPaw]

use file_exists in do_removemapbans

You actually never check if ban time expiried when player connects, you just check if player exists in trie

[grimvh2]

Originally Posted by xPaw use file_exists in do_removemapbans

I already did that, I guess you need to dl the new version.

Originally Posted by xPaw You actually never check if ban time expiried when player connects, you just check if player exists in trie

It doesnt work on time, it works on counts. Evrey time that map where a player is banned gets played by the server, we remove a count untill all counts are gone. Or do you mean something else?

[krzyzak333]

Polish

[pl] CMD_BAN = %s Zostal zbanowany na ta mape przez %s. SUC_UNBAN = %s Zostal odbanowany z %s. FAIL_UNBAN = Wystapil problem z odbanowaniem %s z %s. DIR_NTFOUND = Folder %s nie zostal odnaleziony.

[grimvh2]

thx

[Hawk552]

There are a few mistakes and optimizations that can be made, however it is acceptable.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Approved.