[Nextra]

Well done. Here are some things you could/should do:

- CurWeapon event is fired for a specific player, no need to loop through all players.
- If you are looping through all players like you do in the vote functions: player id's range from 1 - maxplayers, not from 0 - mayplayers. The following is correct:

PHP Code:

for(new i = 1; i <= g_iMaxPlayers; i++) 


- In KnifeRoundStart loop, check for the player being alive first.
- You could pass the winning team through set_task and use only one vote function instead of vote_ct and vote_t separately.
- In SwapTeams you are executing sv_restartround on every loop. This is unnecessary, do it once after the loop has finished.
- In SwapTeams you should first check if the player is spectator or unassigned.
- Why are you only blocking touch for the Scout?
- It may be a good idea to store all the weapons for the following round and regiving them to all the players.
- Why are you mixing get_players() and "manual" looping? This is not a mistake, I'm just interested ;)

[lazarev]

- Why are you only blocking touch for the Scout?

my bad, i forget to change weapon_scout to weapon_c4 ^^

- In SwapTeams you are executing sv_restartround on every loop. This is unnecessary, do it once after the loop has finished. - In SwapTeams you should first check if the player is spectator or unassigned.

Done.

- You could pass the winning team through set_task and use only one vote function instead of vote_ct and vote_t separately.

Tolsty made a vote for me, ok I will try to do something... =)

- If you are looping through all players like you do in the vote functions: player id's range from 1 - maxplayers, not from 0 - mayplayers.

ok =))

[Hawk552]

This plugin is redundant but does the job better than the other similar plugins out there.

There are a few mistakes and optimizations that can be made, however it is acceptable.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Approved.

[Nextra]

PHP Code:

if (team == CS_TEAM_SPECTATOR) return PLUGIN_HANDLED; 


Do that before you are setting the team. Otherwise you will be switching spectators to terror team. Don't return PLUGIN_HANDLED, just use "continue" or you will stop the loop. Also you need to check for CS_TEAM_UNASSIGNED aswell.

PHP Code:

    get_players(players, g_iMaxPlayers)
    
    for(new i = 0; i < g_iMaxPlayers ; i++) 


That's why I asked for you using both get_players and "manual" looping. You are mixing things up and therefore making mistakes. g_iMaxPlayers is not to be used when you use get_players, you need a separate variable (local) for the second value. Looping through 1-maxplayers and players[] is different. I'd suggest you to only use one of the two methods.

PHP Code:

        if (weapon != CSW_KNIFE && is_user_alive(i)) 


You can (or should) check is_user_alive even before getting the weapon.

[lazarev]

Updated to 1.8

[Jon]

PHP Code:

public cur_weapon() {
    if(g_KnifeRound) {
        for(new i = 1; i <= g_iMaxPlayers; i++)
    {
        if (is_user_alive(i))
        engclient_cmd(i, "weapon_knife")
    }
  }
} 


You fail.

[lazarev]

^^

[Jon]

I'm not a plugin approver. BUT: This plugin has several stupid mistakes and should never have been approved. See post #33 too.

Yet again:

PHP Code:

register_event("CurWeapon", "cur_weapon", "be", "1=0", "2=29")

public cur_weapon() {
    if(g_KnifeRound) {
        for(new i = 1; i <= g_iMaxPlayers; i++)
    {
        if (is_user_alive(i))
        engclient_cmd(i, "weapon_knife")
    }
  }
} 


This is a wrong and a terrible way to block players using other weapons than knife.

PHP Code:

public KnifeRoundStart(id) {
    g_KnifeRound = true;
    for(new i = 0; i <= g_iMaxPlayers; i++)
    {
        new weapon = get_user_weapon(id)
        if (is_user_alive(i) && weapon != CSW_KNIFE) 
            engclient_cmd(i, "weapon_knife")
    }
} 


Retriving weapon from the wrong index.

PHP Code:

for(new i = 0; i <= g_iMaxPlayers; i++) 


3 loops are using this code, which is wrong.

PHP Code:

register_clcmd("shield", "shield_block")

public shield_block(id) {
    if(g_KnifeRound) {
        return PLUGIN_HANDLED
    }
    return PLUGIN_CONTINUE
} 


Won't work at all.

[Hawk552]

Originally Posted by Jon I'm not a plugin approver. BUT: This plugin has several stupid mistakes and should never have been approved. See post #33 too.

Yeah, I just looked through 6 pages of plugins, which took me over 2 hours. I usually miss things like this or unapprove a few plugins by accident when I write that I'm going to approve it or vice-versa.

Anyway, unapproved until those problems are fixed.

[lazarev]

Updated to 1.9, check the code please =)