[bottiger]

Just a question, why do you have a prehook and a post hook? Why not move "DHookGetParamString(hParams, 1, g_sFilename, sizeof(g_sFilename));" to the beginning of the post hook and get rid of the prehook?

[cravenge]

Originally Posted by bottiger Just a question, why do you have a prehook and a post hook? Why not move "DHookGetParamString(hParams, 1, g_sFilename, sizeof(g_sFilename));" to the beginning of the post hook and get rid of the prehook?

Cuz there are cases where params can only be readable in pre hooks and return NULL or different results in post hooks, at least that's what I know about DHooks so far.

[Silvers]

Originally Posted by bottiger Just a question, why do you have a prehook and a post hook? Why not move "DHookGetParamString(hParams, 1, g_sFilename, sizeof(g_sFilename));" to the beginning of the post hook and get rid of the prehook?

What Cravenge said. Params not always available in post hook. This could all be moved to pre hook since the file is valid then, but I'm keeping the check in post hook to make sure.

1.4 (10-May-2020)
    - Added support for "Zombie Panic! Source" game. Requires gamedata update.
    - Fixed "sm_spray_test" timing out when checking many sprays. Thanks to "Sreaper" for reporting and testing.
    - Now checks 50 files and waits 0.1 seconds before checking the next batch.
    - TF2 updated to fix clients crashing, but this plugin is still recommended to delete the other randomly uploaded user files.

(also 120 of 125 my plugins updated lol)

[CliptonHeist]

Been having this issue with latest version of plugin on HL2:DM Linux, SM 1.10.0.6458

L 05/13/2020 - 17:59:45: [SM] Exception reported: Failed to find "CGameClient::FileReceived" signature.
L 05/13/2020 - 17:59:45: [SM] Blaming: spray_exploit_fixer.smx
L 05/13/2020 - 17:59:45: [SM] Call stack trace:
L 05/13/2020 - 17:59:45: [SM]   [0] SetFailState
L 05/13/2020 - 17:59:45: [SM]   [1] Line 84, C:\Servers\L4D2\left4dead2\addons\sourcemod\scripting\spray_exploit_fixer.sp::OnPluginStart
L 05/13/2020 - 17:59:45: [SM] Unable to load plugin "spray_exploit_fixer.smx": Error detected in plugin startup (see error logs)

I downloaded the plugin files again and replaced them as well as dhooks but it didn't help :c

[Silvers]

Thank you, fixed gamedata issue.

1.5 (14-May-2020)
    - Added better error log message when gamedata file is missing.
    - Fixed gamedata for HL2:DM. Thanks to "CliptonHeist" for reporting and "asherkin" for explaining engine != game.
    - (Info: the gamedata "engine" key for HL2:DM uses "hl2dm" (the engine name) while the "game" part uses "hl2mp" (game name) e.g. for offsets).

[KyleS]

Hi Silvers,

Does OnFileSend and OnFileReceive not help out a little here? Just trying to understand why dhooks is required :-). Additionally, how I've gone even further with this is hooking the TE event.

[Silvers]

OnFileReceive happens when a file is being sent, not yet received by the server (so no file exists and cannot be checked). OnFileSend I guess only happens when clients request the file (so would duplicate checks unless storing a flag of known checked ones basically) so gone with detour when the file has finished being sent so can check only on send and if bad delete. Pretty sure post hook detour not required but I gone with checking there instead of pre hook just to make sure games done with it and file is valid.

[KyleS]

Originally Posted by Silvers OnFileReceive happens when a file is being sent, not yet received by the server (so no file exists and cannot be checked). OnFileSend I guess only happens when clients request the file (so would duplicate checks unless storing a flag of known checked ones basically) so gone with detour when the file has finished being sent so can check only on send and if bad delete. Pretty sure post hook detour not required but I gone with checking there instead of pre hook just to make sure games done with it and file is valid.

Uploading or similar doesn't actually matter here, same with holding the file. If the file is requested, scan it and block if it's malicious. If the decal request happens before or after that gives you the offending player who tried and you can do what you want with them.

Does that make sense?

[Silvers]

This plugin has undergone some big changes and is now version 2.0. No longer requires DHooks and should support all games.

[Silvers]

2.0 (09-Aug-2020)
    - Now should support all games.
    - Added more checks for invalid files.
    - Added cvar "spray_exploit_fixer_path" to specify the downloads folder if not correctly detected.
    - Removed gamedata and DHooks dependency.
    - Removed cvar "spray_exploit_fixer_name".