[Bugsy]

Originally Posted by aron9forever So is there any way to stop other plugin's from stopping my task? I see no params at set_task to make it unstoppable(kek)

Just make the task-id unique. For example: 231431, if it's for running on a player do 231431 + id.

[HamletEagle]

In this case it was very clear, wasn't it ?

[aron9forever]

Originally Posted by Bugsy Just make the task-id unique. For example: 231431, if it's for running on a player do 231431 + id.

any limits on taskid except 32bit integer?
I always used 4 digit numbers till now

I was talking about other bad coded plugins or malicious plugins ending my tasks, either by accident or intentionally, unique id is only unique in my script, who knows what other people put in theirs.

This is a little loophole that should be patched, imagine stopping the banlist checking task of advancedbans for example, you can't even notice this strange activity unless you check both scripts and notice they use the same ids

[Bugsy]

I'm not sure of the data-type used for the id, but even at a minimum it is a signed 16-bit integer, with that you have 32,767 to work with. You're trying to tell me that some other scripter is going to try to decipher what you use as task-id's?

You can always make them dynamic. Create a global array and when the plugin starts (or task is created) load this task-id array with random numbers.

Edit: It's appears to be cell which is 32-bit signed: −2,147,483,648 to 2,147,483,647

class CTask
{
	// task settings
		
	CPluginMngr::CPlugin *m_pPlugin;
	cell m_iId;
	int m_iFunc;
	int m_iRepeat;

[aron9forever]

Originally Posted by Bugsy I'm not sure of the data-type used for the id, but even at a minimum it is a signed 16-bit integer, with that you have 32,767 to work with. You're trying to tell me that some other scripter is going to try to decipher what you use as task-id's? You can always make them dynamic. Create a global array and when the plugin starts (or task is created) load this task-id array with random numbers. Edit: It's appears to be cell which is 32-bit signed: −2,147,483,648 to 2,147,483,647 class CTask { // task settings CPluginMngr::CPlugin *m_pPlugin; cell m_iId; int m_iFunc; int m_iRepeat;

Yes, that's a good idea, thanks. Also thanks for fetching the info, it's good to know i can use larger numbers

[Depresie]

i have one more question

why are these "{}" used in this case ?

PHP Code:


new bool:gHasSnark    [ MAX_CLIENTS + 1 char ];
new bool:gWeaponActive[ MAX_CLIENTS + 1 char ];
new bool:gJustThrown  [ MAX_CLIENTS + 1 char ];

new Float:gNextShot      [ MAX_CLIENTS + 1 ];
new Float:gTimeWeaponIdle[ MAX_CLIENTS + 1 ];

new gPlayerAmmo[ MAX_CLIENTS + 1 char ];

public client_connect ( Player )
{
    gHasSnark    { Player } = false;
    gWeaponActive{ Player } = false;
    gJustThrown  { Player } = false;
    gPlayerAmmo  { Player } = get_pcvar_num( pCvarAmmo );
} 


[Bugsy]

Because he is declaring the arrays as a packed string using the keyword 'char' after the size value which will reduce the number of cells that are allocated. This is beneficial because it uses every byte within the cell, versus declaring it 'regular' which only uses 1 byte within each cell (4-bytes).

new bool:gHasSnark [ MAX_CLIENTS + 1 char ];

The { } is needed to reference the cell. Doing this saves a bit of memory because it will declare an array of only 33 bytes, versus an array of 132 bytes (33 * 4).

new bool:gHasSnark[ MAX_CLIENTS + 1 = 33 * 4 = 132 bytes of memory
new bool:gHasSnark[ MAX_CLIENTS + 1 char ] = 33 = bytes of memory

More info here: https://forums.alliedmods.net/showthread.php?t=90735

Unfortunately the AMX-X string natives are not built to use packed strings.

[wicho]

What is better bits or char?

[Bugsy]

Bits can only be used for storing boolean values, or groups of smaller values-- ie. you can store 16 values between 0-3 within 1 cell. Char is good for storing ascii characters, or any values 0-255 since it is limited to 1 byte.

[Depresie]

what do you mean by this ?
"Unfortunately the AMX-X string natives are not built to use packed strings"

It could cause server crash? or something? because i encounter server crashes on linux with no error logs running the plugin containing that code, and i couldn't find a solution for several weeks

link here:
https://forums.alliedmods.net/showthread.php?t=270179